Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Apr 03 2018 11:28
    marcinczeczko labeled #402
  • Apr 03 2018 11:28
    marcinczeczko labeled #402
  • Apr 03 2018 11:28
    marcinczeczko milestoned #402
  • Apr 03 2018 11:28
    marcinczeczko milestoned #402
  • Apr 03 2018 11:27
    marcinczeczko opened #402
  • Apr 03 2018 11:27
    marcinczeczko opened #402
  • Apr 03 2018 11:19
    marcinczeczko commented #396
  • Apr 03 2018 11:18
    marcinczeczko edited #396
  • Apr 03 2018 11:18
    marcinczeczko edited #396
  • Apr 03 2018 11:17

    marcinczeczko on 398-config-defaults

    (compare)

  • Apr 03 2018 11:17

    marcinczeczko on backpressure-and-configs

    Reorganized standaolone & examp… Merge branch 'milestone/backpre… Set a version of target release and 16 more (compare)

  • Apr 03 2018 11:17
    marcinczeczko closed #400
  • Apr 03 2018 07:49
    marcinczeczko synchronize #400
  • Apr 03 2018 07:49

    marcinczeczko on 398-config-defaults

    Set target version for this bra… Merge branch 'milestone/backpre… (compare)

  • Apr 03 2018 07:48

    marcinczeczko on backpressure-and-configs

    Set target version for this bra… (compare)

  • Apr 03 2018 07:44
    marcinczeczko closed #398
  • Apr 03 2018 07:44
    marcinczeczko closed #398
  • Apr 03 2018 07:44
    marcinczeczko commented #398
  • Apr 03 2018 07:40
    marcinczeczko synchronize #400
  • Apr 03 2018 07:40

    marcinczeczko on 398-config-defaults

    Documentation fix. #394 Added encoding of uri para… Write a test case for requestin… and 5 more (compare)

Szymon Nowka
@nowszy94
It's not a secret key, you can see request's like that one on sites that implements site search :)
Tomasz Michalak
@tomaszmichalak
ok I thought that you generated this token for your testing purposes
could you please put here exception stacktrace?
Maciej Laskowski
@Skejven
maybe in some Gist :)
Szymon Nowka
@nowszy94
https://gist.github.com/nowszy94/31de0cb8f7faafb76fdc52cd6ac58099 - exception thrown after removing "port": 443 from config, https://gist.github.com/nowszy94/0b3309ee8c75d1deb9db15d2be5590cc - exception thrown with "port": 443
Tomasz Michalak
@tomaszmichalak
can you call this service with 80 port?
you should get some error json response - we can validate if the problem is connected with https
Szymon Nowka
@nowszy94
wow, switching to 80 solved the problem
Szymon Nowka
@nowszy94
hmm, but is this valid? Port 80 is not a https port...
unfortunatelly it doesn't solved the problem
i get some data
but not expected one
i'll check it
Szymon Nowka
@nowszy94
request with port 80 didn't thrown any exception in knotx, but i couldn't receive expected (kind) data - Maciej example.
Marcin Czeczko
@marcinczeczko
/all I created PR with the fix for URL encoded form attributes send in POST request (by action adapter)
See: Cognifide/knotx#244
Tomasz Michalak
@tomaszmichalak
@marcinczeczko have you checked any reference implementation like https://netty.io/4.0/api/io/netty/handler/codec/http/multipart/HttpPostRequestEncoder.html ?
Marcin Czeczko
@marcinczeczko
yes
the one you're mentioned tackles with multipart POST - it's the second think to do
Tomasz Michalak
@tomaszmichalak
so we support only "application/x-www-form-urlencoded" ?
I think tha t we should provide abstaction for FormBodyBuilder and then we can decide somewhere else which implementaiton we want to use
@nowszy94 we will come back to your topic tomorrow
Maciej Laskowski
@Skejven
@nowszy94 I fixed issue with client options configuration reading: Cognifide/knotx#246
after this fix, when you set "ssl": true in your HttpServiceAdapter configuration like this:
"knotx:io.knotx.HttpServiceAdapter": {
      "options": {
        "config": {
          "address": "knotx.adapter.service.http",
          "clientOptions": {
            "maxPoolSize": 1000,
            "keepAlive": false,
            "logActivity": true,
            "ssl": true
          },
          "services": [
            {
              "domain": "www.googleapis.com",
              "port": 443,
              "path": "/customsearch/.*",
              "address": "knotx.adapter.service.http"
            }
          ]
        }
      }
    }

I've tested it with following snippet:

      <script data-knotx-knots="services,handlebars" data-knotx-service="site-search-google"
              type="text/knotx-snippet">
        <h2>Kind - {{_result.kind}}</h2>
      </script>

and rendered result was

blob
Tomasz Michalak
@tomaszmichalak
@nowszy94 Cognifide/knotx#246 is merged to master, can you please check it now?
Szymon Nowka
@nowszy94
it solved the problem
Maciej Laskowski
@Skejven
great :+1:
Tomasz Michalak
@tomaszmichalak
we plan to release 1.0.0-RC6 with:
Cognifide/knotx#243
Cognifide/knotx#244
Cognifide/knotx#246
those PRs fix problems with the configuration and the correct form encoding (for "application/x-www-form-urlencoded")
Tomasz Michalak
@tomaszmichalak
Karol Drazek
@karoldrazek
Guys, quick question. In previous versions of knotx, there was requirement for 'file-uploads’ directory to exist in knotx user homedir. Is it still valid, is it configurable?
Tomasz Michalak
@tomaszmichalak
forms do not support file uploads now
Karol Drazek
@karoldrazek
But is the directory still required? Previously knotx was throwing error during start, because it tried creating this dir where it didn’t have permissions.
Tomek Niedźwiedź
@toniedzwiedz
Does Knot.x support multipart/form-data at all?
Tomasz Michalak
@tomaszmichalak
Cognifide/knotx#247
Szymon Nowka
@nowszy94
Does knot'x provides some additional handlebars helpers? I know i could write my own extension, but maybe knotx already provides it.
Tomasz Michalak
@tomaszmichalak
only default helpers
Tomasz Michalak
@tomaszmichalak
Cognifide/knotx#253
Maciej Laskowski
@Skejven
you may create custom handlebars helper
Tomasz Michalak
@tomaszmichalak
performance issue: Cognifide/knotx#256
we plan to fix it in 1.0.0 release
Tomasz Michalak
@tomaszmichalak
new PR connected with Jsoup usage optimisation (tests before planned changes): Cognifide/knotx#257
Tomasz Michalak
@tomaszmichalak
merged: Cognifide/knotx#255
merged: Cognifide/knotx#257
Tomasz Michalak
@tomaszmichalak
Cognifide/knotx#261, approve please
Maciej Laskowski
@Skejven
@Marcin - this is ok
this is a part of APL license
Pawel
@pawelkoper
Hey could you tell me what is the option to see the "envelopes" of http packets sent by knotx?
Marcin Czeczko
@marcinczeczko
give me sec

For instance, on the adapter verticle, add option logActivity: true on clientOptions object, as follows

 "options": {
    "config": {
        "clientOptions": {
              ...
              "logActivity": true
         }
     }
}

then in logback.xml set DEBUG level for netty handler:

<logger name="io.netty.handler.logging" level="DEBUG"
        additivity="false">
  <appender-ref ref="STDOUT"/>
</logger>