Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Maciej Laskowski
@malaskowski
you should have access to create branches in knotx-website repo now
Tomek Niedźwiedź
@toniedzwiedz
Cheers
Tomek Niedźwiedź
@toniedzwiedz
@Skejven @tomaszmichalak FYI, I'm working on the latest tutorial, I'll push my changes to the same branch
Tomasz Michalak
@tomaszmichalak
Ok. I am sick so not available now
Tomek Niedźwiedź
@toniedzwiedz
@tomaszmichalak that didn't stop you from suggesting changes 2 hours ago :)
Get well soon!
Maciej Laskowski
@malaskowski
@toniedzwiedz thanks - I will wait for your updates and comments
Tomek Niedźwiedź
@toniedzwiedz
@Skejven Tomek made a good point about the title. It's a wee bit dull. I doubt Custom Adapter Service are the words someone new to Knot.x would use to search for learning material.
Maciej Laskowski
@malaskowski
ok, I will think about something better, let's treat it as a working title for now
Tomek Niedźwiedź
@toniedzwiedz
Knotx/knotx-extension-archetype#1
PR for the first version of a Knot.x extension maven archetype
Not quite done yet but I'd like you to have a look and provide some feedback.
I'm planning to build an example Knot for reference.
And we need to decide on the kind of unit/integration testing we want to promote
I'd welcome some suggestions regarding the latter.
Tomek Niedźwiedź
@toniedzwiedz
@marcinczeczko @Skejven please enable Travis CI for https://github.com/Knotx/knotx-extension-archetype/ when you have a minute
I've added a config file to the wip branch already but I don't have admin access to the repo so I can't enable a build.
Marcin Czeczko
@marcinczeczko
@toniedzwiedz done
i think you news to push something
Tomek Niedźwiedź
@toniedzwiedz
thx
Tomek Niedźwiedź
@toniedzwiedz
Yup, Travis is running, building the archetype, using it to generate a project and then building the project.
Tomek Niedźwiedź
@toniedzwiedz
I merged the wip branch to master in knotx-extension-archetype. I have yet to provide:
  • a custom Knot example
  • an Action Adapter example
  • Unit test examples
    I raised separate issues for those
Karol Drazek
@karoldrazek
knotx coookbook updated to 0.2.3 which deploys knotx 1.0.1 by default
Tomasz Michalak
@tomaszmichalak
great job Karol !
Maciej Laskowski
@malaskowski
hi, I've just pushed a change from HttpClient to new WebClient in knot.x HttpFacade:
Cognifide/knotx#293
Tomasz Michalak
@tomaszmichalak
@toniedzwiedz Knotx/knotx-extension-archetype#8
@toniedzwiedz have you seen io.knotx.knot.action.ActionKnotProxyVerticleTest? this is quite nice "integration" test which checks the Knot response based on specific input
we wrote it before we implemented multi-step forms (TDD)
Tomek Niedźwiedź
@toniedzwiedz
@tomaszmichalak I bumped up the Knot.x version in the archetype.
Tomasz Michalak
@tomaszmichalak
nice ;)
Tomek Niedźwiedź
@toniedzwiedz
@tomaszmichalak as for the test recommendation, can you post this as a comment in Knotx/knotx-extension-archetype#3 ?
Tomasz Michalak
@tomaszmichalak
done
Tomasz Michalak
@tomaszmichalak
updated first rest integration tutorial: Knotx/knotx-tutorials#3
Tomasz Michalak
@tomaszmichalak
Knotx/knotx-website#17
I simplified a configuration a bit - removed a routing section as it is not required in 1.0.1. We should not complicate first tutorial with this information. We plan to create next tutorial where we will plugin authentication knot which must be configured in a routing.
Karol Drazek
@karoldrazek

Hey guys,

I’ve tried updating knotx cookbook for systemd and knotx 1.1.0, but can't get knotx to work.
All the files are just downloaded from release site.
https://gist.github.com/karoldrazek/da2d4bcb39557e9e039ac1f8aff86aad

Tomasz Michalak
@tomaszmichalak
In Uni we work on 1.1.0.
(Holidys)
Maciej Laskowski
@malaskowski
@karoldrazek - I'll try to run Knot.x 1.1.0 standalone today, however this tutorial:
http://knotx.io/blog/client-side-integration-with-knotx/
and Devoxx demo worked on 1.1.0 already I didn't have any problems with running it
Maciej Laskowski
@malaskowski
@karoldrazek you are right, there is a bug in a default knotx-standalone config, because default KnotxServer config wansn't adjusted to the new routing (defaultFlow/customFlow) configuration
I will prepare a hotfix release in the next days
Tomasz Michalak
@tomaszmichalak
Please mark this as fixed after hotfix: Cognifide/knotx#307
Maciej Laskowski
@malaskowski
ok, I will
Tomasz Michalak
@tomaszmichalak
Thanks @Skejven ;)
Tomasz Michalak
@tomaszmichalak
@toniedzwiedz we are working on knotx archetype
it would be nice if you will check this PR: Knotx/knotx-extension-archetype#12
Tomek Niedźwiedź
@toniedzwiedz
@tomaszmichalak I've had a quick look. The PR looks fine :+1:
Tomasz Michalak
@tomaszmichalak
Thanks @toniedzwiedz
Tomasz Michalak
@tomaszmichalak
new archetypes for Knot.x extensions available here: https://github.com/Knotx/knotx-extension-archetype