These are chat archives for Kuree/Sims4Tools

8th
Nov 2014
Snaitf
@Snaitf
Nov 08 2014 00:18 UTC
I'm gonna go make myself some dinner, be back in just a little bit
Snaitf
@Snaitf
Nov 08 2014 00:38 UTC
Ok, I'm back
Keyi Zhang
@Kuree
Nov 08 2014 00:50 UTC
okay crammed some dirty code
not sure if it works
cool at least it parses
Snaitf
@Snaitf
Nov 08 2014 00:53 UTC
ah, good stuff
Keyi Zhang
@Kuree
Nov 08 2014 00:59 UTC
now testing unparsing
grr some stuff are missing
Snaitf
@Snaitf
Nov 08 2014 01:01 UTC
:(
Keyi Zhang
@Kuree
Nov 08 2014 01:31 UTC
duh my laptop just crashed
take a while to recover
(I need to buy a new one)
Snaitf
@Snaitf
Nov 08 2014 01:43 UTC
Well that sucks.
Keyi Zhang
@Kuree
Nov 08 2014 01:44 UTC
@Snaitf would you please test the new MATD wrapper?
I fixed peter's old wrapper
it should work now
Snaitf
@Snaitf
Nov 08 2014 01:44 UTC
kk, one sec
Keyi Zhang
@Kuree
Nov 08 2014 01:44 UTC
ty
Snaitf
@Snaitf
Nov 08 2014 01:50 UTC
looks good to me
Keyi Zhang
@Kuree
Nov 08 2014 01:50 UTC
cool
are you sure these are all uint?
Snaitf
@Snaitf
Nov 08 2014 01:51 UTC
which ones?
oh, you mean maybe they're floats? they could be, i'm not sure
Keyi Zhang
@Kuree
Nov 08 2014 01:52 UTC
Uint32 (Count)
{
  Byte
  Uint32

  Uint32 (Count)
  {
    Byte x 17

    Uint32 (Count)
    {
      Byte
      Uint32
    }
  }
}
this part
Snaitf
@Snaitf
Nov 08 2014 01:53 UTC
well, they look like it to me, but am I sure? no, i haven't tested it or anything
Keyi Zhang
@Kuree
Nov 08 2014 01:53 UTC
kk
just ask
it keeps giving weird result
maybe my code is wrong
Snaitf
@Snaitf
Nov 08 2014 01:53 UTC
well, they are definately 4 bytes long
i thought you meant, like, they could be 2 words, instead of 1 dword, or something
Keyi Zhang
@Kuree
Nov 08 2014 02:02 UTC
the parsing is totally fine now
I found several bugs and squashed them
:P
Snaitf
@Snaitf
Nov 08 2014 02:03 UTC
You brought them into this world, only fitting that you should take them out. ;)
Keyi Zhang
@Kuree
Nov 08 2014 02:05 UTC
after I finish the unparsing part I will commit the working code so that you can test it
in the meanwhile i will clear up the code
hmm 0x10 bytes are missing
Snaitf
@Snaitf
Nov 08 2014 02:06 UTC

Oh, I forgot to mention, I found a problem with CASP files, and the problem still persists in your new wrapper: When trying to add an LODInfoEntry:
Front-end Distribution: 14-0920-48
Library Distribution: 14-118-146
== START ==
Source: mscorlib
Assembly: mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089
Constructor on type 'CASPartResource.CASPartResourceTS4+LODInfoEntry' not found.
at System.RuntimeType.CreateInstanceImpl(BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes, StackCrawlMark& stackMark)

at System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes)

at System.Activator.CreateInstance(Type type, Object[] args)

at s4pi.Interfaces.DependentList`1.Add(Type elementType) in c:\Users\Adam\Desktop\Sims4Tools-master\Sims4Tools-master\s4pi\Interfaces\DependentList.cs:line 247

at s4pi.Interfaces.DependentList`1.Add() in c:\Users\Adam\Desktop\Sims4Tools-master\Sims4Tools-master\s4pi\Interfaces\DependentList.cs:line 133

at S4PIDemoFE.NewGridForm.simpleAddInsert(Boolean add) in c:\Users\Adam\Desktop\Sims4Tools-master\Sims4Tools-master\s4pe\s4pePropertyGrid\NewGridForm.cs:line 213

== END ==

Keyi Zhang
@Kuree
Nov 08 2014 02:07 UTC
oh hmm
I think I know the reason
Snaitf
@Snaitf
Nov 08 2014 02:07 UTC
just thought I'd point that out
Keyi Zhang
@Kuree
Nov 08 2014 02:07 UTC
it doesn't have a default constructor I think
ty
normal people won't touch that part :P
Snaitf
@Snaitf
Nov 08 2014 02:08 UTC
true
Snaitf
@Snaitf
Nov 08 2014 02:14 UTC
Hmm, I was wondering, as with the MATD files, ones that have a reference to itself, is there a way to automatically update the file when it's instance # is changed?
Keyi Zhang
@Kuree
Nov 08 2014 02:15 UTC
no
Snaitf
@Snaitf
Nov 08 2014 02:15 UTC
didn't think so...
Keyi Zhang
@Kuree
Nov 08 2014 02:15 UTC
the tool maker must know that
Snaitf
@Snaitf
Nov 08 2014 02:16 UTC
right, right
Keyi Zhang
@Kuree
Nov 08 2014 02:30 UTC
okay exact unparsing
do you want test now?
I can commit the code
Snaitf
@Snaitf
Nov 08 2014 02:30 UTC
sure
Keyi Zhang
@Kuree
Nov 08 2014 02:31 UTC
kk committed
now I need to clean up the code according to s4pi's coding style
too many dirty hacks
Snaitf
@Snaitf
Nov 08 2014 02:32 UTC
ok, i'll go test those age/gender flags
Keyi Zhang
@Kuree
Nov 08 2014 02:35 UTC
the age and gender is still called unknown
Snaitf
@Snaitf
Nov 08 2014 02:36 UTC
kk
Snaitf
@Snaitf
Nov 08 2014 02:52 UTC
They all seem to match up, the only differences i'm seeing are some of the LOOK files will have YoungAdult, Adult, and Female and the associated SIMO file with have only YoungAdult, and Female. But this is probably due to SIMOs being used for more than just LOOKs. Because, other than that, they all match up perfectly. I feel it's pretty darn safe to call those age/gender.
Keyi Zhang
@Kuree
Nov 08 2014 02:52 UTC
cool
ty
Snaitf
@Snaitf
Nov 08 2014 02:53 UTC
np
Snaitf
@Snaitf
Nov 08 2014 03:00 UTC
Hmm, just notice that the ExcludePartFlags in your new CASP is labeling the BodyType wrong
Keyi Zhang
@Kuree
Nov 08 2014 03:00 UTC
I just copy and paste
Snaitf
@Snaitf
Nov 08 2014 03:00 UTC
Set one to 0x40 (which is BODYTYPE_UPPERBODY), and it labels it as BODYTYPE_SKINDETAIL_CREASEFOREHEAD
Keyi Zhang
@Kuree
Nov 08 2014 03:01 UTC
did you check my code?
Snaitf
@Snaitf
Nov 08 2014 03:01 UTC
haven't looked, will now
Snaitf
@Snaitf
Nov 08 2014 03:14 UTC
i'm not seeing where the error lies, setting the field to 0x02 results in BODYTYPE_FACEPAINT, which is clearly set as 1 << 33 in your enum
Keyi Zhang
@Kuree
Nov 08 2014 03:15 UTC
wait I think I know the reason
make it to :ulong
so like this
public enum blahblah :ulong
Snaitf
@Snaitf
Nov 08 2014 03:17 UTC
yea, already tried that
BODYTYPE_EYELINER = 1 << 31
gives an error
Error 7 Constant value '-2147483648' cannot be converted to a 'ulong' C:\Users\Adam\Desktop\Sims4Tools-master\Sims4Tools-master\s4pi Wrappers\CASPartResource\CASPartResourceTS4.cs 730 33 CASPartResource
tried just long as well, but that had same results as nothing there
Why is it saying that 1 << 31 is negative? It isn't, is it?
Keyi Zhang
@Kuree
Nov 08 2014 03:23 UTC
that's the default type system
I will look into that
I need to go
be back in 10 minutes
Snaitf
@Snaitf
Nov 08 2014 03:25 UTC
kk
Keyi Zhang
@Kuree
Nov 08 2014 03:47 UTC
@Snaitf can you test it again?
I fixed the uong compiler error
Snaitf
@Snaitf
Nov 08 2014 03:48 UTC
ok, testing
all looks good now :clap:
Keyi Zhang
@Kuree
Nov 08 2014 03:51 UTC
cool ty for testing
simo's finishing up takes longer than I thought
with all these references
Snaitf
@Snaitf
Nov 08 2014 03:55 UTC
I can imagine it would
Keyi Zhang
@Kuree
Nov 08 2014 03:56 UTC
the current version should unparse fine
you can play with it now
Snaitf
@Snaitf
Nov 08 2014 04:07 UTC
Ok, this is weird, in s4pe, i choose file-new, then d&d a simo file onto it, the parse preview pane shows an error, unless i tick do not parse, then un-tick do not parse, then it shows the parsed file fine.
Keyi Zhang
@Kuree
Nov 08 2014 04:07 UTC
duh
I think it's because the stream position
Snaitf
@Snaitf
Nov 08 2014 04:08 UTC
ah
that would make sense
Keyi Zhang
@Kuree
Nov 08 2014 04:10 UTC
it's a long existing bug in s3pe
Snaitf
@Snaitf
Nov 08 2014 04:11 UTC
I just happened to notice that it doesn't do it with other file types, but it does with SIMO files
Keyi Zhang
@Kuree
Nov 08 2014 04:11 UTC
cos I didn't add reset stream position :P
Snaitf
@Snaitf
Nov 08 2014 04:12 UTC
heh, gotcha
Keyi Zhang
@Kuree
Nov 08 2014 04:12 UTC
okay simo is updated
adding not sure if adding new stuff in s4pe is going to work
the grid cannot handle the tgi reference
I'm continuing cleaning up the code
and I also update some information that I got when reading the resource
you can update the wiki as well
Snaitf
@Snaitf
Nov 08 2014 04:18 UTC
Ok, yea, when trying to add a new TGI reference, it throws it all off
Keyi Zhang
@Kuree
Nov 08 2014 04:18 UTC
lol
and I have no plan to let grid adding tgi reference
it's better to be handled by other tool
Snaitf
@Snaitf
Nov 08 2014 04:20 UTC
oof, simply clicking grid then commit messes it up
Keyi Zhang
@Kuree
Nov 08 2014 04:20 UTC
:O
I will check it
I might mess up something again
Snaitf
@Snaitf
Nov 08 2014 04:27 UTC
i just realized that gitter has a built in search, that will search the chat history, nice
Keyi Zhang
@Kuree
Nov 08 2014 04:28 UTC
yep
they just added it
Keyi Zhang
@Kuree
Nov 08 2014 04:40 UTC
the one that can't be edited unparse the stream wrong
0x025ED6F4-0x00000000-0x80579F0B814B76E9
it gives the wrong tgi position
aha found the bug
Keyi Zhang
@Kuree
Nov 08 2014 04:45 UTC
okay it should work now
Snaitf
@Snaitf
Nov 08 2014 04:46 UTC
ah, good
Keyi Zhang
@Kuree
Nov 08 2014 04:47 UTC
i have no idea why EA makes this resource so complicated
Snaitf
@Snaitf
Nov 08 2014 04:47 UTC
ikr
Keyi Zhang
@Kuree
Nov 08 2014 04:48 UTC
do you think I should release now or test other stuff to make sure it doesn't break anything?
I can release it tomorrow
Snaitf
@Snaitf
Nov 08 2014 04:49 UTC
maybe just release it with a note saying "May contain bugs"
lol
what more needs to be tested?
Keyi Zhang
@Kuree
Nov 08 2014 04:50 UTC
like catalog resource
I haven't tested it with cloning
but will test it tomorrow
that's the main part that I care about
Snaitf
@Snaitf
Nov 08 2014 04:50 UTC
oic
well, whatever your comfortable with, i guess
Keyi Zhang
@Kuree
Nov 08 2014 04:50 UTC
if you read my code you'll see I add some algorithm to make it self clone
Snaitf
@Snaitf
Nov 08 2014 04:51 UTC
ooooh, shiny!
which resources does that work with?
Keyi Zhang
@Kuree
Nov 08 2014 04:51 UTC
I will test it with s4 studio
all the catalog resources
here's the main part of self clone
Snaitf
@Snaitf
Nov 08 2014 04:53 UTC
does that work in the version on github? if so, how do i do it?
Keyi Zhang
@Kuree
Nov 08 2014 04:54 UTC
yes
I will show you the code
wait a sec
Snaitf
@Snaitf
Nov 08 2014 04:56 UTC
Oh, do you not have the UI implemented yet? I meant, where is the option in s4pe to create a clone?
Keyi Zhang
@Kuree
Nov 08 2014 04:56 UTC
no
s4pe doesn't have a option for clone
maybe I can add that
it's designed for other tool makers
Snaitf
@Snaitf
Nov 08 2014 04:57 UTC
oic, ok
Keyi Zhang
@Kuree
Nov 08 2014 04:58 UTC
grr I forgot where I put the clone code
Snaitf
@Snaitf
Nov 08 2014 04:58 UTC
how do i show something in code, like you did before with the counts?
Keyi Zhang
@Kuree
Nov 08 2014 04:59 UTC
click the line
then you'll get a new url
oh I thought you're talking about the clone code
Snaitf
@Snaitf
Nov 08 2014 05:00 UTC
lol, no, i mean here, with the black background and all that
Keyi Zhang
@Kuree
Nov 08 2014 05:00 UTC
``` C#
then end with ```
so there is the clone code
IPackage result = Package.NewPackage(1);
            CatalogResource.TS4.ObjectCatalogResource obj = (CatalogResource.TS4.ObjectCatalogResource)game.Find(targetTGI).Data;
            TGIBlock[] oldTGIList = obj.NestedTGIBlockList;
            var clone = obj.CloneWrapper(GetTimestamp(DateTime.Now), !isReplace, isStandalone);
            Random r = new Random();
            string hashSalt = GetTimestamp(DateTime.Now) + r.Next().ToString();
            if (oldTGIList != null)
            {
                for (int i = 0; i < oldTGIList.Length; i++)
                {
                    var oldTGI = oldTGIList[i];
                    var newTGI = clone.NestedTGIBlockList[i];
                    if (oldTGI.ResourceType == ResourceTypes.MATD)
                    {
                        RCOLResource.RCOL rcol = new RCOLResource.RCOL(1, game.Find(oldTGI).RawData.Stream);
                        var chunk = rcol.rcolChunkList.First(c => c.RCOLTag == "MATD") as RCOLResource.MATD;
                        var imageData = chunk.MTRL.sdList.Find(s => s.field == RCOLResource.FieldType.DiffuseMap);
                        var imageTGI = imageData.Data as TGIBlock;
                        var imageStream = game.Find(imageTGI).RawData.Stream;
                        imageTGI.Instance = FNV64.GetHash("texture" + imageTGI.Instance.ToString() + hashSalt);
                        result.AddResource(imageTGI, imageStream, true);
                        var headerInstance = rcol.rcolHeader.internalTGIList.Find(f => f.Instance == oldTGI.Instance);
                        headerInstance.Instance = newTGI.Instance;
                        result.AddResource(newTGI, rcol.Stream, true);
                    }
                    else
                    {
                        result.AddResource(clone.NestedTGIBlockList[i], game.Find(oldTGI).RawData.Stream, true);
                    }
                }
            }
I haven't finished yet
currently it can only handle wall and floor
Snaitf
@Snaitf
Nov 08 2014 05:02 UTC
nice
test
C#test
C# test
c# test
grr
```c#
ugh
test
there we go
Keyi Zhang
@Kuree
Nov 08 2014 05:03 UTC
yep
you can define different language
def foo():
    pass
that's python
Snaitf
@Snaitf
Nov 08 2014 05:04 UTC
Are these the only Catalog Resources you're referring to? Because there are more than just these:
 public CatalogResourceHandler()
        {
            if (s4pi.Settings.Settings.IsTS4)
            {
                this.Add(typeof(WallCatalogResource), new List<string>(new string[] { "0xD5F0F921", }));
                this.Add(typeof(FloorCatalogResource), new List<string>(new string[] { "0xB4F762C9", }));
                this.Add(typeof(TerrainPaintCatalogResource), new List<string>(new string[] { "0xEBCBB16C", }));
                this.Add(typeof(ObjectInstanceResource), new List<string>(new string[] { "0x319E4F1D", }));
                this.Add(typeof(RailingResource), new List<string>() { "0x1C1CF1F7", });
                this.Add(typeof(StairCatalogResource), new List<string>(new string[] { "0x9A20CD1C", }));
                this.Add(typeof(FountainTrimsResource), new List<string>(new string[] { "0xE7ADA79D", }));
                this.Add(typeof(RoofTrimResource), new List<string>(new string[] { "0xB0311D0F", }));
            }
        }
Keyi Zhang
@Kuree
Nov 08 2014 05:05 UTC
I haven't finished implementing all of them yet
Snaitf
@Snaitf
Nov 08 2014 05:05 UTC
ah, ok then
Keyi Zhang
@Kuree
Nov 08 2014 05:05 UTC
since Inge doesn't allow me to touch her code
that's the main reason she banned me
Snaitf
@Snaitf
Nov 08 2014 05:05 UTC
lol, did you see her latest post at mts?
Keyi Zhang
@Kuree
Nov 08 2014 05:05 UTC
:P
yes
I fixed matd like one month ago
Snaitf
@Snaitf
Nov 08 2014 05:05 UTC
figured you had
Keyi Zhang
@Kuree
Nov 08 2014 05:06 UTC
just too busy to release a public build
Snaitf
@Snaitf
Nov 08 2014 05:06 UTC
well, if it's not in the official release, most people won't know how to get to it
right
Keyi Zhang
@Kuree
Nov 08 2014 05:06 UTC
school stuff pushes me back
Snaitf
@Snaitf
Nov 08 2014 05:06 UTC
i can understand that, for sure
Keyi Zhang
@Kuree
Nov 08 2014 05:07 UTC
I just finished two exams so that's why I have free time to code
Snaitf
@Snaitf
Nov 08 2014 05:08 UTC
ah, nice, always a huge weight off after finishing big exams
Keyi Zhang
@Kuree
Nov 08 2014 05:09 UTC
yep
catalog resource are not my main focus now
if people really want to modify some new stuff, they can use Inge's
mine is designed for cloning
I might look into audio file tomorrow
it looks promising
Snaitf
@Snaitf
Nov 08 2014 05:13 UTC
ah, cool, if you're gonna start on new stuff tho, u should prolly go ahead a do a release now, if you start in on something else, it might tie you up longer than you think, and people are wanting to be able to edit the casp files
Keyi Zhang
@Kuree
Nov 08 2014 05:14 UTC
hmm
you're right
I'll draft a new release now
Snaitf
@Snaitf
Nov 08 2014 05:17 UTC
yea, good idea, cause right now the only way to make a new cas item is with s4s, and it can't do flags, or combine 2 cc items into a single thumbnail
Keyi Zhang
@Kuree
Nov 08 2014 05:33 UTC
now time to take a show and sleep lol
Snaitf
@Snaitf
Nov 08 2014 05:34 UTC
sleep? what's that? lol, thanks for the update!
Keyi Zhang
@Kuree
Nov 08 2014 14:03 UTC
oops, typo
shower
Keyi Zhang
@Kuree
Nov 08 2014 14:13 UTC
too tired last night
Snaitf
@Snaitf
Nov 08 2014 14:37 UTC

here's a more comprehensive list of age/genders than is used in your enum:

Baby = 01,
Toddler = 02,
Child = 04,
Teen = 08,
YA = 10,
Adult = 20,
AdultYA = 30,
Elder = 40,
AdultElder = 60,
YAandUp = 70,
TeenAndUp = 78,
AllAges = 7F

Keyi Zhang
@Kuree
Nov 08 2014 14:38 UTC
cool ty
Snaitf
@Snaitf
Nov 08 2014 14:38 UTC
sure thing
Keyi Zhang
@Kuree
Nov 08 2014 14:39 UTC
wait, elder is 0x40?
andrew gave me that list
and male is 0x1000
Keyi Zhang
@Kuree
Nov 08 2014 14:40 UTC
it's flags
7F is incorrect for flags
Snaitf
@Snaitf
Nov 08 2014 14:40 UTC
i think these are the hex values
Keyi Zhang
@Kuree
Nov 08 2014 14:40 UTC
yes
so I will update the unknown1 and unknown 2
it's baby and toddler
Snaitf
@Snaitf
Nov 08 2014 14:41 UTC
right, right
Snaitf
@Snaitf
Nov 08 2014 15:06 UTC
How do I update my fork with the new stuff that you've done? Or, would it be easier to delete my fork and just create a new one?
Keyi Zhang
@Kuree
Nov 08 2014 15:06 UTC
pull
do you have git installed?
Snaitf
@Snaitf
Nov 08 2014 15:06 UTC
no, i'm using the website, is the software easier?
Keyi Zhang
@Kuree
Nov 08 2014 15:06 UTC
hmm not sure how website works
normally I do it via command line
if you're using visual studio or github's software it's much more easier
Snaitf
@Snaitf
Nov 08 2014 15:07 UTC
i do have VS
Keyi Zhang
@Kuree
Nov 08 2014 15:07 UTC
the newest VS has builtin git control
Snaitf
@Snaitf
Nov 08 2014 15:08 UTC
hmm, where do i find that?
Keyi Zhang
@Kuree
Nov 08 2014 15:08 UTC
just go to team explorer
it's near the file explorer
Snaitf
@Snaitf
Nov 08 2014 15:08 UTC
kk, i'll try that out
Keyi Zhang
@Kuree
Nov 08 2014 15:14 UTC
now trying to fix the clone code problem
grr
@Snaitf do you know the 433562560 field in MATD?
it has a tgi reference to a texture file
Snaitf
@Snaitf
Nov 08 2014 15:18 UTC
Ok, so I installed the git shell software, now how do I update my fork with all the new stuff that you've added?
Keyi Zhang
@Kuree
Nov 08 2014 15:18 UTC
cd to the folder
then type "git pull"
Snaitf
@Snaitf
Nov 08 2014 15:18 UTC
ah, ok, easy enough
Keyi Zhang
@Kuree
Nov 08 2014 15:18 UTC
do you have a local clone?
you must operate this command in a local clone
not the one you download as zip
it won't work
here is the full instructions of how to do it
and here is the instructions about how to set up git
Snaitf
@Snaitf
Nov 08 2014 15:27 UTC
Ok, I think I got it now, thank you
Keyi Zhang
@Kuree
Nov 08 2014 15:27 UTC
np
Snaitf
@Snaitf
Nov 08 2014 15:34 UTC
heh, that was a lot of work for 7 chars, but now I know how to do it
Keyi Zhang
@Kuree
Nov 08 2014 15:35 UTC
I might release a new version soon
that one should be the 0.2 version
as it has so many updates
(as well as bugs :P)
Snaitf
@Snaitf
Nov 08 2014 15:37 UTC
not a bad idea
Snaitf
@Snaitf
Nov 08 2014 15:48 UTC
Hmmm, also with the CASP files, when you try to add a flag to the CASFlagList, it errors
Keyi Zhang
@Kuree
Nov 08 2014 15:48 UTC
peter's list stuff is weird
I'll try to fix it
pretty sure it's caused by default constructor
Snaitf
@Snaitf
Nov 08 2014 15:49 UTC
ok, yea, I wouldn't know how to do that
Keyi Zhang
@Kuree
Nov 08 2014 15:52 UTC
oops I thought my clone code has bug
but it turns out that I use the wrong resource type
:|
Snaitf
@Snaitf
Nov 08 2014 15:53 UTC
that'd do it
Snaitf
@Snaitf
Nov 08 2014 16:18 UTC
tiny little thing, in the CASP files, the preview shows the swatch color as "ff000000", shouldn't it display "0xFF000000", just for conformity?
This message was deleted
Keyi Zhang
@Kuree
Nov 08 2014 16:29 UTC
It is handled natively by .net
It is not a uint
It is a color. You can edit it in the grid with argb
Snaitf
@Snaitf
Nov 08 2014 16:30 UTC
oh, i know, it's a string, i just thought it would look better, that's all, i've already made the changes, just wanted to know what you thought
simply added "0x" + ... .ToUpper()
Keyi Zhang
@Kuree
Nov 08 2014 16:32 UTC
I think what I did is using the color string
Sorry im using my phone
Can't check the code
Color.Name something like that
If
Snaitf
@Snaitf
Nov 08 2014 16:33 UTC
right, I was just asking if you thought it would look better like that, if so, i'll fork/pull, otherwise i won't
Keyi Zhang
@Kuree
Nov 08 2014 16:33 UTC
Maybe I didn't
Keyi Zhang
@Kuree
Nov 08 2014 16:39 UTC
It should display black if it is black color
That was my intention
Snaitf
@Snaitf
Nov 08 2014 16:41 UTC
in the grid, yes, in the preview pane, it shows the hex, but doesn't have the "0x", nor is it in caps
Keyi Zhang
@Kuree
Nov 08 2014 16:42 UTC
grr
Snaitf
@Snaitf
Nov 08 2014 16:43 UTC
I like that it shows the color in grid (where it can be edited), and that it shows the hex in the preview pane (where everything else is shown in hex value)
just thought it should have the 0x and be in caps is all
Keyi Zhang
@Kuree
Nov 08 2014 16:44 UTC
okay
Snaitf
@Snaitf
Nov 08 2014 16:45 UTC
ok, pull request sent
Keyi Zhang
@Kuree
Nov 08 2014 16:46 UTC
it's recommended not to use toupper()
public string Value { get { { return "0x" + this.color.ToArgb().ToString("X8"); } } }
that's what I did
Snaitf
@Snaitf
Nov 08 2014 16:47 UTC
ah, right, duh, of course
Keyi Zhang
@Kuree
Nov 08 2014 16:49 UTC
I will delete your pull request
can you send me a new one?
you can discarded your old one
*commit
Snaitf
@Snaitf
Nov 08 2014 16:50 UTC
kk, working on it
Snaitf
@Snaitf
Nov 08 2014 17:00 UTC
ok
Keyi Zhang
@Kuree
Nov 08 2014 17:01 UTC
mergeed
I will work on a helper to convert the audio to wav and wav to audio
and a wrapper
Snaitf
@Snaitf
Nov 08 2014 17:04 UTC
nice
Keyi Zhang
@Kuree
Nov 08 2014 17:07 UTC
need to do some work and have lunch
ttyl
Snaitf
@Snaitf
Nov 08 2014 17:07 UTC
lunch, sounds like a good idea, ok, cya l8r