Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Snaitf
    @Snaitf
    ah, ok, cool beans
    Keyi Zhang
    @Kuree
    well I can make it reads commits, but it looks unnecessary
    Snaitf
    @Snaitf
    Just made another pull request for Tool, Product Style, and Fence wrappers.
    You'll need to update the clone code on these.
    Also, there is a problem with the Fence wrapper. It parses and unparses fine, both in the preview and when using the grid, however, when trying to add a new resource of this type, there is an object not set to an instance error, and I can't seem to figure out what is wrong, maybe you could have a look?
    Keyi Zhang
    @Kuree
    I'll look at it
    Snaitf
    @Snaitf
    Thanks
    Keyi Zhang
    @Kuree
    and there're several redundant codes
    I will clean them up
    Snaitf
    @Snaitf
    ok then
    Keyi Zhang
    @Kuree
    I can't find your fence code
    oops
    forgot to pull
    now it has tons of conflicts now
    Snaitf
    @Snaitf
    conflicts?
    Keyi Zhang
    @Kuree
    merge conflicts
    I resolved now
    Snaitf
    @Snaitf
    oh, ok
    Keyi Zhang
    @Kuree
    *them
    Keyi Zhang
    @Kuree
    when initialize a new dependlist
    you can't pass stream to it
    Snaitf
    @Snaitf
    hmm, which line#?
    Keyi Zhang
    @Kuree
    like in the tool
    ln 63
    Snaitf
    @Snaitf
    but the tool wrapper works fine
    Keyi Zhang
    @Kuree
    even if create a new resource from scratch?
    Snaitf
    @Snaitf
    i'll check again
    Keyi Zhang
    @Kuree
    it will try to read the stream
    which doesn't have list information
    it will break the wrapper
    Snaitf
    @Snaitf
    nah, it works
    Keyi Zhang
    @Kuree
    :O
    but the list does exit?
    Snaitf
    @Snaitf
    I created the UnknownList by copying your code from MatdEntryList
    Keyi Zhang
    @Kuree
    but when you initialize the empty
    you shouldn't pass the stream
    it should be
    if (this.unknownList1 == null) this.unknownList1 = new UnknownList(OnResourceChanged);
    rather than
    if (this.unknownList1 == null) this.unknownList1 = new UnknownList(OnResourceChanged, s);
    Snaitf
    @Snaitf
    oic, the reason it works in tool, is probably because the ref flag is set to false by default, so it doesn't get called when makeing a new one
    Keyi Zhang
    @Kuree
    that's what I thought
    Snaitf
    @Snaitf
    but then, when I go into grid and change the ref flag to true, it does create an empty unknown list, with no errors
    Keyi Zhang
    @Kuree
    it should throw some errors in my understanding
    Snaitf
    @Snaitf
    here is a completely new tool - http://i.imgur.com/GR4fbcM.png - and here is that same tool with listflag set to true in the grid - http://i.imgur.com/djardIZ.png
    Keyi Zhang
    @Kuree
    that's really weird
    but anyway I changed it back to the constructor without stream
    just in case it will break the unparse function
    Snaitf
    @Snaitf
    kk
    Keyi Zhang
    @Kuree
    and I also clean up some redundant code
    Snaitf
    @Snaitf
    in fact, that is how you did it in the spandrel wrapper, too
    if (this.modlEntryList1 == null) this.modlEntryList1 = new ModlEntryList(OnResourceChanged, s);
    • this.modlEntryList1.UnParse(s);
    which is why i did it that way, too
    Keyi Zhang
    @Kuree
    uhh oops