Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Vladimir Zhbanov
    @vzh
    @graahnul-grom, nice defect density for lepton-conf :-)
    dmn
    @graahnul-grom
    @vzh Thank you. Interestingly, llvm's scan-build failed to detect those three memory leaks.
    dmn
    @graahnul-grom
    @vzh I'll try to add github actions to lepton. Need to install ubuntu and check if the present packages installation command is still correct in the new os version.
    Vladimir Zhbanov
    @vzh
    @graahnul-grom Don't hesitate to ask here if something is going wrong. Many people use Debian/Ubuntu, e.g. \me and @bdale. I am always glad to help on this topic, you know :-)
    dmn
    @graahnul-grom
    E: Unable to locate package texlive-generic-recommended
    Vladimir Zhbanov
    @vzh
    The package is available on Debian. Either the Ubuntu version you use is old enough, or there are some troubles with connection to the server you download packages from (or the server itself).
    dmn
    @graahnul-grom
    Yes, but gh actions runs on Ubuntu 20.04 ("focal"). We need to adopt apt-get install
    command for that system.
    dmn
    @graahnul-grom
    Found it: on Ubuntu, apt-get install texlive-plain-generic.
    Now make distcheck runs fine.
    dmn
    @graahnul-grom

    I'm porting Lepton EDA to OpenBSD, and in the process have
    discovered a bug in our test suite: when make check is run
    under root account, two liblepton tests fail: "config-load-grp"
    in geda-config.scm and lepton-config.scm.

    ( chmod *testdirAconf* #o000 )
( test-assert-thrown 'system-error (config-load! a #:force-load #t) )

    It turned out that root user can read file with 000 permissions,
    so the test-assert-thrown fails here.
    We can check uid and skip the test if getuid() == 0, or simply
    remove it.
    What do you think, friends?
    I have tested it on OpenBSD, FreeBSD and Ubuntu.

    Vladimir Zhbanov
    @vzh
    You can use test-skip in the code and check getuid right in the test.
    dmn
    @graahnul-grom
    diff --git a/liblepton/scheme/unit-tests/geda-config.scm b/liblepton/scheme/unit-tests/geda-config.scm
index 65079d4eb..67be782c1 100644
--- a/liblepton/scheme/unit-tests/geda-config.scm
+++ b/liblepton/scheme/unit-tests/geda-config.scm
@@ -92,8 +92,9 @@
     (test-equal #f (geda:config-loaded? a))
     (test-equal a (geda:config-load! a))
     (test-assert (geda:config-loaded? a))
-    (chmod *testdir-geda-Aconf* #o000) ;; Make conf unreadable
-    (test-assert-thrown 'system-error (geda:config-load! a #:force-load #t)))
+    (unless (eq? (getuid) 0)
+      (chmod *testdir-geda-Aconf* #o000) ;; Make conf unreadable; root can read it anyway
+      (test-assert-thrown 'system-error (geda:config-load! a #:force-load #t))))

   (test-assert-thrown 'system-error (geda:config-load! (geda:default-config-context) #:force-load #t))
   ;; Clean up.
diff --git a/liblepton/scheme/unit-tests/lepton-config.scm b/liblepton/scheme/unit-tests/lepton-config.scm
index eb4f996f1..9c337d4e0 100644
--- a/liblepton/scheme/unit-tests/lepton-config.scm
+++ b/liblepton/scheme/unit-tests/lepton-config.scm
@@ -92,8 +92,9 @@
     (test-equal #f (config-loaded? a))
     (test-equal a (config-load! a))
     (test-assert (config-loaded? a))
-    (chmod *testdirAconf* #o000) ;; Make conf unreadable
-    (test-assert-thrown 'system-error (config-load! a #:force-load #t)))
+    (unless (eq? (getuid) 0)
+      (chmod *testdirAconf* #o000) ;; Make conf unreadable; root can read it anyway
+      (test-assert-thrown 'system-error (config-load! a #:force-load #t))))

   (test-assert-thrown 'system-error (config-load! (default-config-context) #:force-load #t))
   ;; Clean up.
    Vladimir Zhbanov
    @vzh
    I don't mind, though test-skip() in srfi-64 should aid just in such cases. IIUC, it also reports what was skipped. Please follow the link to see more info on the function.
    dmn
    @graahnul-grom
    You think it's better to skip the entire config-load!() test?
    It has only one problematic expression, though.
    Vladimir Zhbanov
    @vzh
    There is an example in the srfi I pointed you to: (if some-condition (test-skip 2)) ;; skip next 2 tests. So you could just skip one test and the info on this would go to the test results.
    dmn
    @graahnul-grom

    Ah, sorry, I thought that test-skip() skips a group of tests.

    #810

    dmn
    @graahnul-grom
    Did you notice that Travis CI doesn't work anymore? :-)
    Vladimir Zhbanov
    @vzh
    Yes. Just after you added gh action, they worked a few days in parallel. Now, after about a week, it stopped. I noticed this three days ago.
    dmn
    @graahnul-grom
    Does it mean we can't push to the coverity scan branch any more, too?
    Vladimir Zhbanov
    @vzh
    @graahnul-grom, sorry for delay, I got sick a little (covid?) a few days ago. I think coverity is not tied to travis. I'll push the branch today to check if it works.
    done
    Let's wait a bit.
    Vladimir Zhbanov
    @vzh
    Ah, got it. They use the same .travis.yml for triggering the job. Sorry for my ignorance :-)
    Then there should be a way to trigger it otherwise.
    dmn
    @graahnul-grom
    I have no idea how do we trigger the analysis... At least we can run their tools locally and upload results to scan.coverity.com (as I did for lepton-conf).
    Vladimir Zhbanov
    @vzh
    Well, I don't know how to do it either. Let's wait when a solution emerges somewhere in the net.
    dmn
    @graahnul-grom
    I've found a yml file that fetches and runs coverity tools:
    https://github.com/ruby/actions-coverity-scan/blob/master/.github/workflows/coverity-scan.yml
    156Mb archive, 2,8Gb extracted :-)
    Vladimir Zhbanov
    @vzh
    Hi friends. Please blame me if you want. I so desired to release a new Lepton version that forgot to change the version of cygwin libs for it. Please let's do it in the next release. We have to automate it somehow anyway.
    The announce on the geda-user list will follow. Please help me with it if you can (especially, native English speakers). I never liked to make up such texts :-]
    Vladimir Zhbanov
    @vzh
    Just announced it. Any comments are appreciated.
    Bdale Garbee
    @bdale
    1.9.15-1 uploaded to Debian
    Vladimir Zhbanov
    @vzh
    Bdale, thank you!
    dmn
    @graahnul-grom
    Why do I get the following warning while (successfully)
    running lepton-netlist 1.9.15 on Linux and OpenBSD (but
    not on FreeBSD)? $GUILE_AUTO_COMPILE env. var. is set to 1.
    WARNING: compilation of /usr/local/bin/lepton-netlist failed:
no code for module (lepton ffi)
    Vladimir Zhbanov
    @vzh
    Does the netlister work at all? I see the warning for other tools such as lepton-archive.
    dmn
    @graahnul-grom
    It works as intended, the output is correct, but gives the above warning.
    dmn
    @graahnul-grom
    Yes, lepton-archive gives the same warning.
    The same on FreeBSD, just forgot to remove the ccache dir.
    Vladimir Zhbanov
    @vzh
    I tried to remove guile cache, as well as doing sudo ldconfig. Nothing helped. Don't know yet what's wrong.
    dmn
    @graahnul-grom
    I have updated all of the Lepton EDA ports in my repositories:
    Vladimir Zhbanov
    @vzh
    @graahnul-grom thank you!
    Vladimir Zhbanov
    @vzh
    #818 solves the above warnings on my machine.
    Vladimir Zhbanov
    @vzh
    @graahnul-grom, could you please announce your new ports on the geda mailing lists?
    Message on travis.org in red: Travis CI - Test and Deploy Your Code with Confidence is in read-only mode. The historical data can be downloaded to external file storage.
    and in yellow: Since June 15th, 2021, the building on travis-ci.org is ceased. Please use travis-ci.com from now on.
    dmn
    @graahnul-grom
    Thankfully, we do not depend on Travis CI anymore.
    Vladimir Zhbanov
    @vzh
    The only issue is coverity depends on travis as we discussed recently. I tried to upload a Lepton build directly to it, though without any success.
    dmn
    @graahnul-grom
    I remember there was a problem building lepton-conf with the coverity tools:
    I had to set CPPFLAGS=-DGLIB_DISABLE_DEPRECATION_WARNINGS=1 to make it work.
    Vladimir Zhbanov
    @vzh
    I just don't know how to trigger the coverity build without travis. I tried to upload our last version tarball to it without success.
    dmn
    @graahnul-grom
    1. Download the tools for your system from https://scan.coverity.com/download
    2. Extract them somewhere
    3. Change to the Lepton source directory
    4. Clean the source tree: git clean -x -d -f
    5. ./autogen.sh
    6. export CPPFLAGS="-DGLIB_DISABLE_DEPRECATION_WARNINGS=1"
    7. ./configure
    8. export PATH="/path/to/extracted/coverity/tools/bin:$PATH"
    9. cov-build --dir cov-int make
    10. tar czf lepton-eda.tgz cov-int
    11. Go to https://scan.coverity.com/projects/lepton-eda-lepton-eda?tab=overview
    12. Click on the "Submit Build" button on the right side of the page
    13. Click on the "Upload Tar File" button and select the lepton-eda.tgz archive you've just created
    14. Click on the "Upload file for analysis" button
    dmn
    @graahnul-grom
    Lepton EDA 1.9.15 has been committed to the FreeBSD ports git repository.
    So the packages will be available in the next quarterly branch. :-)