Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Alois
    @aloisdg
    I guess you are using the mono code style, arent you?
    Andrés Correa Casablanca
    @castarco
    Yes, I'm trying to use the Mono style, but the style isn't a problem right now, I'm no t strictly enforcing it, nor documented anything about the code style
    Alois
    @aloisdg
    Ok nice
    I will try to follow the style of the lib
    Alois
    @aloisdg
    Alois
    @aloisdg
    By the way when I finish with hsv, I will add hsl
    Alois
    @aloisdg

    I have got this exception when I try to run the test :

    System.IO.FileLoadException : Could not load file or assembly 'ColorSharp, Version=0.10.0.28137, Culture=neutral, PublicKeyToken=bf59dc38b2709e38' or one of its dependencies. Strong name signature could not be verified.  The assembly may have been tampered with, or it was delay signed but not fully signed with the correct private key. (Exception from HRESULT: 0x80131045)

    I try this solution without result. Any idea ?

    Andrés Correa Casablanca
    @castarco
    Ouch, this is my fault
    Are you trying to use your modified library into another project, right?
    Alois
    @aloisdg
    I will
    but now I just try to run a basic test in NUnit
    Andrés Correa Casablanca
    @castarco
    Currently the project have delayed signature, becaue I own the private key
    mmm, this should be fixed u.u
    Alois
    @aloisdg
    ok I will try again
    Andrés Correa Casablanca
    @castarco
    are you using the test project? and fails? or are you testing it with other project?
    Alois
    @aloisdg
    I am testing with the test project
    Andrés Correa Casablanca
    @castarco
    damn, I'm sorry, I'll check it now
    Alois
    @aloisdg
    you check it now or you will check it ;)
    Andrés Correa Casablanca
    @castarco
    in a few minutes ^^U
    I abuse the word "now" ^^
    Alois
    @aloisdg
    like a lot of dev. I have got the same problem x)
    Andrés Correa Casablanca
    @castarco
    I though it's possible to test the library without signing it :s , how it's correctly done then? (the standard way)
    Alois
    @aloisdg
    I dunno
    first time I saw this
    Andrés Correa Casablanca
    @castarco
    I sign the library in order to allow using it in signed projects, but I'm seeing it's very problematic
    Alois
    @aloisdg
    ok I will check it tomorrow.
    Andrés Correa Casablanca
    @castarco
    Mm, a simple workaround is to edit the project and remove also the delayed signature.
    then you'll be able to run the tests, meanwhile I should check what's happening
    Andrés Correa Casablanca
    @castarco
    Hi @aloisdg , I've been reviewing your work :) . There are only two minor problems
    one is the space/tabs characters inside documentation comments, github shows "formatting" problems
    the other "problem" is that in AConvertibleColor you use CIEXYZ as a "converter hub" , but in this case it's better to directly use SRGB
    (I saw in CIEXYZ you call the conversion to SRGB, but I think it's preferable use the inverse order: to call the SRGB conversion and then, if not exist a direct conversion, call the CIEXYZ conversion
    I think changing the approach is better because then we can take advantadge of other direct conversors to SRGB when they exist
    Alois
    @aloisdg
    Ok great
    Alois
    @aloisdg
    For the formatting problem, I will edit the settings of visual studio. For the the second problem, I am not sure how you want to write that. By the way, you can open issues on github for this kind of remarks ;)
    Alois
    @aloisdg
    @castarco Should we follow the mono project guidlines? I think you are using 4 tabs space, arent you?
    This message was deleted
    Alois
    @aloisdg
    Or we could follow MonoGame's guidlines. They follow the one from Microsoft for .NET.
    Andrés Correa Casablanca
    @castarco
    Sorry for my late response
    As far as I can see, I think I'm using tabulators ^^U , I'm using the Monodevelop's default spacing schema
    but I don't know if the IDE is "cheating" me and under the hood is using spaces. I've opened a couple of files with gedit and I'm seeing tabs too.
    Alois
    @aloisdg
    No problem. Are you involve in the open source .net foundations or the mono project ? It could be useful to be part or one or both. Can you select a official coding style ?
    Andrés Correa Casablanca
    @castarco
    Hi, sorry for my late response. I didn't see your message. I'm not involved in any OSS foundation, it would be interesting, but I think my projects aren't interesting enough to be funded or supported by any foundation ^^U
    About the code style, I'm not sure, we have the MS style, and the Mono style? right? are there more options?
    Félix Dion Robidoux
    @fdrobidoux
    Is this library usable on a .Net Core project?
    Andrés Correa Casablanca
    @castarco
    Hi @fdrobidoux , it should, but I didn't maintain it since a long time ago
    so I don't remember all the details
    Do you need to use that library? I could help you to apply some needed improvements
    Mmm... in fact, this library was created before the .Net Core was open sourced, and a lot of things have changed on the CI landscape since then
    I should refactor all the CI environment to allow automated builds