Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 22:01

    pmoura on master

    Fix RTD build (compare)

  • 21:56

    pmoura on master

    Fix RTD build (compare)

  • 20:21

    pmoura on master

    Fix LVM version requirements in… (compare)

  • 16:41

    pmoura on lgt3510stable

    (compare)

  • 13:59

    pmoura on master

    Change version to 3.51.0 stable… (compare)

  • 13:19

    pmoura on master

    Avoid some `packs` tool errors … (compare)

  • Oct 25 21:31

    pmoura on master

    Fixes and improvements for the … (compare)

  • Oct 25 19:29

    pmoura on master

    Clean up driver files for the a… (compare)

  • Oct 25 18:36

    pmoura on master

    Additional tests for the `atom_… (compare)

  • Oct 25 18:34

    pmoura on master

    Additional test for the `atom_c… (compare)

  • Oct 25 18:31

    pmoura on master

    Use portable definition of atom… (compare)

  • Oct 25 18:10

    pmoura on master

    Add tests for the `atomic_conca… (compare)

  • Oct 25 17:48

    pmoura on master

    Update `pddl` contribution plus… Update SVG diagrams (compare)

  • Oct 25 16:04

    pmoura on master

    Update the `packs` tool to use … (compare)

  • Oct 25 15:15

    pmoura on master

    Add definitions for the `atomic… (compare)

  • Oct 25 15:14

    pmoura on atomic_list_concat

    Add definitions for the `atomic… (compare)

  • Oct 25 15:13

    pmoura on atomic_list_concat

    Add `atomic_list_concat/2-3` pr… Update adapter files for the `a… Add definition for the `atomic_… and 4 more (compare)

  • Oct 25 15:06

    pmoura on atomic_list_concat

    Add definitions for the `atomic… (compare)

  • Oct 25 14:43

    pmoura on atomic_list_concat

    Add the atomic concat predicate… (compare)

  • Oct 25 14:00

    pmoura on atomic_list_concat

    Add definition for the `atomic_… (compare)

A Man With A Clever Disguise
@ACleverDisguise
:- initialization((
    set_logtalk_flag(report, warnings),
    logtalk_load(loader),
    logtalk_load(lgtunit(loader)),
    logtalk_load(two3tree, [source_data(on), debug(on)]),
    logtalk_load(tests, [hook(lgtunit)]),
    tests::run
)).
Paulo Moura
@pmoura
And the debug message printing calls are in the two2three file?
A Man With A Clever Disguise
@ACleverDisguise
tests file right now.
I'm trying to nail down a problem in the validation predicates in the tests.
Paulo Moura
@pmoura
Can you paste one of the clauses that contain the print message call?
A Man With A Clever Disguise
@ACleverDisguise

First the uses clause that gives me the message in a convenient format. Currently set to information but if I change it to debug it never prints anything.

    :- uses(logtalk, [print_message(information, two3tree_tests, Message) as dbg(Message)]).

Now a typical clause:

    depth(Din, node(L, _, R), Dout) :-
        depth(L, DL),
        depth(R, DR),
        DL == DR, % if the depths don't match, this is a big problem!
        Dout is  Din + DL,
        dbg(depth-(Dout-node2_descend)).
Paulo Moura
@pmoura
That clause is not calling dbg/1. You meant to paste a different one?
A Man With A Clever Disguise
@ACleverDisguise
So that uses clause works. Messages print. But without changing anything else in the code, and after manually turning the debug flag on and confirming it's on, changing it to debug makes it stop working.
Oh, right. Sorry.
Fixed.
I took a test, not a helper. :)
Paulo Moura
@pmoura
Is the dbg/1 call ever reached?
A Man With A Clever Disguise
@ACleverDisguise
If I switch it to information it displays, so yes.
Paulo Moura
@pmoura
I assume so?
A Man With A Clever Disguise
@ACleverDisguise
% depth: 1-node2_leaf
% depth: 1-node(leaf,10-value10,leaf)
% two3tree_insert_1: success (in 0.0004346110000001957 seconds)
% depth: 1-node3_leaf
% depth: 1-node(leaf,10-value10,leaf,20-value20,leaf)
% two3tree_insert_2: success (in 0.00041456800000005956 seconds)
Test output for a successful test.
Paulo Moura
@pmoura
And if you modify that clause to print the value of the debug flag?
A Man With A Clever Disguise
@ACleverDisguise

OK, so I'll give you two results. Here's the run with dbg/1 using information:

% depth: 1-node2_leaf
% on
% depth: 1-node(leaf,10-value10,leaf)
% two3tree_insert_1: success (in 0.00029869099999979554 seconds)
% depth: 1-node3_leaf
% depth: 1-node(leaf,10-value10,leaf,20-value20,leaf)
% two3tree_insert_2: success (in 0.0002536849999996704 seconds)

And here's the run with dbg/1 using debug on the same test results:

% on
% two3tree_insert_1: success (in 0.00033641100000014745 seconds)
% two3tree_insert_2: success (in 0.00021322999999995318 seconds)
The dbg/1 messages vanish if configured for debug but are visible if configured for information. In both cases the current_logtalk_flag (displayed using print_message/3 using information always) is on.
A Man With A Clever Disguise
@ACleverDisguise
Adding this to the tests object doesn't change anything:
    :- set_logtalk_flag(debug, on).
Paulo Moura
@pmoura
I think I have enough details from you to look into it. Possible tomorrow.
A Man With A Clever Disguise
@ACleverDisguise
It's not critical, just to be clear. I'm fine with using information class. I was just wondering if there was something I was missing.
Paulo Moura
@pmoura
Not clear at this time. Nothing obviously wrong. But I have meetings all day and can't look at it today.
A Man With A Clever Disguise
@ACleverDisguise
By the way, I'd just like to thank you for making lgtunit so civilized.
Most testing frameworks set my teeth on edge and make me avoid writing tests until I have to.
Paulo Moura
@pmoura
:-)
A Man With A Clever Disguise
@ACleverDisguise
lgtunit is a positive joy to work with by comparison.
Paulo Moura
@pmoura
Have you already played with lgtunit QuickCheck implementation?
A Man With A Clever Disguise
@ACleverDisguise
Played, yes. Not integrated into workflow.
Paulo Moura
@pmoura
And with generating Allure test reports?
A Man With A Clever Disguise
@ACleverDisguise
Once I get these 2-3 trees working, I will be using quickcheck tests formally.
And I have no idea what an Allure is, so ... no.
A Man With A Clever Disguise
@ACleverDisguise
Still not really helping since I don't know what an Allure is. To me Allure is a stat in an RPG. :D
Paulo Moura
@pmoura
Follow the bread crumps on that tweet for a demo...
A Man With A Clever Disguise
@ACleverDisguise
% 
% tests started at 2021-09-10, 23:37:45
% 
% running tests from object tests
% file: /home/michael/src/Playthings/Prolog/Logtalk/two3tree/tests.lgt
% 
% two3tree_new: success (in 0.0001542940000001103 seconds)
% two3tree_insert_1: success (in 0.00011241300000008891 seconds)
% two3tree_insert_2: success (in 0.0001055439999997354 seconds)
% two3tree_insert_3: success (in 0.0004157660000001506 seconds)
% two3tree_insert_4: success (in 0.0001568519999999296 seconds)
% two3tree_insert_5: success (in 0.00012946400000002356 seconds)
% two3tree_insert_6: success (in 0.00017247299999967325 seconds)
% two3tree_insert_7: success (in 0.00018493100000016582 seconds)
% 
% 8 tests: 0 skipped, 8 passed, 0 failed (0 flaky)
% completed tests from object tests
% 
% no code coverage information collected
% tests ended at 2021-09-10, 23:37:45
%
Just the kind of report I like to see. :D
Paulo Moura
@pmoura
👍
A Man With A Clever Disguise
@ACleverDisguise
I'm going to have to learn to power-use the debugger so that I can phase out dbg/1 messages.
Paulo Moura
@pmoura
You're missing cover(two3tree). clause in the testsobject.
(assuming that two3tree is the name of the object being tested)
A Man With A Clever Disguise
@ACleverDisguise
I had it commented out to declutter the display while there were errors showing.
Paulo Moura
@pmoura
Ah, ok.
A Man With A Clever Disguise
@ACleverDisguise
% 
% tests started at 2021-09-10, 23:42:04
% 
% running tests from object tests
% file: /home/michael/src/Playthings/Prolog/Logtalk/two3tree/tests.lgt
% 
% two3tree_new: success (in 0.0001543320000001458 seconds)
% two3tree_insert_1: success (in 0.00010364400000018037 seconds)
% two3tree_insert_2: success (in 0.00011810099999998158 seconds)
% two3tree_insert_3: success (in 0.0004362789999996508 seconds)
% two3tree_insert_4: success (in 0.00013675199999996224 seconds)
% two3tree_insert_5: success (in 0.00012492799999996862 seconds)
% two3tree_insert_6: success (in 0.00015842699999968346 seconds)
% two3tree_insert_7: success (in 0.0001948069999997415 seconds)
% 
% 8 tests: 0 skipped, 8 passed, 0 failed (0 flaky)
% completed tests from object tests
% 
% 
% clause coverage ratio and covered clauses per entity predicate
% 
% two3tree: empty/1 - 1/1 - (all)
% two3tree: insert/4 - 4/4 - (all)
% two3tree: new/1 - 1/1 - (all)
% two3tree: node4/1 - 0/1 - []
% two3tree: 6 out of 7 clauses covered, 85.714286% coverage
% 
% 1 entity declared as covered containing 7 clauses
% 1 out of 1 entity covered, 100.000000% entity coverage
% 6 out of 7 clauses covered, 85.714286% clause coverage
% 
% tests ended at 2021-09-10, 23:42:04
%
Better?
Paulo Moura
@pmoura
Good coverage. You can also easily generate a report for that. E.g. https://logtalk.org/diagrams/coverage_report.html
A Man With A Clever Disguise
@ACleverDisguise
Well, I'm very deliberately writing the tree code and the tests piecemeal, making sure that my tests are valid for each case before moving up the case ladder.
So the coverage is always going to be one or two clauses uncovered at most.
I wish I had more time to do Logtalk.
This is a whole lot more fun than C. About in the same league as Ada, but for entirely different reasons.