Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 20:46
    IsThisPaul commented #1779
  • 18:33
    ps2 commented #1917
  • 01:13
    jgefaell commented #1897
  • Feb 02 07:17
    Chris-Almond review_requested #1917
  • Feb 02 07:15
    Chris-Almond commented #1917
  • Feb 02 06:00
    Chris-Almond synchronize #1917
  • Feb 02 05:27
    bedtime4bonzos opened #1919
  • Feb 01 06:33
    jgefaell commented #1897
  • Jan 31 21:44
    ps2 commented #1917
  • Jan 31 21:40
    ps2 commented #1917
  • Jan 31 21:02
    senderob opened #1918
  • Jan 31 19:34
    Chris-Almond opened #1917
  • Jan 31 14:12

    ps2 on dev

    Add english localization to Loo… (compare)

  • Jan 31 13:45
    MeeraVenkatesh commented #1916
  • Jan 31 12:30
    paddingtonil opened #1916
  • Jan 29 18:02

    ps2 on dev

    Fix localization for dosing str… (compare)

  • Jan 29 16:55
    ps2 opened #1915
  • Jan 29 05:48

    ps2 on translations

    (compare)

  • Jan 29 05:48

    ps2 on dev

    Updated translations from Lokal… (compare)

  • Jan 29 05:48
    ps2 closed #1914
Robert Silvers
@rsilvers129
@jeremybarnum If you want, give mine a try. It is dm61 IRC and FPU combined. FPU allows fat and protein input. Mine is based on dev 1.9.3. https://github.com/rsilvers129/Loop/tree/FPU-IRC
Dragan Maksimovic
@dm61
@jeremybarnum integral-retrospective-correction branch is up to date, and you can merge it cleanly with the current Loop dev. However, the branch is not compatible with the current Loop master.
1.9.2 in integral-retrospective-correction branch is a bit misleading - this is a result of the fact that dev version the branch was based on was behind a bit for some time, nothing to worry about.
jeremybarnum
@jeremybarnum
ok thanks @rsilvers129 and @dm61. It's killing me how long it takes to run carthage update to integrate the small other changes I need to make - I need to learn how to do the workspace thing. Is it right that this speeds up integrating framework changes (like X15 fix to rileylink_ios, etc?) Is it worth trying to figure it out? I'm feeling a bit incompetent today - keep getting build errors from what I'm sure are dumb mistakes.
jeremybarnum
@jeremybarnum
like, example, I just built 1.9.3 master cleanly, no changes. Then I checked out dev and tried to build and got 84 red build errors. I assume I need to run carthage update which I'm doing now, but should this really be necessary? am I doing something wrong?
Dragan Maksimovic
@dm61
carthage update should fix those errors. I am not able to explain why sometimes we need to do update when switching branches, as if something gets corrupted in carthage cache or wherever
If update does not go through, you may need to purge carthage stuff, Katie has this in the docs
jeremybarnum
@jeremybarnum
OK Thanks Dragan - that makes me feel slightly less stupid. I think part of the problem is that my modified frameworks were derived from master and I forgot that your branch is based on dev. So in theory I just need to merge my mods into the dev versions of the Loopkit and RL. If so, that's a small task. Fingers crossed.
Dragan Maksimovic
@dm61
If you need IRC version compatible with current master, I've left a branch for that purpose, integral-retrospective-correction-v0
jeremybarnum
@jeremybarnum
ok thanks again. I'm starting over anyway, so I might as well go with dev.
Dragan Maksimovic
@dm61
dev is great, plus all new stuff is coming to dev first, so I'd go with dev
jeremybarnum
@jeremybarnum
great. I did just build dev successfully after running carthage update. Would you recommend trying to learn how to use workspaces? Will that speed up integrating loopkit and rileylink_ios changes without having to run carthage update each time?
Dragan Maksimovic
@dm61
I've not tried workspace yet, so I do not know. It should speed things up if you are making updates to both LoopKit and Loop
jeremybarnum
@jeremybarnum
Thanks. If I'm feeling optimistic I'll try and report back.
katie disimone
@Kdisimone
@jeremybarnum if you’re changing Loopkit just remember that new dev for now has cartfiles in several frameworks that point to loopkit
Dragan Maksimovic
@dm61
Great point!
Robert Silvers
@rsilvers129
I am pretty sure that a Workspace is only a benefit if you are making changes to LoopKit or frameworks at the same time and going to be regularly editing them.
Pete Schwamb
@ps2
If you’re working on Loop’s frameworks, the workspace setup really helps.
jeremybarnum
@jeremybarnum
ah right. Thanks @Kdisimone. I need to get one clean build the old fashioned way and then I'll try to teach myself the workspace thing. Right now I seem to have corrupted carthage. Let me see if I can post a screen shot
Screen Shot 2018-10-27 at 8.00.56 PM.png
I tried Katie's instructions for cleaning out the Carthage cache. But I feel like kind of a dumb recipe follower. Among other things, I can't even find that directory through the finder. Is it hidden or something?
Sorry let me rerun Katie's instructions from the docs and I'll show output
Robert Silvers
@rsilvers129
@ps2 - are there instructions somewhere for the workspace setup? I am not sure I ever did it the best way.

@jeremybarnum
I have never done it from the finder. From the command line (be careful with rm -rf):

rm -rf ~/Library/Caches/org.carthage.CarthageKit
rm -rf ~/Library/Developer/Xcode/DerivedData
rm -rf ./Carthage/Build/
rm -rf ./Carthage/Checkouts/

katie disimone
@Kdisimone
@jeremybarnum I’d be willing to be this is about having multiple cartfiles pulling in different versions of Loopkit. You need to get those all pointing to the same loopkit
jeremybarnum
@jeremybarnum
ok here is the screen shot from the carthage cleanup from the docs. @rsilvers129 last two instructions I haven't done. I'll do those next and then try @Kdisimone 's suggestion after I have dinner (I am being summoned!). Thanks all.
Screen Shot 2018-10-27 at 8.05.27 PM.png
katie disimone
@Kdisimone
Yup. You’ve got a lot of fetches for Loopkit there 😉
See how the first Loopkit resolved to the most recent commit on Loopkit’s dev branch. The next Loopkit is resolving to a different commit. So some other framework thAt your Loop is calling to has a cartfile embedded that is going to a different Loopkit. You need to track those down and make sure they all land at the same commit
Robert Silvers
@rsilvers129

@ps2 I am having trouble following that. When you say: “3. You can now go into the Carthage/Checkouts/* directories and check out branches you're wanting to work on.” You mean git checkout I assume, but would you not already be working in a checked-out branch just by the fact that carthage created the Carthage/Checkouts files?

Also “5. Add the Loop project and the .xcodeproj files for the other projects within the Carthage/Checkouts directory.” do you mean “5. Add the Xcode project for the other Framework projects from the Carthage/Checkouts directories.”

jeremybarnum
@jeremybarnum
Got it. Sort of. But clearly you are right (does that ever get old for you? :-) because I just got back Carthage update back with same problems after deleting all four files. I'll report back after dinner
@Kdisimone
Pete Schwamb
@ps2
If you want to work on different branches than what Carthage checked out, that’s when you’d do that
katie disimone
@Kdisimone
@jeremybarnum the easiest thing is to look at the Loop’s cartfile’s Loopkit/branch that you’re building with, and then go into github and check each of the framework/branch’s cartfile to see if they are calling for the same Loopkit/branch as your Loop’s cartfile.
Pete Schwamb
@ps2
For step 5 you’d want to add Loop project as well as the other projects to the new workspace.
jeremybarnum
@jeremybarnum
OK @Kdisimone I see. So for example, rileylink_ios dev has a cartfile, which points to loopkit. So to the extent I am building with both my own rileylink_ios (for x15) and my own loopkit (for #577) I need to make sure my rileylink cartfile points to my own loopkit branch. I'll check, but in case it's not obvious, which other frameworks also point to loopkit? Thanks - this would have taken me hours to figure out, if ever.
actually I just checked the other frameworks and the only one with a cartfile in it seems to be rileylink_ios. Is that right? So if I fix that one I should be good? Gonna try
Dragan Maksimovic
@dm61
No, there are more frameworks that point to LoopKit. Check dev versions of the frameworks. CGMBLEKit definitely, maybe another one, let me check
Also dexcom-share-client-swift
and G4ShareSpy
jeremybarnum
@jeremybarnum
ok I must have been checking the wrong branches. Thanks.
Dragan Maksimovic
@dm61
Yeah, you need to look at dev branches of everything. If it makes you feel any better I spent some hours before I figured this out some time ago
To be precise, check the branches pointed to by Loop dev Cartfile
katie disimone
@Kdisimone
Yup. It caught me up a few months ago. Finally saw the rl cartfile and had a couple head bashed on my desk in victory
Robert Silvers
@rsilvers129
This would all be a lot easier if all of the Loop code was one Xcode project. Carthage links all over make it really tricky to work on.
jeremybarnum
@jeremybarnum
@rsilvers129 tell me about it! I thought I had it figured out until I saw that CGMBLEKit cartfile links to both loopkit and dexcom-share-client-swift, and that latter has its own cartfile that links to loopkit. I'm sure there is a reason for this but for newbies like me it's a particular form of sadism. Carthage update does seem to be running succesfully now though. Thanks @Kdisimone
katie disimone
@Kdisimone
👍🏻
Robert Silvers
@rsilvers129
It took me about 12 days to learn, start, debug, and finish writing my branch. Probably a week of that was just carthage problems.
jeremybarnum
@jeremybarnum
argh so close. I had a clean carthage update run, but build is failing. I guess I have to delete some of those files again, but weird to have that after a good carthage update.