Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Dec 01 13:16

    ps2 on dev

    [LOOP-4056] Fixed some layout a… Merge pull request #536 from ti… Merge remote-tracking branch 't… and 1 more (compare)

  • Dec 01 13:16
    ps2 closed #1855
  • Dec 01 13:16
    ps2 opened #1855
  • Dec 01 13:16

    ps2 on tidepool-merge

    Merge pull request #1850 from L… Revert to previous loopNotRunni… [LOOP-4056] Fixed some layout a… and 2 more (compare)

  • Dec 01 02:29
    ps2 closed #1834
  • Nov 30 22:15
    marionbarker commented #1689
  • Nov 30 21:57
    marionbarker synchronize #1689
  • Nov 30 21:48
    loudestnoise closed #1642
  • Nov 30 18:03
    marionbarker opened #1854
  • Nov 30 03:45
    novalegra synchronize #1825
  • Nov 30 03:42
    novalegra synchronize #1825
  • Nov 30 03:31
    novalegra synchronize #1825
  • Nov 30 00:18
    marionbarker opened #1853
  • Nov 29 20:28
    ps2 commented #1834
  • Nov 29 20:28
    ps2 commented #1834
  • Nov 29 18:40
    Camji55 closed #1852
  • Nov 29 18:39
    Camji55 opened #1852
  • Nov 29 14:54
    marionbarker commented #1689
  • Nov 29 14:54
    marionbarker commented #1689
  • Nov 29 14:27

    ps2 on dev

    Revert to previous loopNotRunni… (compare)

jeremybarnum
@jeremybarnum
ok thanks again. I'm starting over anyway, so I might as well go with dev.
Dragan Maksimovic
@dm61
dev is great, plus all new stuff is coming to dev first, so I'd go with dev
jeremybarnum
@jeremybarnum
great. I did just build dev successfully after running carthage update. Would you recommend trying to learn how to use workspaces? Will that speed up integrating loopkit and rileylink_ios changes without having to run carthage update each time?
Dragan Maksimovic
@dm61
I've not tried workspace yet, so I do not know. It should speed things up if you are making updates to both LoopKit and Loop
jeremybarnum
@jeremybarnum
Thanks. If I'm feeling optimistic I'll try and report back.
katie disimone
@Kdisimone
@jeremybarnum if you’re changing Loopkit just remember that new dev for now has cartfiles in several frameworks that point to loopkit
Dragan Maksimovic
@dm61
Great point!
Robert Silvers
@rsilvers129
I am pretty sure that a Workspace is only a benefit if you are making changes to LoopKit or frameworks at the same time and going to be regularly editing them.
Pete Schwamb
@ps2
If you’re working on Loop’s frameworks, the workspace setup really helps.
jeremybarnum
@jeremybarnum
ah right. Thanks @Kdisimone. I need to get one clean build the old fashioned way and then I'll try to teach myself the workspace thing. Right now I seem to have corrupted carthage. Let me see if I can post a screen shot
Screen Shot 2018-10-27 at 8.00.56 PM.png
I tried Katie's instructions for cleaning out the Carthage cache. But I feel like kind of a dumb recipe follower. Among other things, I can't even find that directory through the finder. Is it hidden or something?
Sorry let me rerun Katie's instructions from the docs and I'll show output
Robert Silvers
@rsilvers129
@ps2 - are there instructions somewhere for the workspace setup? I am not sure I ever did it the best way.

@jeremybarnum
I have never done it from the finder. From the command line (be careful with rm -rf):

rm -rf ~/Library/Caches/org.carthage.CarthageKit
rm -rf ~/Library/Developer/Xcode/DerivedData
rm -rf ./Carthage/Build/
rm -rf ./Carthage/Checkouts/

katie disimone
@Kdisimone
@jeremybarnum I’d be willing to be this is about having multiple cartfiles pulling in different versions of Loopkit. You need to get those all pointing to the same loopkit
jeremybarnum
@jeremybarnum
ok here is the screen shot from the carthage cleanup from the docs. @rsilvers129 last two instructions I haven't done. I'll do those next and then try @Kdisimone 's suggestion after I have dinner (I am being summoned!). Thanks all.
Screen Shot 2018-10-27 at 8.05.27 PM.png
katie disimone
@Kdisimone
Yup. You’ve got a lot of fetches for Loopkit there 😉
See how the first Loopkit resolved to the most recent commit on Loopkit’s dev branch. The next Loopkit is resolving to a different commit. So some other framework thAt your Loop is calling to has a cartfile embedded that is going to a different Loopkit. You need to track those down and make sure they all land at the same commit
Robert Silvers
@rsilvers129

@ps2 I am having trouble following that. When you say: “3. You can now go into the Carthage/Checkouts/* directories and check out branches you're wanting to work on.” You mean git checkout I assume, but would you not already be working in a checked-out branch just by the fact that carthage created the Carthage/Checkouts files?

Also “5. Add the Loop project and the .xcodeproj files for the other projects within the Carthage/Checkouts directory.” do you mean “5. Add the Xcode project for the other Framework projects from the Carthage/Checkouts directories.”

jeremybarnum
@jeremybarnum
Got it. Sort of. But clearly you are right (does that ever get old for you? :-) because I just got back Carthage update back with same problems after deleting all four files. I'll report back after dinner
@Kdisimone
Pete Schwamb
@ps2
If you want to work on different branches than what Carthage checked out, that’s when you’d do that
katie disimone
@Kdisimone
@jeremybarnum the easiest thing is to look at the Loop’s cartfile’s Loopkit/branch that you’re building with, and then go into github and check each of the framework/branch’s cartfile to see if they are calling for the same Loopkit/branch as your Loop’s cartfile.
Pete Schwamb
@ps2
For step 5 you’d want to add Loop project as well as the other projects to the new workspace.
jeremybarnum
@jeremybarnum
OK @Kdisimone I see. So for example, rileylink_ios dev has a cartfile, which points to loopkit. So to the extent I am building with both my own rileylink_ios (for x15) and my own loopkit (for #577) I need to make sure my rileylink cartfile points to my own loopkit branch. I'll check, but in case it's not obvious, which other frameworks also point to loopkit? Thanks - this would have taken me hours to figure out, if ever.
actually I just checked the other frameworks and the only one with a cartfile in it seems to be rileylink_ios. Is that right? So if I fix that one I should be good? Gonna try
Dragan Maksimovic
@dm61
No, there are more frameworks that point to LoopKit. Check dev versions of the frameworks. CGMBLEKit definitely, maybe another one, let me check
Also dexcom-share-client-swift
and G4ShareSpy
jeremybarnum
@jeremybarnum
ok I must have been checking the wrong branches. Thanks.
Dragan Maksimovic
@dm61
Yeah, you need to look at dev branches of everything. If it makes you feel any better I spent some hours before I figured this out some time ago
To be precise, check the branches pointed to by Loop dev Cartfile
katie disimone
@Kdisimone
Yup. It caught me up a few months ago. Finally saw the rl cartfile and had a couple head bashed on my desk in victory
Robert Silvers
@rsilvers129
This would all be a lot easier if all of the Loop code was one Xcode project. Carthage links all over make it really tricky to work on.
jeremybarnum
@jeremybarnum
@rsilvers129 tell me about it! I thought I had it figured out until I saw that CGMBLEKit cartfile links to both loopkit and dexcom-share-client-swift, and that latter has its own cartfile that links to loopkit. I'm sure there is a reason for this but for newbies like me it's a particular form of sadism. Carthage update does seem to be running succesfully now though. Thanks @Kdisimone
katie disimone
@Kdisimone
👍🏻
Robert Silvers
@rsilvers129
It took me about 12 days to learn, start, debug, and finish writing my branch. Probably a week of that was just carthage problems.
jeremybarnum
@jeremybarnum
argh so close. I had a clean carthage update run, but build is failing. I guess I have to delete some of those files again, but weird to have that after a good carthage update.
Screen Shot 2018-10-27 at 10.40.33 PM.png
jeremybarnum
@jeremybarnum
deleted files, reran carthage, failing again - seems to be trying to check out loopkit twice, my links must still be wrong.
Screen Shot 2018-10-27 at 10.48.04 PM.png
jeremybarnum
@jeremybarnum
hmm. Quite baffled by this. Seems like it should be the same problem - loopkit getting checked out twice, creates a conflict, but I've double checked all the references and they seem right. Plus, I got one clean carthage update run. Suggestions welcome!
katie disimone
@Kdisimone
@jeremybarnum do you have a branch pushed to your repo that’s causing this? I can take a look
jeremybarnum
@jeremybarnum
Thanks! Yeah - it's dm61-IRC-allmods
I was going to delete my local repos and try starting over - I think I've successfully kept all the remotes updated and all the links are to remotes, so it should work
Pete Schwamb
@ps2
Make sure you’re using the latest dev versions of everything. I’ve made a lot of changes that fix common problems with building using Carthage and workspaces.
jeremybarnum
@jeremybarnum
Screen Shot 2018-10-27 at 10.48.04 PM.png