Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 07:56
    Joerg-Schoemer synchronize #1799
  • Sep 22 09:50
    Joerg-Schoemer synchronize #1799
  • Sep 21 15:32
    snics opened #1800
  • Sep 21 00:21
    SwiftlyNoah synchronize #1798
  • Sep 21 00:20
    SwiftlyNoah synchronize #1798
  • Sep 21 00:16
    SwiftlyNoah synchronize #1798
  • Sep 21 00:13
    SwiftlyNoah synchronize #1798
  • Sep 20 20:12
    Joerg-Schoemer synchronize #1799
  • Sep 20 20:08
    Joerg-Schoemer opened #1799
  • Sep 20 02:15
    SwiftlyNoah synchronize #1798
  • Sep 19 21:49
    SwiftlyNoah synchronize #1798
  • Sep 19 20:36

    ps2 on dev

    Allow tests to bypass issuance … (compare)

  • Sep 19 19:58
    ps2 commented #1740
  • Sep 19 19:51
    ps2 commented #1787
  • Sep 19 19:51
    ps2 closed #1787
  • Sep 19 19:25
    ps2 closed #1796
  • Sep 19 19:04
    SwiftlyNoah synchronize #1798
  • Sep 19 18:27

    ps2 on dev

    Add dose enacting failures to d… (compare)

  • Sep 19 02:24
    SwiftlyNoah opened #1798
  • Sep 19 00:22
    charlesbdudley commented #1795
katie disimone
@Kdisimone
@jeremybarnum I’d be willing to be this is about having multiple cartfiles pulling in different versions of Loopkit. You need to get those all pointing to the same loopkit
jeremybarnum
@jeremybarnum
ok here is the screen shot from the carthage cleanup from the docs. @rsilvers129 last two instructions I haven't done. I'll do those next and then try @Kdisimone 's suggestion after I have dinner (I am being summoned!). Thanks all.
Screen Shot 2018-10-27 at 8.05.27 PM.png
katie disimone
@Kdisimone
Yup. You’ve got a lot of fetches for Loopkit there 😉
See how the first Loopkit resolved to the most recent commit on Loopkit’s dev branch. The next Loopkit is resolving to a different commit. So some other framework thAt your Loop is calling to has a cartfile embedded that is going to a different Loopkit. You need to track those down and make sure they all land at the same commit
Robert Silvers
@rsilvers129

@ps2 I am having trouble following that. When you say: “3. You can now go into the Carthage/Checkouts/* directories and check out branches you're wanting to work on.” You mean git checkout I assume, but would you not already be working in a checked-out branch just by the fact that carthage created the Carthage/Checkouts files?

Also “5. Add the Loop project and the .xcodeproj files for the other projects within the Carthage/Checkouts directory.” do you mean “5. Add the Xcode project for the other Framework projects from the Carthage/Checkouts directories.”

jeremybarnum
@jeremybarnum
Got it. Sort of. But clearly you are right (does that ever get old for you? :-) because I just got back Carthage update back with same problems after deleting all four files. I'll report back after dinner
@Kdisimone
Pete Schwamb
@ps2
If you want to work on different branches than what Carthage checked out, that’s when you’d do that
katie disimone
@Kdisimone
@jeremybarnum the easiest thing is to look at the Loop’s cartfile’s Loopkit/branch that you’re building with, and then go into github and check each of the framework/branch’s cartfile to see if they are calling for the same Loopkit/branch as your Loop’s cartfile.
Pete Schwamb
@ps2
For step 5 you’d want to add Loop project as well as the other projects to the new workspace.
jeremybarnum
@jeremybarnum
OK @Kdisimone I see. So for example, rileylink_ios dev has a cartfile, which points to loopkit. So to the extent I am building with both my own rileylink_ios (for x15) and my own loopkit (for #577) I need to make sure my rileylink cartfile points to my own loopkit branch. I'll check, but in case it's not obvious, which other frameworks also point to loopkit? Thanks - this would have taken me hours to figure out, if ever.
actually I just checked the other frameworks and the only one with a cartfile in it seems to be rileylink_ios. Is that right? So if I fix that one I should be good? Gonna try
Dragan Maksimovic
@dm61
No, there are more frameworks that point to LoopKit. Check dev versions of the frameworks. CGMBLEKit definitely, maybe another one, let me check
Also dexcom-share-client-swift
and G4ShareSpy
jeremybarnum
@jeremybarnum
ok I must have been checking the wrong branches. Thanks.
Dragan Maksimovic
@dm61
Yeah, you need to look at dev branches of everything. If it makes you feel any better I spent some hours before I figured this out some time ago
To be precise, check the branches pointed to by Loop dev Cartfile
katie disimone
@Kdisimone
Yup. It caught me up a few months ago. Finally saw the rl cartfile and had a couple head bashed on my desk in victory
Robert Silvers
@rsilvers129
This would all be a lot easier if all of the Loop code was one Xcode project. Carthage links all over make it really tricky to work on.
jeremybarnum
@jeremybarnum
@rsilvers129 tell me about it! I thought I had it figured out until I saw that CGMBLEKit cartfile links to both loopkit and dexcom-share-client-swift, and that latter has its own cartfile that links to loopkit. I'm sure there is a reason for this but for newbies like me it's a particular form of sadism. Carthage update does seem to be running succesfully now though. Thanks @Kdisimone
katie disimone
@Kdisimone
👍🏻
Robert Silvers
@rsilvers129
It took me about 12 days to learn, start, debug, and finish writing my branch. Probably a week of that was just carthage problems.
jeremybarnum
@jeremybarnum
argh so close. I had a clean carthage update run, but build is failing. I guess I have to delete some of those files again, but weird to have that after a good carthage update.
Screen Shot 2018-10-27 at 10.40.33 PM.png
jeremybarnum
@jeremybarnum
deleted files, reran carthage, failing again - seems to be trying to check out loopkit twice, my links must still be wrong.
Screen Shot 2018-10-27 at 10.48.04 PM.png
jeremybarnum
@jeremybarnum
hmm. Quite baffled by this. Seems like it should be the same problem - loopkit getting checked out twice, creates a conflict, but I've double checked all the references and they seem right. Plus, I got one clean carthage update run. Suggestions welcome!
katie disimone
@Kdisimone
@jeremybarnum do you have a branch pushed to your repo that’s causing this? I can take a look
jeremybarnum
@jeremybarnum
Thanks! Yeah - it's dm61-IRC-allmods
I was going to delete my local repos and try starting over - I think I've successfully kept all the remotes updated and all the links are to remotes, so it should work
Pete Schwamb
@ps2
Make sure you’re using the latest dev versions of everything. I’ve made a lot of changes that fix common problems with building using Carthage and workspaces.
jeremybarnum
@jeremybarnum
Screen Shot 2018-10-27 at 10.48.04 PM.png
katie disimone
@Kdisimone
@jeremybarnum your cartfile for G4ShareSpy points to github "LoopKit/dexcom-share-client-swift" "carthage-recursive” but your Loop cartfile points to github "jeremybarnum/G4ShareSpy" "fix-cartfile-custom-loopkit”
jeremybarnum
@jeremybarnum
does the fact that it's fetching dexcom-share twice indicate I've messed up a cartfile?
ah jinx
katie disimone
@Kdisimone
wait...
jeremybarnum
@jeremybarnum
ok checking
katie disimone
@Kdisimone
let me fix my typo
@jeremybarnum your cartfile for G4ShareSpy points to github "LoopKit/dexcom-share-client-swift" "carthage-recursive” but your Loop cartfile points to github "jeremybarnum/dexcom-share-client-swift" "carthage-recursive-custom-loopkit”
jeremybarnum
@jeremybarnum
Thanks - checking now. Really appreciate it
ok looks like a clean carthage build starting now. I got one before - I have no idea what I did that backed out the change. Thanks Katie.
jeremybarnum
@jeremybarnum
it's funny it's the same nested thing that overwhelmed me in CGMBLEKit that I joked about above - and I missed it here!
katie disimone
@Kdisimone
@jeremybarnum I also run carthage update in my frameworks individually and commit the result into my repo/branch so that the carthage.resolved is correct too. If you have bootstraps going (which I believe Loop does), the resolved should be updated to reflect the correct commit. I’m not certain of the bootstraping that may/may not happen…but I did avoid/solve some problems awhile ago with that step implemented. Can’t remember what the root issue was that brought me to that, but it’s a regular habit for me now
jeremybarnum
@jeremybarnum
hmm ok well while carthage update is running, forgive me if this is a bit remedial but:
katie disimone
@Kdisimone
So, your cartfile.resolved are pointed to old commits vs the most current commit unless you run carthage update and commit that (or edit the cartfile.resolved)
BUT I’m not a carthage speaker
lol