Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 18 21:03
    SwiftlyNoah opened #1777
  • Aug 18 20:17
    mcslader opened #1776
  • Aug 18 19:14
    ps2 commented #1670
  • Aug 18 19:14

    ps2 on dev

    Added new strings and translati… Adjustments and merged existing… Adjustments and merged existing… and 14 more (compare)

  • Aug 18 19:14
    ps2 closed #1670
  • Aug 18 18:58
    ps2 commented #1747
  • Aug 18 18:58

    ps2 on dev

    Update README.md fix app icon Merge pull request #1747 from J… (compare)

  • Aug 18 18:58
    ps2 closed #1747
  • Aug 18 18:57
    ps2 commented #1752
  • Aug 18 18:57

    ps2 on dev

    add missing binding to label -… Merge pull request #1752 from J… (compare)

  • Aug 18 18:57
    ps2 closed #1752
  • Aug 18 18:48

    ps2 on dev

    Use remote carb entry created d… Use Result type for stronger ty… Update naming and 1 more (compare)

  • Aug 18 18:48
    ps2 closed #1771
  • Aug 18 18:26
    ps2 closed #1753
  • Aug 17 16:45
    marionbarker commented #937
  • Aug 17 14:55
    elnjensen commented #937
  • Aug 17 03:52
    ryancase22 closed #1775
  • Aug 17 03:51
    ryancase22 commented #1775
  • Aug 17 03:38
    marionbarker commented #1775
  • Aug 17 02:37
    ryancase22 opened #1775
Dragan Maksimovic
@dm61
To be precise, check the branches pointed to by Loop dev Cartfile
katie disimone
@Kdisimone
Yup. It caught me up a few months ago. Finally saw the rl cartfile and had a couple head bashed on my desk in victory
Robert Silvers
@rsilvers129
This would all be a lot easier if all of the Loop code was one Xcode project. Carthage links all over make it really tricky to work on.
jeremybarnum
@jeremybarnum
@rsilvers129 tell me about it! I thought I had it figured out until I saw that CGMBLEKit cartfile links to both loopkit and dexcom-share-client-swift, and that latter has its own cartfile that links to loopkit. I'm sure there is a reason for this but for newbies like me it's a particular form of sadism. Carthage update does seem to be running succesfully now though. Thanks @Kdisimone
katie disimone
@Kdisimone
👍🏻
Robert Silvers
@rsilvers129
It took me about 12 days to learn, start, debug, and finish writing my branch. Probably a week of that was just carthage problems.
jeremybarnum
@jeremybarnum
argh so close. I had a clean carthage update run, but build is failing. I guess I have to delete some of those files again, but weird to have that after a good carthage update.
Screen Shot 2018-10-27 at 10.40.33 PM.png
jeremybarnum
@jeremybarnum
deleted files, reran carthage, failing again - seems to be trying to check out loopkit twice, my links must still be wrong.
Screen Shot 2018-10-27 at 10.48.04 PM.png
jeremybarnum
@jeremybarnum
hmm. Quite baffled by this. Seems like it should be the same problem - loopkit getting checked out twice, creates a conflict, but I've double checked all the references and they seem right. Plus, I got one clean carthage update run. Suggestions welcome!
katie disimone
@Kdisimone
@jeremybarnum do you have a branch pushed to your repo that’s causing this? I can take a look
jeremybarnum
@jeremybarnum
Thanks! Yeah - it's dm61-IRC-allmods
I was going to delete my local repos and try starting over - I think I've successfully kept all the remotes updated and all the links are to remotes, so it should work
Pete Schwamb
@ps2
Make sure you’re using the latest dev versions of everything. I’ve made a lot of changes that fix common problems with building using Carthage and workspaces.
jeremybarnum
@jeremybarnum
Screen Shot 2018-10-27 at 10.48.04 PM.png
katie disimone
@Kdisimone
@jeremybarnum your cartfile for G4ShareSpy points to github "LoopKit/dexcom-share-client-swift" "carthage-recursive” but your Loop cartfile points to github "jeremybarnum/G4ShareSpy" "fix-cartfile-custom-loopkit”
jeremybarnum
@jeremybarnum
does the fact that it's fetching dexcom-share twice indicate I've messed up a cartfile?
ah jinx
katie disimone
@Kdisimone
wait...
jeremybarnum
@jeremybarnum
ok checking
katie disimone
@Kdisimone
let me fix my typo
@jeremybarnum your cartfile for G4ShareSpy points to github "LoopKit/dexcom-share-client-swift" "carthage-recursive” but your Loop cartfile points to github "jeremybarnum/dexcom-share-client-swift" "carthage-recursive-custom-loopkit”
jeremybarnum
@jeremybarnum
Thanks - checking now. Really appreciate it
ok looks like a clean carthage build starting now. I got one before - I have no idea what I did that backed out the change. Thanks Katie.
jeremybarnum
@jeremybarnum
it's funny it's the same nested thing that overwhelmed me in CGMBLEKit that I joked about above - and I missed it here!
katie disimone
@Kdisimone
@jeremybarnum I also run carthage update in my frameworks individually and commit the result into my repo/branch so that the carthage.resolved is correct too. If you have bootstraps going (which I believe Loop does), the resolved should be updated to reflect the correct commit. I’m not certain of the bootstraping that may/may not happen…but I did avoid/solve some problems awhile ago with that step implemented. Can’t remember what the root issue was that brought me to that, but it’s a regular habit for me now
jeremybarnum
@jeremybarnum
hmm ok well while carthage update is running, forgive me if this is a bit remedial but:
katie disimone
@Kdisimone
So, your cartfile.resolved are pointed to old commits vs the most current commit unless you run carthage update and commit that (or edit the cartfile.resolved)
BUT I’m not a carthage speaker
lol
not by a long shot
jeremybarnum
@jeremybarnum
yeah well if you're not, I'm like pre-verbal in that respect
but just curious -
my loop cartfile refers entirely to remote repos - both for the standard frameworks and for anything i've customized. So I always assumed that when I ran carthage update, it was downloading those files from the git hub, and building the frameworks somewhere inside the carthage folder in loop or something like that - in other words, that to the extent that I had cloned repos of the frameworks locally that I had used to do modifications, once I pushed those back up, whatever goes on inside those local repos would be irrelevant?
katie disimone
@Kdisimone
yes…true afaik
jeremybarnum
@jeremybarnum
oh but I see what you mean
you mean before pushing the local repo of the frameworks back up, you run carthage update inside the local folder - which makes the carthage.resolve file that is uploaded correct?
Interesting
katie disimone
@Kdisimone
yes, correct
jeremybarnum
@jeremybarnum
I wish I actually understood this stuff
When @ps2 said the workspace thing makes this easier, do you think it includes this sort of thing?
katie disimone
@Kdisimone
If you look at your cartfile.resolved for the various frameworks, you’ll see different commit SHA for the same “branch” of loopkit calls…so some of your resolved for loopkit resolve to c70d3f5 (which is the right, most current one) and most of the others go to f13026 (an outdated commit from another branch I think…I didn’t look too hard for where it was). So…to keep things as neat and tidy as possible, I run carthage update (or edit the cartfile.resolved) for the frameworks to make sure they are all resolving to the most current commit. Now, this used to be much easier when it was all just one cartfile in rileylink_ios…but now that things are getting distributed more broadly, it’s more headache. So yes, workspace would help this too.
jeremybarnum
@jeremybarnum
ok
let's see if I can build after this carthage update and if not I'll run it in the frameworks and push those back up and run update again and see
katie disimone
@Kdisimone
I’m not great with the idiosyncracies of workspaces yet though…I tend to learn really well by breaking and fixing things. Haven’t experimented enough in workspaces to have broken much
Pete Schwamb
@ps2
So getting a good Carthage build at least once seems to be sometimes necessary, for reasons I don’t really understand. Be the premise of the workspace setup is that it doesn’t depend on carthage at all. Xcode will build everything and find all the dependencies. It just sometimes has trouble if the Carthage products aren’t in place initially.
katie disimone
@Kdisimone
I’m not planning on any updates to my branches currently, and if I do it wouldn’t be until after dev has been merged to master for a bit. So…I was planning on playing with workspaces as part of that
Pete Schwamb
@ps2
And I’m also wondering if some of my more recent changes obviate the need for an initial Carthage build as we’d
Well