Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 10:36
    xdddddxxs opened #1770
  • Aug 08 12:07
    carolinemreed commented #1764
  • Aug 08 12:06
    carolinemreed edited #1764
  • Aug 08 12:05
    carolinemreed reopened #1764
  • Aug 08 12:05
    carolinemreed commented #1764
  • Aug 08 12:00
    carolinemreed closed #1764
  • Aug 08 12:00
    carolinemreed commented #1764
  • Aug 08 00:19
    marionbarker commented #1769
  • Aug 08 00:10
    rolandet commented #1769
  • Aug 07 23:38
    shainey opened #1769
  • Aug 06 11:02
    ChrisVNDL closed #1755
  • Aug 06 11:02
    ChrisVNDL commented #1755
  • Aug 06 01:25
    Trpl7ca commented #1761
  • Aug 05 21:04
    BobbyG1961 commented #1761
  • Aug 05 16:57
    marionbarker commented #1761
  • Aug 05 11:31
    znv569 closed #1768
  • Aug 05 11:30
    znv569 opened #1768
  • Aug 05 01:48
    ps2 closed #1767
  • Aug 05 01:48
    ps2 commented #1767
  • Aug 05 01:46

    ps2 on dev

    Fix migration from UserDefaults (compare)

katie disimone
@Kdisimone
@jeremybarnum your cartfile for G4ShareSpy points to github "LoopKit/dexcom-share-client-swift" "carthage-recursive” but your Loop cartfile points to github "jeremybarnum/dexcom-share-client-swift" "carthage-recursive-custom-loopkit”
jeremybarnum
@jeremybarnum
Thanks - checking now. Really appreciate it
ok looks like a clean carthage build starting now. I got one before - I have no idea what I did that backed out the change. Thanks Katie.
jeremybarnum
@jeremybarnum
it's funny it's the same nested thing that overwhelmed me in CGMBLEKit that I joked about above - and I missed it here!
katie disimone
@Kdisimone
@jeremybarnum I also run carthage update in my frameworks individually and commit the result into my repo/branch so that the carthage.resolved is correct too. If you have bootstraps going (which I believe Loop does), the resolved should be updated to reflect the correct commit. I’m not certain of the bootstraping that may/may not happen…but I did avoid/solve some problems awhile ago with that step implemented. Can’t remember what the root issue was that brought me to that, but it’s a regular habit for me now
jeremybarnum
@jeremybarnum
hmm ok well while carthage update is running, forgive me if this is a bit remedial but:
katie disimone
@Kdisimone
So, your cartfile.resolved are pointed to old commits vs the most current commit unless you run carthage update and commit that (or edit the cartfile.resolved)
BUT I’m not a carthage speaker
lol
not by a long shot
jeremybarnum
@jeremybarnum
yeah well if you're not, I'm like pre-verbal in that respect
but just curious -
my loop cartfile refers entirely to remote repos - both for the standard frameworks and for anything i've customized. So I always assumed that when I ran carthage update, it was downloading those files from the git hub, and building the frameworks somewhere inside the carthage folder in loop or something like that - in other words, that to the extent that I had cloned repos of the frameworks locally that I had used to do modifications, once I pushed those back up, whatever goes on inside those local repos would be irrelevant?
katie disimone
@Kdisimone
yes…true afaik
jeremybarnum
@jeremybarnum
oh but I see what you mean
you mean before pushing the local repo of the frameworks back up, you run carthage update inside the local folder - which makes the carthage.resolve file that is uploaded correct?
Interesting
katie disimone
@Kdisimone
yes, correct
jeremybarnum
@jeremybarnum
I wish I actually understood this stuff
When @ps2 said the workspace thing makes this easier, do you think it includes this sort of thing?
katie disimone
@Kdisimone
If you look at your cartfile.resolved for the various frameworks, you’ll see different commit SHA for the same “branch” of loopkit calls…so some of your resolved for loopkit resolve to c70d3f5 (which is the right, most current one) and most of the others go to f13026 (an outdated commit from another branch I think…I didn’t look too hard for where it was). So…to keep things as neat and tidy as possible, I run carthage update (or edit the cartfile.resolved) for the frameworks to make sure they are all resolving to the most current commit. Now, this used to be much easier when it was all just one cartfile in rileylink_ios…but now that things are getting distributed more broadly, it’s more headache. So yes, workspace would help this too.
jeremybarnum
@jeremybarnum
ok
let's see if I can build after this carthage update and if not I'll run it in the frameworks and push those back up and run update again and see
katie disimone
@Kdisimone
I’m not great with the idiosyncracies of workspaces yet though…I tend to learn really well by breaking and fixing things. Haven’t experimented enough in workspaces to have broken much
Pete Schwamb
@ps2
So getting a good Carthage build at least once seems to be sometimes necessary, for reasons I don’t really understand. Be the premise of the workspace setup is that it doesn’t depend on carthage at all. Xcode will build everything and find all the dependencies. It just sometimes has trouble if the Carthage products aren’t in place initially.
katie disimone
@Kdisimone
I’m not planning on any updates to my branches currently, and if I do it wouldn’t be until after dev has been merged to master for a bit. So…I was planning on playing with workspaces as part of that
Pete Schwamb
@ps2
And I’m also wondering if some of my more recent changes obviate the need for an initial Carthage build as we’d
Well
jeremybarnum
@jeremybarnum
yay I got a successful build. Thanks Katie and Pete.
I'll see if I can figure out the workspace now...I don't think I can handle going through that again!
katie disimone
@Kdisimone
fwiw, this page has some good fairly plain language explanations https://github.com/Carthage/Carthage/blob/master/Documentation/Artifacts.md
jeremybarnum
@jeremybarnum
Thanks - I remember trying to read that a while back. Maybe it will make more sense now.
@ps2 can you recommend any reference sources that are more newbie-friendly than your wiki for workspaces? I'll try now anyway and see - maybe it's not that bad.
Pete Schwamb
@ps2
@jeremybarnum just try and let us know where/if you get stuck
jeremybarnum
@jeremybarnum
ok will do
should I run carthage update in the local framework folders before dragging them in? No harm I guess?
or it really shouldn't matter?
katie disimone
@Kdisimone
dragging?
jeremybarnum
@jeremybarnum
I started the instructions before briefly - from memory, you pull/add/"drag" the frameworks into the workspace?
anyway let me just try.
katie disimone
@Kdisimone
:thumbsup:
well, now dragging is nice. I always took the long way uphill and used the menus. just tried it. lol
jeremybarnum
@jeremybarnum
lol stopped clock is right twice a day
katie disimone
@Kdisimone
oh wait…didn’t work for the carthage/checkouts directories’ project files
had to still use menu for those
jeremybarnum
@jeremybarnum
so when I run carthage update --use-submodules --no-build the branches it seems to be fetching look like the wrong ones. I think maybe I should check out the right branch before running that step? Maybe the instructions presume you are working with master?
jeremybarnum
@jeremybarnum
ok I think this is the same thing that @ps and @rsilvers129 were discussing above. I checked out the right branch and reran carthage update --use-submodules --no-build
jeremybarnum
@jeremybarnum
hmm. Was looking promising all the way through step 6. Carthage build ran. But step 7 build failed. Are you supposed to build from Loop or from the workspace? I ran from the workspace. Building from Loop works, but I'm not sure that proves anything unless I make changes to frameworks and see whether they are incorporated? and, is it necessary to re-run carthage build after changing framework code? if so, almost no time saving. OK so I will try changing something in a framework and see whether it updates without reruning carthage build
katie disimone
@Kdisimone
Build from workspace
jeremybarnum
@jeremybarnum
ok that failed but weirdly only with yellow errors