Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    kb1000
    @kb-1000
    @maks I think a release should happen in the next few weeks because the current "stable" release always crashes when opening an image file
    Maksim Lin
    @maks
    @kaeptmblaubaer1000 sorry for the slow response, been very busy with other commitments - yes I'd like to get some of the top bugs fixed and get a new release out. Do you have a issue filed in GH repo for this? I can't seem to find it?
    kb1000
    @kb-1000
    1. this issue is the same as the ones with PDF files, and 2. AFAIK it's already fixed on master... no need for me to create an extra duplicate issue
    Maksim Lin
    @maks
    @kaeptmblaubaer1000 yep sorry I realised after I wrote that and had gone and looked at the GH issues. I'm going to try to get a new release out to Beta channel on play tomorrow.
    Maksim Lin
    @maks
    I've just tagged a new release and will shortly have it up on Beta channel for Play users. Main thing in this release is a fix to prevent crashes when opening files with external apps. If there are no significant issues in the Beta release I'll roll the release out to all users later in the week.
    Maksim Lin
    @maks
    ok I;ve just done another release to beta channel (v1.5.5.1) which fixes the crashes when attempting to open non text files in an external app (eg. PDFs, JPGs etc) fyi @kaeptmblaubaer1000
    Maksim Lin
    @maks
    Ok v1.5.5.1 now rolling out to everyone
    kb1000
    @kb-1000
    I'll check if it works
    Nope it doesn't
    It shows "Editing is not supported for this image"
    kb1000
    @kb-1000
    @maks
    Maksim Lin
    @maks
    @kaeptmblaubaer1000 it is fixed if you are seeing that message instead of app crash. Are you by any chance testing this with Google Photos, where I see that behavior too, seems to be a bug in G Photos. I just tested with another app (Snapseed) and it works fine for me (png image)
    notklaatu
    @notklaatu_gitlab
    Hi all, I'm having a problem cloning a repo from a self-hosted Git repo with MGit 1.5.5.1 I've created an SSH key in the app, copied key to my server's authorized_hosts file, and I've set the local storage to my Downloads dir to avoid permission errors.
    The expected input for Remote is the full URI to the Git repo, yeah? like myusername@example.com:/home/myusername/foo.git
    Oh I think I see the problem. SSH port defaults to 22 in the app, and I've got it set differently on the server.
    notklaatu
    @notklaatu_gitlab
    Amazing how much I figure out by publically asking a question..... Thanks, problem solved by entering Remote as ssh://user@example.com:2222/home/user/foo.git
    kb1000
    @kb-1000
    @maks yes I did use G Photos, because why should I give another data-greedy company access to my photos. It should really get fixed. But yeah, the original issue is gone.
    Maksim Lin
    @maks
    @notklaatu_gitlab glad you figured it out! MGit's documentation isn't the best https://github.com/maks/MGit/wiki/UserManual#ssh so I'd happily accept contribution of more/better docs for it :-)
    @kaeptmblaubaer1000 actually snapseed is now owned by google too. but yes its unfortunate the GPhotos doesnt register for the edit action. Since its likely to be by far the most widely used perhaps it may worth changing to using the open rather than edit action for mimetypes such as images...
    kb1000
    @kb-1000
    Oh and you know that GitHub wikis don't have PRs, don't you?
    Maksim Lin
    @maks
    unfortunately I am. I'm thinking about moving the manual from the wiki to GH pages, but thats one more thing I dont have time for. I'll add that as an issue later as would be a good one for non-technical contributors to work on
    kb1000
    @kb-1000
    You could make a new branch Travis pushes to wikis
    notklaatu
    @notklaatu_gitlab
    @maks I have a patch of UserManual.md to send you that hopefully clarifies how to clone stuff, and makes some minor English grammatical fixes. You want me to just post it as an Issue and attach the patch or do you prefer email or something else?
    Also, there'll be an article on opensource.com involving MGit in early April, so be on the look out for that. It's such a great app, thanks to everyone maintaining it!
    Maksim Lin
    @maks
    @notklaatu_gitlab wow, yes that would be great! Yes just as a PR would be fine, you could even just add it as a new file in repo and then I'll keep it in the src from now on and remove the wiki page.
    kb1000
    @kb-1000
    This user who creates those issues seems like one of the
    Petr Marek
    @MarekPetr
    Hi all, is there a reason why MGit is using JGit library and not a native git binary?
    Maksim Lin
    @maks
    @MarekPetr yes because its much easier to use a java library in android app then a native .so and then having to also build and ship the native lib for every arch supported by android devices
    Petr Marek
    @MarekPetr
    Thanks for a quick answer. I have thought something similar as well, but my bachelors thesis leader suggested it would be easier to just copy paste the binary with its dependencies. It works for simple commands like init or status, but I am having hard time making even the clone work. And I should also implement git lfs and annex, which is I guess even a lot harder than clone. How would you proceed? I am considering using jgit for everything except annex and then binaries for annex if it will be even possible to implement on android. Do you think its feasible?
    Petr Marek
    @MarekPetr
    Maybe I should reformulate my question. I stand on a crossroad. If it is possible to run git-annex with its binaries on android, it would make sense to use binaries for everything else as well. If not, sticking with Jgit is the better option.
    Maksim Lin
    @maks
    I find it difficult to advise you on how to proceed, not knowing what your goals and constraints are. There is no reason why you can't use libgit2 but I think you are talking about using the actual git binary executable? If thats the case, I am not sure I would advise that unless part of your learning experience is intended to be learning how to parse text outputs intended for human vs machine consumption.
    If you are not familar with how git works I would suggest to start by reading something like the ProGit book, especially the chapter on git internals: https://git-scm.com/book/en/v2/Git-Internals-Plumbing-and-Porcelain
    Likewise James Coglans book is also extremely useful for learnign how git actually works: https://shop.jcoglan.com/building-git/
    I also dont know what you mean by "implement" lfs and annex? They are already implemented by the git binary so what exactly are you accomplishing by reusing the existing support for those features in the git binary?
    @MarekPetr hope the above helps with your questions
    Petr Marek
    @MarekPetr
    First and foremost, thank you for helping me out, I really appreciate it. My ultimate goal is to implement an android app which supports git-lfs and git-annex, if possible. If not, I have to have good reasons why not. No constrains at all, just that I should not just You were right about me trying to make git executable work, because I thought it might be the easiest path. My first attemp was to download it from installed termux app with all dependencies. Now I am trying to build it on my own (which is quite hard for me). However I will definitely look into libgit2. And regarding lfs and annex, they are indeed implemented. Lfs should work on android, but I am not that sure with annex.
    Whoops, didn't want to send it that fast. Constraint is that I should not to just extend an existing app, but to implement it on my own. But I can use anything and in any way I want.
    Petr Marek
    @MarekPetr
    I am looking into libgit2 now and it seems to me that it should work the same as JGit. But it is written in C and without LFS support, which JGit has. Both of these make things even harder. I dont need to work with binaries, I just thought about using them as a way of making sure that the extensions (lfx, annex) will later work. So if there was a better option, I would jump on it right now. In a few days I should have at least a concept that would make git with these extensions possible to implement and the easier the way to make it happen, the better.
    kb1000
    @kb-1000
    LFS support? Yeah, JGit has that, but not the release that MGit uses.
    VadiqueMe
    @VadiqueMe
    Hi! I can’t get how to auth to push to GitHub
    kb1000
    @kb1000:matrix.org
    [m]
    You could either use an SSH key, or a personal authentication token or something similar...
    I guess it'd be nice to be able to do some sort of oauth authentication... somewhat like GitHub Desktop (I think? not sure if it actually does that...)
    Andreas Schuldei
    @stockh0lm
    hello! i want to use a new(?) id_ecdsa_sk ssh key. does mgit support those?
    i store it on my yubikey (a crypto token), that I can plug into my android phone.
    is there a way to use mgit with that?
    Maksim Lin
    @maks
    @stockh0lm hi sorry I don't know if thats going to work with MGit at the moment, as MGit uses jsch for its ssh implementation (https://github.com/maks/MGit/blob/master/app/build.gradle#L81) which I think does support ecdsa keys (https://stackoverflow.com/questions/34684251/jsch-unknownhostkey-exception-when-host-key-is-in-known-hosts-and-after-adding) but 1. I don't know if that cipher is enabled in jsch in MGit and 2. I haven't looked into how to use ssh keys from a yubikey on Andriod. But I do own a couple of Yubikeys so I am interested in this and open to any PR's for code or documentation if you or someone else looks into this - I just don't have time to do that myself at the moment
    Andreas Schuldei
    @stockh0lm
    @maks thank you! (i dont code java, so i would not be qualified. i will continue to look into it, though.)
    Andreas Schuldei
    @stockh0lm
    can mgit use ssh to clone github repositories? should it work to pull from an URL like this: ssh://git@github.com:stockh0lm/keepass-privat.git (except that repo is empty, still)
    Maksim Lin
    @maks
    @stockh0lm yes that should work, theres a minimal bit of documentation on this in the faq: https://github.com/maks/MGit/wiki/faq#server-authentication
    Andreas Schuldei
    @stockh0lm
    thanks, it works!
    Maksim Lin
    @maks
    @stockh0lm awesome! glad to hear it!