Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 23 2015 03:51

    MadcapJake on master

    Prepare 0.10.0 release (compare)

  • Sep 23 2015 03:51

    MadcapJake on v0.10.0

    (compare)

  • Sep 23 2015 03:49

    MadcapJake on master

    Add example to readme (compare)

  • Sep 23 2015 03:45

    MadcapJake on master

    Added `constructor` to list of … Update readme with badges and c… Add example image for readme (compare)

  • Sep 23 2015 03:24

    MadcapJake on master

    Add type highlighting Add some constants and more typ… (compare)

  • Sep 23 2015 02:00

    MadcapJake on master

    Fix `else` in matches, fix `@` … Add `pass` highlighting (compare)

  • Jul 07 2015 15:52

    MadcapJake on master

    Prepare 0.9.3 release (compare)

  • Jul 07 2015 15:52

    MadcapJake on v0.9.3

    (compare)

  • Jul 07 2015 15:52

    MadcapJake on master

    Fix `this` kw highlighting (compare)

  • Jul 04 2015 22:52

    MadcapJake on master

    Fix for autoindent of `@->` ope… Prepare 0.9.2 release (compare)

  • Jul 04 2015 22:52

    MadcapJake on v0.9.2

    (compare)

  • Jul 04 2015 22:43

    MadcapJake on v0.9.1

    (compare)

  • Jul 04 2015 22:43

    MadcapJake on master

    Prepare 0.9.1 release (compare)

  • Jul 04 2015 22:43

    MadcapJake on master

    Add `*->` operator (compare)

  • Jul 04 2015 20:16

    MadcapJake on master

    Add support for `@->` operator Add autoindent/deindent for obj… Prepare 0.9.0 release (compare)

  • Jul 04 2015 20:16

    MadcapJake on v0.9.0

    (compare)

  • Jul 01 2015 00:17

    MadcapJake on master

    Prepare 0.8.3 release (compare)

  • Jul 01 2015 00:17

    MadcapJake on v0.8.3

    (compare)

  • Jul 01 2015 00:17

    MadcapJake on master

    Fix nested else statements (compare)

  • Jun 29 2015 01:04
    MadcapJake commented #9
Jake Russo
@MadcapJake
@ should work now
Olivier Breuleux
@breuleux
:thumbsup:
Jake Russo
@MadcapJake
var assignment fixed to only catch with =
Jake Russo
@MadcapJake
Added support for errors
Jake Russo
@MadcapJake
The reason why key (x); key [x]; key {x} doesn't get highlighted is because they are being caught as functions. I could make the function rule only catch for non-spaced argument lists (func(x)) and then it will highlight any spaced function call (func (x)) like a keyword. Does that seem an alright assumption? It's meaningless syntactically as they are the same but typically you'd space it out if you were treating it more like a keyword.
(To be accurate, the square-bracketed form just needs to be added to the rule.)
Jake Russo
@MadcapJake
Not sure how to move forward with function arguments for inline functions. I tried just catching a parenthesized block or bare argument before a -> but that spills over into match blocks. I'm not really sure how to differentiate other than maybe not catching as an argument list if it's the first thing on the line. Would that cut it?
Olivier Breuleux
@breuleux
Yes to highlighting spaced calls, as for inline functions, I don't think it's necessarily bad that it spills over into match blocks
e.g. match x: y -> ... is a bit like an IIFE when you think about it
Jake Russo
@MadcapJake
Added filepath support
@breuleux the problem with it spilling over is there is often other stuff that would get highlighted within and it will just all be washed out by the parameter highlighting.
Jake Russo
@MadcapJake
plus, it seems a bit confusing to think of a match destructuring statement as the same as a parameter list
Olivier Breuleux
@breuleux
I don't find that confusing
maybe I would if I saw it in action
Jake Russo
@MadcapJake
yeah that's how i noticed it. I looked through eg's src folder and a lot of matches get caught as parameter lists. It just seems too much. I could of course do some kind of embedded source magery but that would be quite the undertaking.
Olivier Breuleux
@breuleux
Well, it is logical in a way to highlight all declarations (parameters, x = ..., and patterns)
could be overwhelming I guess
Jake Russo
@MadcapJake
i see how it is but I also think it's a little obfuscatory because highlighting should help the user discern what code is doing and with that rule it would (to me) make match array elements too much like functions.
i think there's a better solution that I just haven't thought of yet :smirk:
btw, check out the filepath highlighting in the latest update, tell me if you like it
Olivier Breuleux
@breuleux
In require?
Jake Russo
@MadcapJake
well, it will catch anywhere but EG will only like them inside require statements :smile:
Olivier Breuleux
@breuleux
Pretty cool! Although I think I'd highlight .x the same as x in require: .x vs require: x
well you can't very well do that in a general way
Jake Russo
@MadcapJake
yeah that would be tough
Olivier Breuleux
@breuleux
alright, that works well enough
Jake Russo
@MadcapJake
I could create a require block and then have a set of specific rules just for possible statements inside of it
Olivier Breuleux
@breuleux
not a priority
Jake Russo
@MadcapJake
ok, i'll add it to my list of future revisions :)
do you think highlighting checkers and projectors (or maybe just the ? and !) would be useful?
Olivier Breuleux
@breuleux
I don't know. Could be.
Jake Russo
@MadcapJake
Well, I'll leave it for another sprint some other day.
Dave Jeffery
@davej
@MadcapJake Just checking in to say the new version is working really well, no performance issues and the syntax highlight coloring looks much better to me.
Minor thing but if and else are different colours
Jake Russo
@MadcapJake
glad you like it!
Could you paste the if/else statement that highlights incorrectly? I see that there are some problems with if being prefixed by brackets that I'll need to fix but otherwise I am seeing them highlighted the same.
Also, are you on the latest version? (There was a intermediate version that had the problem you're mentioning)
Dave Jeffery
@davej
test-client.on("error") with (err) ->
  if err.code === "ECONNREFUSED":
    analysis.server-running-on-port-80 = false
  else:
    analysis.server-running-on-port-80 = true
Yes on the latest version
Jake Russo
@MadcapJake
ok thanks, i can fix that right now
Dave Jeffery
@davej
cool, thanks
Jake Russo
@MadcapJake
@davej let me know if that works for ya
Dave Jeffery
@davej
Yup fixed now
Jake Russo
@MadcapJake
@/all :tea: language-earl-grey v0.9.0 released! Adds support for @-> operator and obj/list indenting. Let me know if there are any bugs!
Olivier Breuleux
@breuleux
That reminds me, the *-> operator also exists, it creates a generator
But I don't think I documented that anywhere
Jake Russo
@MadcapJake
awesome! that's actually really helpful because gen doesn't work in assignments without the with keyword
Olivier Breuleux
@breuleux
like what?
Jake Russo
@MadcapJake
oh i meant when as an argument
like this koa code:
@get '/custom/:label': gen with next ->
      yield this.render("index") with {
         title = 'Placiibo - {this.params["label"]}'
         label = this.params["label"]
         blue = true
      }
Olivier Breuleux
@breuleux
ah yeah I see
Jake Russo
@MadcapJake
@breuleux , the *-> operator is highlighted with v0.9.1 :)