Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Nick LaMuro
@NickLaMuro
@lpichler There might be some revoke session failures though that might need your attention
you might be okay though, the cross repo run seems to show it passing: ManageIQ/manageiq-cross_repo-tests#199
Halász Dávid
@skateman
:+1:
Libor Pichler
@lpichler
yes and it looks that revoke ci failure is sporadic.
Nick LaMuro
@NickLaMuro
:/
Adam Grare
@agrare
Looks like master is failing with https://travis-ci.com/github/ManageIQ/manageiq-api/jobs/410038026#L1992
Failures:

  1) Authentications API OPTIONS /api/authentications returns expected and additional attributes
     Failure/Error: val[:type] = val[:type].to_s if val[:type]

     NoMethodError:
       undefined method `[]' for nil:NilClass
     # ./spec/requests/authentications_spec.rb:510:in `block (4 levels) in build_credential_options'
     # ./spec/requests/authentications_spec.rb:509:in `each'
     # ./spec/requests/authentications_spec.rb:509:in `block (3 levels) in build_credential_options'
     # ./spec/requests/authentications_spec.rb:508:in `tap'
     # ./spec/requests/authentications_spec.rb:508:in `block (2 levels) in build_credential_options'
     # ./spec/requests/authentications_spec.rb:506:in `each'
     # ./spec/requests/authentications_spec.rb:506:in `each_with_object'
     # ./spec/requests/authentications_spec.rb:506:in `block in build_credential_options'
     # ./spec/requests/authentications_spec.rb:505:in `each'
     # ./spec/requests/authentications_spec.rb:505:in `each_with_object'
     # ./spec/requests/authentications_spec.rb:505:in `build_credential_options'
     # ./spec/requests/authentications_spec.rb:498:in `block (3 levels) in <top (required)>'
haven't dug into it yet just noticed my PR failing
Daniel Berger
@djberg96
wasn't there a change in authentications recently?
mm, oct 6th, not sure if that's significant
Adam Grare
@agrare
the prior run succeeded (from Oct 26)
Adam Grare
@agrare
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[6f42c97c6a47ca4c89588b68053b086901897442] Rewrote Ansible Credential Types using DDF
yeah reverting ManageIQ/manageiq#20568 and API is green
Adam Grare
@agrare
looks like API_OPTIONS changed from a hash to an array
Oleg Barenboim
@chessbyte
sorry @agrare - it was passing all tests - maybe we need to do cross-repo tests for those kinds of changes
Adam Grare
@agrare
no worries, no way we would have known without running the API specs
Adam Grare
@agrare
only the embedded_ansible credentials have the ddf style, the ansible-tower ones still use the old style
Oleg Barenboim
@chessbyte
@agrare ManageIQ/manageiq-api#947 looks good to me. Tests are green. Merge?
Adam Grare
@agrare
:+1: yeah, still think it is strange EmbeddedAnsible and AnsibleTower have completely different formats for the OPTIONS result
but it'll get the API back to green in the meantime
Oleg Barenboim
@chessbyte
merged
Franklin-lab
@Franklin-lab
@Fryguy @agrare After importing Ansible playbooks, we are creating a catalog then using for button. I would like to know is there any way to differentiate the provisioning catalog and ansible catalog through API?
Franklin-lab
@Franklin-lab
Can you anyone share the API to find out the list of Catalog published in CloudForm?

is there a helper to get the URL to a resource from its ActiveRecord reference? something like:

vm = Vm.find(123)
api_resource_path(vm) # => '/api/vms/123'
api_resource_path(vm.class) # => '/api/vms'

I guess we should be able to do this as the api.yml contains a klass field for each collection and indirectly even to subcollections

Franklin-lab
@Franklin-lab
Thanks @skateman
Halász Dávid
@skateman
something like this? ManageIQ/manageiq-ui-classic#7477
Franklin-lab
@Franklin-lab
Hello...Can anyone share the best practice deployment guide for policies?
Can anyone tell me how many compliances like PCI, HIPAA, FISMA supported by Cloudform?
Brandt Woolf
@bwoolf1122
Hey everyone, I am looking to allow access to /api/guest_devices for a non admin user but I cant seem to find the correct rbac feature. Anyone know which specific feature gives access to this?
Adam Grare
@agrare
Libor Pichler
@lpichler
I will take a look at it
Nick LaMuro
@NickLaMuro

Just an FYI: Something with MiqProductFeature has changed that has broken the build for manageiq-api. Not sure what, but it seems to have happened at the end of last week.

Can look into it more tomorrow.

Jason Frey
@Fryguy
A cache cleanup PR was merged
But that was just today
Nick LaMuro
@NickLaMuro

Turns out it was this PR:

ManageIQ/manageiq#20438

cc @h-kataria

NickLaMuro @NickLaMuro also always forgets that git bisect is an excellent option for figuring this stuff out
Adam Grare
@agrare
:heart: git bisect
Keenan Brock
@kbrock
aah - that failure makes sense
Nick LaMuro
@NickLaMuro
yeah, I think I just need to update the config/api_config.yml to update it to the new identifier names
which... is a bit tedious, but I think I can manage
but yes, I thought for a large part of the day it was going to be something to do with either the work you did, or the stuff with cattr_accessor -> class_attribute changes, but that was no correct
Keenan Brock
@kbrock
(which you can also blame on me)
Keenan Brock
@kbrock

are the tips for what we need to do to get codeclimate running again on the api?
e.g.: ManageIQ/manageiq-api#964

failure has been happening for a little while now

ok, the first time code climate run was with ManageIQ/manageiq-api#734
and it looks like it has never completed successfully (sample size smallish)
Harpreet Kataria
@h-kataria
@NickLaMuro is everythign sorted out, or need me to look into it?
Nick LaMuro
@NickLaMuro
@h-kataria I opened ManageIQ/manageiq-api#965
but I need one question answered
Harpreet Kataria
@h-kataria
checking
Halász Dávid
@skateman
sorry :see_no_evil: didn't check this channel, I just wanted one of my PRs to be green :disappointed: