Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Daniel Berger
    @djberg96
    looks like 'name' and 'age' are reversed
    i actually think the spec is bad
    Daniel Berger
    @djberg96
    ok, submitted a separate PR to fix that spec :)
    Daniel Berger
    @djberg96
    Bill, I think we're in a catch-22
    I think we need to force this one: ManageIQ/azure-armrest#383
    so that the others can then pass
    right now it's choking on 2.2.x for some reason, not sure if Travis dropped support or what
    Daniel Berger
    @djberg96
    @bzwei ok ManageIQ/azure-armrest#383 is green now :)
    Daniel Berger
    @djberg96
    anyone still here?
    azure-armrest 0.9.14 has been released
    why? well, there were some memoist dep issues that Joe R wanted worked out
    so, it includes that change, as well as a few other updates that have been scattered over the last year or so
    Daniel Berger
    @djberg96
    @bzwei Please review ManageIQ/azure-armrest#387 when you get a chance
    Daniel Berger
    @djberg96
    @Fryguy this ok? ManageIQ/azure-armrest#388
    Jason Frey
    @Fryguy
    Merged @djberg96
    Daniel Berger
    @djberg96
    cool, thanks :)
    Daniel Berger
    @djberg96
    Couple new PR's
    (hm, why did it skip 391?)
    Jason Frey
    @Fryguy
    Cause you opened an issue in between
    pull requests are issues
    Daniel Berger
    @djberg96
    oh, right, was thinking they were separate numbers
    Daniel Berger
    @djberg96
    This was pretty badly out of date, it's good again: https://github.com/ManageIQ/azure-armrest/wiki/Capturing-An-Image
    Daniel Berger
    @djberg96
    Daniel Berger
    @djberg96
    Ignore the Hakiri warning, it's unrelated
    Daniel Berger
    @djberg96
    though it's failing for some reason
    didn't fail locally, weird
    Nick LaMuro
    @NickLaMuro
    @djberg96 we had some issues with a new version of the config gem that got released. See ManageIQ/manageiq#20888 for details
    probably re-pushing will cause an updated version of spec/manageiq to be synced and will probably solve your issue
    Jason Frey
    @Fryguy
    azure-armrest is a standalone gem
    and the issues in travis there look like an activesupport change
    Nick LaMuro
    @NickLaMuro
    yup, just realized that, ignore me!
    Daniel Berger
    @djberg96
    @NickLaMuro i was very confused, lol
    Nick LaMuro
    @NickLaMuro
    oh, I guess they just released 6.1 as well: https://weblog.rubyonrails.org/2020/12/9/Rails-6-1-0-release/
    Daniel Berger
    @djberg96
    @Fryguy, aha, removing my local Gemfile.lock and doing bundle install again revealed it
    Jason Frey
    @Fryguy
    on that note...time to post in manageiq core room
    Daniel Berger
    @djberg96
    now to figure out where 1.month lives
    Daniel Berger
    @djberg96
    gonna lock it to activesupport 5.x
    Nick LaMuro
    @NickLaMuro
    left a comment on how that is going to affect the Rails 6.0 upgrade for ManageIQ/manageiq
    Daniel Berger
    @djberg96
    do we need to update a repo setting as well if we do this?
    Daniel Berger
    @djberg96
    (i'm guessing there's a webhook or something, but I don't have access to the project settings)
    Jason Frey
    @Fryguy
    Yes...I'll comment in the PR (we need to add stuff to .travis.yml as well as update Travis itself with a token)
    Daniel Berger
    @djberg96
    ok, thanks
    Daniel Berger
    @djberg96
    should i go ahead and merge now or wait?
    Jason Frey
    @Fryguy
    I'll merge it when I put the token up there
    Daniel Berger
    @djberg96
    ok, thanks