simaishi on kasparov-1-alpha1
agrare on master
Declared DDF schema for cloud v… Set the supports :cloud_volume/… Merge pull request #644 from sk… (compare)
agrare on master
Supports label mapping in infra… Merge pull request #665 from lp… (compare)
andyvesel on master
Update Network Targeted refresh… Update refresh to catch not fou… Merge pull request #667 from au… (compare)
@agrare does this make any sense to you? https://github.com/ManageIQ/manageiq/blob/master/app/models/mixins/swift_manager_mixin.rb#L23-L35
before we create a provider, save the child provider (which is not valid until after the parent is saved) and update all ems id (for a provider that hasn't been created yet because we are in the before_create) and change it to the child
This is true with cinder and swift. The
save as far as I can tell always fails.
I was going to suggest removing them (added by rich in 2016) since I don't see how this could ever work. Maybe it was in place of a db migration?
Added run-time migration between managers.
save- not doing anything
:type. Do we have a preferred method? I kind of like the overloading but not sure if you two have an opinion
a specific case of the ensure_network_manager wouldn't even be needed if we declared the association correctly
include ManageIQ::Providers::Openstack::ManagerMixin # that declared: #has_one :network_manager, # :foreign_key => :parent_ems_id, # :class_name => "ManageIQ::Providers::NetworkManager" def ensure_network_manager build_network_manager(:type => 'ManageIQ::Providers::Openstack::NetworkManager') unless network_manager end
include ManageIQ::Providers::Openstack::ManagerMixin # that declared ensure_network_manager # def ensure_network_manager # build_network_manager unless network_manager # end has_one :network_manager, :foreign_key => :parent_ems_id, :class_name => "ManageIQ::Providers::OpenStack::NetworkManager"
.update!(:guid => SecureRandom.uuid)for now
:guid => nil