by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 26 13:44

    chessbyte on master

    Remove sleep from save_inventor… Merge pull request #582 from ag… (compare)

  • May 26 13:44
    chessbyte closed #582
  • May 26 13:44
    chessbyte assigned #582
  • May 26 13:11
    miq-bot commented #582
  • May 26 13:06
    agrare synchronize #582
  • May 26 13:06
    agrare labeled #582
  • May 26 13:05
    agrare review_requested #582
  • May 26 13:05
    agrare opened #582
  • May 22 16:32
    bdunne edited #581
  • May 22 15:35
    miq-bot commented #581
  • May 22 15:27
    bdunne review_requested #581
  • May 22 15:27
    bdunne review_requested #581
  • May 22 15:27
    bdunne opened #581
  • May 21 19:14
    simaishi labeled #580
  • May 21 19:14
    simaishi unlabeled #580
  • May 21 19:14
    simaishi commented #580
  • May 21 19:13

    simaishi on jansa

    Merge pull request #580 from ag… (compare)

  • May 21 17:59
    gtanzillo labeled #580
  • May 21 17:59
    gtanzillo unlabeled #580
  • May 21 13:45
    simaishi labeled #579
Adam Grare
@agrare
I could get the scaffolding done without access to the environment, but once we get to the parser I'd need someone like you to run it against a live system
gubbe505
@gubbe505
Oké. Great.
I have had some time to look at the datamodel of both MIQ and NSX-T. We want ours tenants to manage NSX-T segments, subnets, groups, services and security policies.
The segment, subnet and group can be mapped to ManageIQ models, but there is no model for the services and security policy.
Adam Grare
@agrare
hm looks like they only have python and java SDKs for NSX, that's going to be a bit of an issue
ThomasBuchinger
@ThomasBuchinger

@agrare Hi, just read your Post on vimBroker removal. is there a 1:1 replacement for people using vimBroker from Automate?

I think there are a many people using code like this vim = $evm.vmdb(:vm).first.object_send('instance_eval', 'with_provider_object { | vimVm | return vimVm }') to get a vimBrocker object and add additional disks to the VM. I have seen this bit of code in various iterations on the manageiq forum and in the RedHatOfficial/miq-Utilities repo. I think you guys might want to make sure everybody knows about this change and what they need to do
https://github.com/RedHatOfficial/miq-Utilities/blob/ef24e21875bb5527335a8110a3493bb8407abf4e/Automate/RedHatConsulting_Utilities/Infrastructure/VM/Provisioning/StateMachines/Methods.class/__methods__/resize_disk.rb

Jason Frey
@Fryguy
.object_send('instance_eval' was never supported

If you need resize_disk functionality not present in upstream I would recommend getting a PR into upstream with this code [1] to add it as a more official method

[1] https://github.com/RedHatOfficial/miq-Utilities/blob/ef24e21875bb5527335a8110a3493bb8407abf4e/Automate/RedHatConsulting_Utilities/Infrastructure/VM/Provisioning/StateMachines/Methods.class/__methods__/resize_disk.rb#L58

then you'd just call a normal ".resize_disk" method on the vm object without having to hack around the object boundaries
otherwise you can use rbvmomi and or vmware_web_service gems directly
Jason Frey
@Fryguy
@agrare Might be useful to reply to your own post with these alternatives
Adam Grare
@agrare
:+1:
ThomasBuchinger
@ThomasBuchinger

I know it is not supported. Correct me if I am wrong, but doesn't the resize_disk method use the vimBroker?

I just wanted to alert you to the fact that I have seen this bit of code in a few AutomateDomains and and that you might want to communicate this change in some official way. We got this piece of code from pemcg ages ago, so I think this could be pretty widely used

Adam Grare
@agrare
@ThomasBuchinger resize_disk is a method on the MiqVimVm object, previoiusly it was run in the broker but now the exact same code is run by the OperationsWorker
if you use the normal Vm#add_disk Vm#resize_disk method it will work
Jason Frey
@Fryguy

I just wanted to alert you to the fact that I have seen this bit of code in a few AutomateDomains and and that you might want to communicate this change in some official way. We got this piece of code from pemcg ages ago, so I think this could be pretty widely used

thanks for the heads up on that

ThomasBuchinger
@ThomasBuchinger
@Fryguy No Problem
@agrare I don't have the miq-Utilities domain in my environment, so I couldn't test which object it uses internally, it just looked similar, so I thoughtit might use the old object
if there are any method that you're missing (e.g. I don't see resize disk there, just add and remove) we should add them to the service models
ThomasBuchinger
@ThomasBuchinger
As I said, this was ages ago (even before I worked on our CloudForms). I guess there was no support for #add_disk back then? And we never bothered to fix it when there was support. We only need add_disk so we should be fine :)
Adam Grare
@agrare
actually there is no resize_disk in MIQ core, that does a direct reconfig :scream:
so yeah, we should add methods for that haha
ThomasBuchinger
@ThomasBuchinger
Always happy to add more stuff to your todo-list, sorry for that :sunglasses:
Adam Grare
@agrare
can you open an enhancement issue on the vmware repo? otherwise I'll forget it haha
and link to the miq-utilities method so we can update that to use the new one
thanks!
Adam Grare
@agrare
perfect thanks @ThomasBuchinger
ThomasBuchinger
@ThomasBuchinger
Hey! How did I end up with a task!?! :laughing:
ManageIQ/manageiq-providers-vmware#524
Adam Grare
@agrare
:laughing:
phospi
@phospi
Hi, i'd like to know if there are any plans to sync vmware tags like it is done with aws tags today. Does someone work on it or should I open a request or has this been denied in the past?
Adam Grare
@agrare
Hey @phospi we had a bugzilla ticket for it but I think it got closed
If you want to open a GitHub issue we'll take a look at it
It is a different API than what we currently talk to so that's why it is a little bit more difficult than just collecting one more property
Oleg Barenboim
@chessbyte
@agrare #537 looks good to me. want to fix the Rubocop warning before I merge?
Adam Grare
@agrare
:+1: will do
Adam Grare
@agrare
@chessbyte all green
Oleg Barenboim
@chessbyte
merged #537 #526 and #487
Daniel Berger
@djberg96
:clap:
Daniel Berger
@djberg96
I don't think this is related to nokogiri, is it? https://travis-ci.com/ManageIQ/manageiq-cross_repo-tests/jobs/291500998
Daniel Berger
@djberg96
@agrare can you confirm? ^
Daniel Berger
@djberg96
hm, something funky going on, i ran the specs in isolation on my local machine: https://gist.github.com/djberg96/f36a8a1d85632f045a921448eb544386
Adam Grare
@agrare
That was fixed yesterday afternoon, try rebasing
specifically by ManageIQ/manageiq-providers-vmware#543 @djberg96
Daniel Berger
@djberg96
ok, thanks
Adam Grare
@agrare
:+1: sorry for the disruption
Daniel Berger
@djberg96
@agrare you inspired me to see how vmware specs would do with strict partials
only 3 failures, will see if i can fix them easily
Adam Grare
@agrare
:heart: awesome
Daniel Berger
@djberg96
specifically reconfigure_spec.rb lines 410 and 426, apparently the Vm subclass does not implement a add_scsi_controllers method