These are chat archives for ManageIQ/manageiq/containers

19th
Mar 2018
Beni Cherniavsky-Paskin
@cben
Mar 19 12:03

@jawatts very weird:

Unknown InventoryCollection saver strategy: :batch, allowed strategies are :default, :batch, :concurrent_safe and :concurrent_safe_batch

did you open a bug / BZ?
cc @Ladas. Only scenario I can think of for that message is if strategy was string "batch" instead of symbol, but don't see how that would happen.

Ladislav Smola
@Ladas
Mar 19 12:41
@cben yeah, something broke with how we load settings, @psav is there a BZ?
Pete Savage
@psav
Mar 19 13:00
I was about to create one
I know exactly what happened
It is in the REST getting for advanced settings
It converts the symbol to a string
which is right as language agnostic REST wouldn't have a "symbol" necessarily
Ladislav Smola
@Ladas
Mar 19 13:14
@psav so, we shouldn't have symbols in settings?
I think it would be much better to stick to strings
then it's universally read/writable
Ladislav Smola
@Ladas
Mar 19 13:18
@psav when did we start to use this?
Pete Savage
@psav
Mar 19 13:18
I'm not sure - we only started to use the advanced settings via REST only recently
Ladislav Smola
@Ladas
Mar 19 13:19
@psav is it backported in g-release?
Pete Savage
@psav
Mar 19 13:26
I believe so
Jason Frey
@Fryguy
Mar 19 19:36
I am working on a PR to accept strings
at least string keys
if there are symbolized values we need to change those as well.
or change the backing code to accept both