These are chat archives for ManageIQ/manageiq/performance

6th
Nov 2015
Greg Blomquist
@blomquisg
Nov 06 2015 13:09 UTC
@ChrisArcand, I see you, too, are sporting a daskeyboard (from your blog pic) ... cherry blues?
Chris Arcand
@chrisarcand
Nov 06 2015 13:38 UTC
@blomquisg I actually got browns to spare my coworkers the click when I worked in the office…then I caused a widespread adoption of mech keyboards by everyone of all switches and sometimes wish I had done blues ;) I’d probably switch (pun?) but never have a reason to dump the money into a new keyboard when this one has been going strong.
Greg Blomquist
@blomquisg
Nov 06 2015 13:52 UTC
@ChrisArcand ha! So, I got blues, then sorta wished I had browns (b/c of the office noise)
Chris Arcand
@chrisarcand
Nov 06 2015 13:58 UTC
…reeeeally...
Greg Blomquist
@blomquisg
Nov 06 2015 14:07 UTC
how I imagine @ChrisArcand right now:
http://i.imgur.com/BR5u38D.jpg
Keenan Brock
@kbrock
Nov 06 2015 14:41 UTC
@Fryguy @matthewd MiqLdap catches Exceptionin some places, and StandardError in others. Also it has a timeout for some bind calls, while not in others.
Is this intentionally different? Or ok to make that code more consistent?
Alex Krzos
@akrzos
Nov 06 2015 14:46 UTC
@dmetzger57 Did you want a closer look at the amount of time it takes a perf_capture_timer to run on 5.4?
It's exceeding the 600s timeout on my scale setup
and by scale I mean only 10k vms in a single zone
Matthew Draper
@matthewd
Nov 06 2015 14:50 UTC
@kbrock if it's re-raising, Exception might be the right thing (depending). If it's not, I would be very surprised if switching to StandardError meant we failed to catch something we care about.
Dennis Metzger
@dmetzger57
Nov 06 2015 14:51 UTC
@akrzos given the issues at hand, i'll hold off digging deeper into this one at the moment
Keenan Brock
@kbrock
Nov 06 2015 14:51 UTC
@matthewd thanks. that was my gut too
@matthewd also remember alot of work from you around timeouts. was odd to see the disparity there
Jason Frey
@Fryguy
Nov 06 2015 14:57 UTC
Many places in our code catches Exception because it really wants to catch Timeout::Error , because that one doesn't derive from StandardError
Particular in old coffee when we didn't know the "rules" of Ruby
s/coffee/code
For MiqLdap, I think @gmcculloug might be your best bet
Matthew Draper
@matthewd
Nov 06 2015 14:59 UTC
Timeout::Error used to not derive from StandardError
Alex Krzos
@akrzos
Nov 06 2015 14:59 UTC
@dmetzger57 gotcha
Matthew Draper
@matthewd
Nov 06 2015 14:59 UTC
Now the I'm-timing-out exception doesn't, but the I-timed-out exception does
Jason Frey
@Fryguy
Nov 06 2015 15:07 UTC
Yes, thanks for the clarification