These are chat archives for ManageIQ/manageiq/performance

1st
Feb 2016
Keenan Brock
@kbrock
Feb 01 2016 17:51
anyone available for a performance consult?
high level: convert_to_ui_tree takes up most of our time. (78%)
Matthew Draper
@matthewd
Feb 01 2016 17:53
78% of what?
The entire response, for some page that we care about? (and which is presumably slow enough to warrant investigation)
Keenan Brock
@kbrock
Feb 01 2016 17:54
sev 1
view vms
Matthew Draper
@matthewd
Feb 01 2016 17:55
Okay, I can believe us caring about view vms :)
Keenan Brock
@kbrock
Feb 01 2016 17:55
lol
Matthew Draper
@matthewd
Feb 01 2016 17:55
But so it's 78% of the total response time?
Keenan Brock
@kbrock
Feb 01 2016 17:56
yes
locally:
Matthew Draper
@matthewd
Feb 01 2016 17:56
How much of that is AR / queries?
Alex Krzos
@akrzos
Feb 01 2016 17:56
@kbrock Are you looking at the ui bz that was sent out?
Keenan Brock
@kbrock
Feb 01 2016 17:56
@matthewd 0
Alex Krzos
@akrzos
Feb 01 2016 17:56
This message was deleted
Keenan Brock
@kbrock
Feb 01 2016 17:56
@akrzos yes
I'm on master. so I may be viewing something very different than older versions
Alex Krzos
@akrzos
Feb 01 2016 17:56
@kbrock ok cool, is there a need for me to help test it right now?
Keenan Brock
@kbrock
Feb 01 2016 17:57
no, still digging. but I had assumed it was database related :)
Alex Krzos
@akrzos
Feb 01 2016 17:57
I the appliance gss posted was a 5.4
Keenan Brock
@kbrock
Feb 01 2016 17:57
yes
maybe I'll install a profiling gem over there test
don't like mucking with environments like that
no problem hacking my own code
Alex Krzos
@akrzos
Feb 01 2016 17:58
ok Might need to get a copy of that db first then so I can build it on an appliance and try a few things
so bz is posted as 5.4.2, we have 5.4.5 as latest 5.4 and the appliance with the issue shown is 5.4.1
Keenan Brock
@kbrock
Feb 01 2016 18:22
I'm guessing it is across all of 5.4
there are enough BZs out there all with similar stories
Alex Krzos
@akrzos
Feb 01 2016 18:29
@kbrock I think so too, I got a copy of the db now
I'll pull it into the latest 5.4 to see how bad it is on my hardware
Keenan Brock
@kbrock
Feb 01 2016 18:30
I'm downloading the dump now - it is at root on the applinace
Jason Frey
@Fryguy
Feb 01 2016 19:12
@kbrock Isn't view vms the one I already made faster?
Keenan Brock
@kbrock
Feb 01 2016 19:12
@Fryguy heh
Jason Frey
@Fryguy
Feb 01 2016 19:13
i.e. it's the TreeBuildVmsAndTemplates
Keenan Brock
@kbrock
Feb 01 2016 19:13
so adding the rails helper to do the ui icon
that took it from 3 seconds to 14seconds
Jason Frey
@Fryguy
Feb 01 2016 19:13
oy
you mean the presenters decorators?
Keenan Brock
@kbrock
Feb 01 2016 19:13
but we have our culpret - fix is easy
  def node_icon(icon)
    ActionController::Base.helpers.image_path("100/#{icon}")
  end
Jason Frey
@Fryguy
Feb 01 2016 19:14
oh I hadn't seen that
PR link?
Keenan Brock
@kbrock
Feb 01 2016 19:16
I'm worrying about 5.4 right now
when I was looking at master - that was my main culpret
Matthew Draper
@matthewd
Feb 01 2016 19:17
We should fix that helper thing once, properly.. not just in this one place.
Keenan Brock
@kbrock
Feb 01 2016 19:18
yea - 30 files call that