anyone available for a performance consult?
high level:
convert_to_ui_tree takes up most of our time. (78%)
78% of what?
The entire response, for some page that we care about? (and which is presumably slow enough to warrant investigation)
sev 1
view vms
Okay, I can believe us caring about view vms :)
lol
But so it's 78% of the total response time?
yes
locally:
How much of that is AR / queries?
@kbrock Are you looking at the ui bz that was sent out?
10703.3 / 13706.5 -- http://localhost:3000/vm_infra/explorer
@matthewd 0
This message was deleted
@akrzos yes
I'm on master. so I may be viewing something very different than older versions
@kbrock ok cool, is there a need for me to help test it right now?
no, still digging. but I had assumed it was database related :)
I the appliance gss posted was a 5.4
yes
maybe I'll install a profiling gem over there test
don't like mucking with environments like that
no problem hacking my own code
ok Might need to get a copy of that db first then so I can build it on an appliance and try a few things
so bz is posted as 5.4.2, we have 5.4.5 as latest 5.4 and the appliance with the issue shown is 5.4.1
I'm guessing it is across all of 5.4
there are enough BZs out there all with similar stories
@kbrock I think so too, I got a copy of the db now
I'll pull it into the latest 5.4 to see how bad it is on my hardware
I'm downloading the dump now - it is at root on the applinace
@kbrock Isn't view vms the one I already made faster?
@Fryguy heh
i.e. it's the TreeBuildVmsAndTemplates
so adding the rails helper to do the ui icon
that took it from 3 seconds to 14seconds
oy
you mean the presenters decorators?
but we have our culpret - fix is easy
def node_icon(icon)
ActionController::Base.helpers.image_path("100/#{icon}")
end
oh I hadn't seen that
PR link?
I'm worrying about 5.4 right now
when I was looking at master - that was my main culpret
We should fix that helper thing once, properly.. not just in this one place.
yea - 30 files call that