These are chat archives for ManageIQ/manageiq/performance

29th
Apr 2016
Oleg Barenboim
@chessbyte
Apr 29 2016 13:39
@kbrock which Rails PR is that?
Keenan Brock
@kbrock
Apr 29 2016 13:43
the one that was double loading the schemas for classes
Oleg Barenboim
@chessbyte
Apr 29 2016 13:58
so, do we have to undo similar work that you did on our side?
Keenan Brock
@kbrock
Apr 29 2016 14:00
no, we're all set on this one
Alex Krzos
@akrzos
Apr 29 2016 14:18
this guy is back from Openstack Summit (FYI)
Joe Rafaniello
@jrafanie
Apr 29 2016 14:29
nice, congrats @kbrock
where was that hurting us the most? rails boot?
Keenan Brock
@kbrock
Apr 29 2016 14:31
@jrafanie rbac, hardware aggregation, zone -> models, ...
ooh
worry - yea, rails boot
Jason Frey
@Fryguy
Apr 29 2016 14:31
link to PR?
Dennis Metzger
@dmetzger57
Apr 29 2016 14:31
welcome back @akrzos - ready for some end of release fun?
Keenan Brock
@kbrock
Apr 29 2016 14:32
rails/rails#24653
wonder if we will see the speed up for specs. or if it is just the model tests I was running locally
english help: expect { Vm.first }.to query_database(5) -- better name for query_database?
Chris Arcand
@chrisarcand
Apr 29 2016 14:51
@kbrock What does that do
Literally execute a db query?
Oh, ‘5 queries’?
Keenan Brock
@kbrock
Apr 29 2016 15:24
@chrisarcand you are right - it should be 1
Chris Arcand
@chrisarcand
Apr 29 2016 15:29
@kbrock Is doing this sort of testing advisable? I would think yes if you were making an assertion after running something you already need to test, but if we start getting a bunch of specs in their own example just testing # of queries, the whole suite starts getting slower….and slower….
Should leave a note on the matcher saying “Please Test Responsibly™"
:confused: