These are chat archives for ManageIQ/manageiq/performance

30th
Jun 2016
Jason Frey
@Fryguy
Jun 30 2016 00:30
You can probably do no reports in the tree. But people will probably want the "last status" eventually for the icon which puts us in a similar boat
Keenan Brock
@kbrock
Jun 30 2016 14:01
@Fryguy you had just said "yea, we totally rewrote all of that. you should look at the stuff"
do you remember what we were talking about? was it alerts and assigning tags?
Nick LaMuro
@NickLaMuro
Jun 30 2016 21:08
Have a quick, though kinda minor, optimization to the Reports page here: ManageIQ/manageiq#9559
I am working on some other tweaks and improvements, but this at least provides a bit of a boost with no changes in functionality
Once I figure out how to use @kbrock 's https://github.com/kbrock/perf_utils, I might toss in some memory metrics as well ;)
Keenan Brock
@kbrock
Jun 30 2016 21:18
guilty
sorry
that will be my weekend project
@NickLaMuro biggest hurdle for me is finding out how to modify rack-mini-profiler so you can specify which monkey patch / adapter method you want to use
Nick LaMuro
@NickLaMuro
Jun 30 2016 21:21
well, I would tell you not to worry about it and I will just figure it out
but I figured you will do it anyway ;)
Oleg Barenboim
@chessbyte
Jun 30 2016 21:23
@NickLaMuro can you produce one of those tables that @kbrock does with Number of SQL Queries, Rows Returned, Query Time, ...
Keenan Brock
@kbrock
Jun 30 2016 21:23
lol
Once I figure out how to use @kbrock 's https://github.com/kbrock/perf_utils, I might toss in some memory metrics as well ;)
Oleg Barenboim
@chessbyte
Jun 30 2016 21:23
@NickLaMuro your performance improvement in ManageIQ/manageiq#9559 looks awesome!
I did not realize that memory metrics meant query metrics
Keenan Brock
@kbrock
Jun 30 2016 21:24
ooh
good point
Nick LaMuro
@NickLaMuro
Jun 30 2016 21:28
@chessbyte Yeah, I will try to get that working, but I think it has objects allocated in there as well, which is what I think @kbrock was talking about with that
Keenan Brock
@kbrock
Jun 30 2016 21:28
@NickLaMuro
PerfUtils.track("vm count") { Vm.first }
Nick LaMuro
@NickLaMuro
Jun 30 2016 21:28
@kbrock heh, thanks
Oleg Barenboim
@chessbyte
Jun 30 2016 21:29
its good that we are all talking about the same thing
Keenan Brock
@kbrock
Jun 30 2016 21:29
I hadn't realized that I could run one without the other
turns out I had the functionality built in when I was building it. who knew? (or I guess it is "who can remember?")
Oleg Barenboim
@chessbyte
Jun 30 2016 21:30
latter, for sure
welcome to my world :-)
Keenan Brock
@kbrock
Jun 30 2016 21:30
lol
Nick LaMuro
@NickLaMuro
Jun 30 2016 21:30
:smile:
Keenan Brock
@kbrock
Jun 30 2016 21:30
I wrote that code... not that long ago. and I'm thinking "you can't do that"
Nick LaMuro
@NickLaMuro
Jun 30 2016 21:31
That is why I stop remembering things, and just get really good at searching/greping for them
Keenan Brock
@kbrock
Jun 30 2016 21:31
well, I was about to add that method and it turned out to already be there
nick: git fetch may bring in a little stuff for that gem
I have it linked in my Gemfile.dev.rb
Nick LaMuro
@NickLaMuro
Jun 30 2016 22:19
@kbrock I have forked perf_utils... you have been warned...
actually, the warning was too late... I already made a small PR :smiling_imp:
Keenan Brock
@kbrock
Jun 30 2016 22:26
@NickLaMuro thanks - do you think we should do this here - or do you think we should create another repo w/ rack-mini-profiler?
Nick LaMuro
@NickLaMuro
Jun 30 2016 22:30
@kbrock hrmm... mind clarifying what you mean by that?
Keenan Brock
@kbrock
Jun 30 2016 22:31
keep feeling like there are a few things in that repo
but a cli for rack-mini-profiler could be pulled out
and could be used by others
and while I like rack mini profiler...
I like this cli better ;)
Nick LaMuro
@NickLaMuro
Jun 30 2016 22:31
ah
well, I don't know the project that well to help you make that call yet
or rather, make the Right :tm: call yet
but I will say that there is a decent amount in that right now that probably could be broken up a bit
anyway, I will help out a bit with that one for now when I have time, but let me know if you do end up splitting that up into another repo
Keenan Brock
@kbrock
Jun 30 2016 22:34
+1