These are chat archives for ManageIQ/manageiq/performance

28th
Jul 2016
Alex Krzos
@akrzos
Jul 28 2016 16:32
5.6.1 :thumbsup: on lower idle memory usage
Keenan Brock
@kbrock
Jul 28 2016 16:39
@akrzos cool
Keenan Brock
@kbrock
Jul 28 2016 18:28
ugh. so cap&u timer will blow up if someone runs it with debug mode turned on (I'm pretty sure)
but since I never run that with debug mode on...
Jason Frey
@Fryguy
Jul 28 2016 18:28
you mean debug logging?
Keenan Brock
@kbrock
Jul 28 2016 18:28
Y
Jason Frey
@Fryguy
Jul 28 2016 18:28
oh wow...that's surprising
Keenan Brock
@kbrock
Jul 28 2016 18:29
        _log.debug do
          log_target = "#{self.class.name} name: [#{name}], id: [#{id}]"
          "Skipping capture of #{log_target} -" +
            "Performance last captured on [#{target.last_perf_capture_on}] is within threshold"
        end
I did it
it was moved out from target to a global space
Jason Frey
@Fryguy
Jul 28 2016 18:29
ok, why would that fail?
Keenan Brock
@kbrock
Jul 28 2016 18:29
so self, name, and id are not avaiable in the new location
Jason Frey
@Fryguy
Jul 28 2016 18:29
ahhh
Keenan Brock
@kbrock
Jul 28 2016 18:29
note, there is last_perf_capture_on - with target
Jason Frey
@Fryguy
Jul 28 2016 18:29
so just a normal bug after the relocation of some code
Keenan Brock
@kbrock
Jul 28 2016 18:30
yea
Jason Frey
@Fryguy
Jul 28 2016 18:30
I though you meant it like failed to capture metrics because it logged too much or something
Keenan Brock
@kbrock
Jul 28 2016 18:30
well, it will puke
Jason Frey
@Fryguy
Jul 28 2016 18:30
yeah, but that's just a normal, fixable, bug :)
Keenan Brock
@kbrock
Jul 28 2016 18:30
lol
do I need to backport?
Jason Frey
@Fryguy
Jul 28 2016 18:30
might as well
Keenan Brock
@kbrock
Jul 28 2016 18:30
lol
Jason Frey
@Fryguy
Jul 28 2016 18:31
a bug is a bug...if we ever have a customer turn it on, then it won't work
Keenan Brock
@kbrock
Jul 28 2016 18:31
correct
Jason Frey
@Fryguy
Jul 28 2016 18:31
and I assume the fix is relatively small
Keenan Brock
@kbrock
Jul 28 2016 18:31
yes
I found because I'm moving that code
Jason Frey
@Fryguy
Jul 28 2016 18:31
:+1:
Keenan Brock
@kbrock
Jul 28 2016 18:31
current targets.each { .. that code .. ; que it }
==>
that code ; current targets.each { queue it }
so after the change I can profile them separately. yay!
anyway
ok