These are chat archives for ManageIQ/manageiq/performance

18th
Aug 2016
and have the workload generator send annotations into graphite (and then into grafana)
Alex Krzos
@akrzos
Aug 18 2016 14:39
that would be awesome
for when we scan over multiple scenarios run over a period of time
Nick LaMuro
@NickLaMuro
Aug 18 2016 14:47
Is there an API for that, or are we going to have to hack it?
Keenan Brock
@kbrock
Aug 18 2016 14:48
one definition of hack is adding it to the api :)
Nick LaMuro
@NickLaMuro
Aug 18 2016 14:50
whip out your Go chops boys and girls
Keenan Brock
@kbrock
Aug 18 2016 14:57
@NickLaMuro for delegatin, should I assume :allow_nil, or leave that code in there?
I can't imagine ever needing it... and it is a bit complex... but it is already written
Nick LaMuro
@NickLaMuro
Aug 18 2016 14:59
ever needing :allow_nil => false or :allow_nil => true?
Chris Arcand
@chrisarcand
Aug 18 2016 15:21
I am really, really, really mad at myself. I apparently didn’t do a straight change and lost all RBAC filterer git history. :angry:
Keenan Brock
@kbrock
Aug 18 2016 15:22
@NickLaMuro ever needing :allow_nil => false
@chrisarcand that is ok - just blame kbrock or gtanzillo
besides, there isn't much history in that class ;)
Brandon Dunne
@bdunne
Aug 18 2016 15:23
@chrisarcand git reflog to the rescue?
Chris Arcand
@chrisarcand
Aug 18 2016 15:23
Already merged
Keenan Brock
@kbrock
Aug 18 2016 15:23
can you double revert and move?
ugh
and apply all those darn changes from kbrock
I'd really like some history there :(
also, it was not easy to copy over my PR/stashes on rbac over to filterer.
in the future, people may be confused while spelunking
Chris Arcand
@chrisarcand
Aug 18 2016 15:28
Well tbf you haven’t noticed until I said anything ;)
Nick LaMuro
@NickLaMuro
Aug 18 2016 15:28
I did...
Chris Arcand
@chrisarcand
Aug 18 2016 15:29
shh.
Nick LaMuro
@NickLaMuro
Aug 18 2016 15:29
Didn't I get mad at you last week?
Chris Arcand
@chrisarcand
Aug 18 2016 15:29
I don’t understand why that happened. Even in the commit that moved it it looks like a straight rename.
Nick LaMuro
@NickLaMuro
Aug 18 2016 15:31

excuse me, it was like two weeks ago (in a PM):

Also, a royal "FU" for making this commit and making blaming a PITA... ManageIQ/manageiq@b0eb62f

Aug 3 14:27

Tim Wade
@imtayadeway
Aug 18 2016 15:52
@chrisarcand if it makes you feel any better, and it won't, I now own all the API code
Chris Arcand
@chrisarcand
Aug 18 2016 15:53
If I wasn’t neck deep in trying to understand the rbac filtering api it would.
Nick LaMuro
@NickLaMuro
Aug 18 2016 15:54
It is #funAndStuff
Keenan Brock
@kbrock
Aug 18 2016 16:22
lol
@chrisarcand you are right. I noticed it but couldn't put my finger on it. so I'd never have "blamed" you for the git reason.
eh - were going to be deleting most of that code soon anyway.
Nick LaMuro
@NickLaMuro
Aug 18 2016 16:23
#cleansweep
Keenan Brock
@kbrock
Aug 18 2016 16:24
@NickLaMuro ok, lets try again with the delegation ManageIQ/manageiq#10476
I like how all I did was "go back and cut a commit up into 2 commits" and I end up with a different solution and 8 more commits
Nick LaMuro
@NickLaMuro
Aug 18 2016 16:25
and the MiqBot strikes again!
though, with legit complaints
Keenan Brock
@kbrock
Aug 18 2016 16:26
ugh, thought I fixed all of those
lol. miq bot thinks we should drop error support and allow_nil - to get down the number of parameters ;)
Nick LaMuro
@NickLaMuro
Aug 18 2016 16:28
heh
Keenan Brock
@kbrock
Aug 18 2016 16:28
either that or just throw all those options into 1 giant hash
sorry - snark
it is legit. I noticed the same thing
ok - :allow_nil on the docket / chopping block. @NickLaMuro let me know if you want to keep it. otherwise I'm deleting and simplifying this monstrosity
Nick LaMuro
@NickLaMuro
Aug 18 2016 16:34
I think you should keep it
since :allow_nil extension from ActiveSupport compared to the vanilla ruby way of doing it
if people get it by default, it might cause some confusion
Keenan Brock
@kbrock
Aug 18 2016 16:37
thanks. I'll need you to talk me off this cliff a few more times before we merge ;)
Keenan Brock
@kbrock
Aug 18 2016 19:37
reminder, best to run server in production mode when running performance numbers
Dennis Metzger
@dmetzger57
Aug 18 2016 19:49
i always do, then again i almost always run an appliance
Keenan Brock
@kbrock
Aug 18 2016 19:58
yea
easy win: ManageIQ/manageiq#10616
Keenan Brock
@kbrock
Aug 18 2016 20:03
@Fryguy do you often wonder if we should change ancestry to use an array instead of a '/' dilineated string? (and possibly use the id of the searching record)?
also wonder about using '.' dilineated string - postgres parses those natively using ltree extension - but array seems better
do wonder about changing ancestry to have the sql used as a module. so it could use any number of schemes
but the code feels old. and since we can't push the gem (yet?)