These are chat archives for ManageIQ/manageiq/performance

8th
Sep 2016
Nick LaMuro
@NickLaMuro
Sep 08 2016 02:36

Unrelated to the above, this might be of some interest if you happen to be using stackprof as much as I find myself doing lately:

tmm1/stackprof#70

Joe Rafaniello
@jrafanie
Sep 08 2016 12:28
Nice
Halász Dávid
@skateman
Sep 08 2016 13:46
hm
because it will moved into the treebuilders, I just don't wanted to cause a lot of merge conflicts for Zita
we're still generating dynatree-compatible trees and they're traversed again to convert them
she has like 10 more to go, then this will be refactored
Halász Dávid
@skateman
Sep 08 2016 13:54
how can i verify this? do you have some profiling tools?
Keenan Brock
@kbrock
Sep 08 2016 14:25
@skateman what is zita doing with the tree builders? Is it on the ui side or the ruby side?
Dan Clarizio
@dclarizio
Sep 08 2016 14:26
@kbrock ruby side
Nick LaMuro
@NickLaMuro
Sep 08 2016 14:38
@skateman sorry, playing catch up
is not a morning person...
I don't have any profiling tools for the front end, just a big DB of VMs
I will see if I can figure out a way to replicate the data without handing off a DB dump
#shouldBeDoableMaybeHopefullyFingersCrossed
Halász Dávid
@skateman
Sep 08 2016 14:43
try to comment the loop in the convert function, if that speeds things up, then it's fine
the trees will look weird, but that's fine in the performance context
Nick LaMuro
@NickLaMuro
Sep 08 2016 14:45
@skateman so the performance on the server is basically the same, so it isn't on the ruby end (sorry I wasn't clear about that)
it is strictly it rendering in the browser that is the problem
Halász Dávid
@skateman
Sep 08 2016 14:45
huh
i will take a look at it
Nick LaMuro
@NickLaMuro
Sep 08 2016 14:47
@skateman basically, you get one of these: https://c1.staticflickr.com/3/2762/4328752773_8ccb4b9411.jpg
Halász Dávid
@skateman
Sep 08 2016 14:47
:(
Nick LaMuro
@NickLaMuro
Sep 08 2016 14:48
again, I will see if I can replicate the data in the console from a fresh DB so you have something to work with
Halász Dávid
@skateman
Sep 08 2016 14:48
it is possible that bootstrap-treeview is slower than dynatree :(
Nick LaMuro
@NickLaMuro
Sep 08 2016 14:48
that would be my guess
Halász Dávid
@skateman
Sep 08 2016 14:49
@NickLaMuro will turn on JS profiling
Halász Dávid
@skateman
Sep 08 2016 14:56
@NickLaMuro yes, the issue is in the JS :(
Nick LaMuro
@NickLaMuro
Sep 08 2016 14:57
is it an easy fix? :pray:
Joe Rafaniello
@jrafanie
Sep 08 2016 14:58
haha, JS and easy!
Keenan Brock
@kbrock
Sep 08 2016 14:58
there are 2 answers, one of which is to put less in the tree... just sayin' ;)
Joe Rafaniello
@jrafanie
Sep 08 2016 14:58
you so funny @NickLaMuro
Keenan Brock
@kbrock
Sep 08 2016 14:58
lol
Dan Clarizio
@dclarizio
Sep 08 2016 15:02
@kbrock with that logic, why not just show blank screens everywhere? :)
Joe Rafaniello
@jrafanie
Sep 08 2016 15:03
only if the blank screens are fast!
Halász Dávid
@skateman
Sep 08 2016 15:03
:D :D
Dan Clarizio
@dclarizio
Sep 08 2016 15:03
guaranteed!!!
Halász Dávid
@skateman
Sep 08 2016 15:03
let's use VanillaJS :D :D
Joe Rafaniello
@jrafanie
Sep 08 2016 15:04
I can't keep up with the new hotness or even the old hotness in javascript
Halász Dávid
@skateman
Sep 08 2016 15:04
it was a joke :) check it
Joe Rafaniello
@jrafanie
Sep 08 2016 15:05
javascript in general or your link? :wink:
Halász Dávid
@skateman
Sep 08 2016 15:05
my link
Dennis Metzger
@dmetzger57
Sep 08 2016 15:05
well played @jrafanie
Halász Dávid
@skateman
Sep 08 2016 15:06
@NickLaMuro can you send me the JSON of that big tree? will try to speed it up
Keenan Brock
@kbrock
Sep 08 2016 15:06
@dclarizio I'll have a PR with that change for you today. Did you want #333 or actual #000 ?
Nick LaMuro
@NickLaMuro
Sep 08 2016 15:07
@skateman working on it
P.S. The spinners in that VanillaJS link, lol
Keenan Brock
@kbrock
Sep 08 2016 16:18
@Fryguy do you have a specific Setting location for 'turn vms on/off in the tree view'? nothing in settings.yml stood out for me
Keenan Brock
@kbrock
Sep 08 2016 16:27
@Fryguy updating for your previous changes. changing to Settings.ui.tree.display_vms