These are chat archives for ManageIQ/manageiq/performance

10th
Oct 2016
Joe Rafaniello
@jrafanie
Oct 10 2016 15:37
@kbrock thinking about your question RE: use of sort_by in models for columns, it's possible, there were some virtual columns or something we couldn't do in SQL and they were cargo culted to other places where you could actually do them in arel. Either way, it's good to fix those where it's an obvious win.
Keenan Brock
@kbrock
Oct 10 2016 16:52
@jrafanie https://bugzilla.redhat.com/show_bug.cgi?id=1348625 -- what is the process that prunes those tables?
It is tricky to read the scheduling stuff
was looking in schedules.rb and jobs.rb - but not finding delete, prune, remove or any other phrase that would suggest pruning
Jason Frey
@Fryguy
Oct 10 2016 16:58
Individual jobs call purge_timer on some interval
Keenan Brock
@kbrock
Oct 10 2016 16:59
aah - right - thanks
Jason Frey
@Fryguy
Oct 10 2016 16:59
Some of those purgers purge subtables as well... For example the reports purger is also responsible for purging associated report_results
Keenan Brock
@kbrock
Oct 10 2016 17:00
yes. coming back to me.
Jason Frey
@Fryguy
Oct 10 2016 17:00
(that is, you won't find a direct report _ results purger in the jobs)
Keenan Brock
@kbrock
Oct 10 2016 17:00
so it is a magical method. or are there actual entries that say "purge these"
Jason Frey
@Fryguy
Oct 10 2016 17:00
Actual entries
I believe almost all of them say purge_timer
(_timer is the pattern we were going for for methods called by the scheduler)
Keenan Brock
@kbrock
Oct 10 2016 17:02
perfect -thanks. found 2 of them
Jason Frey
@Fryguy
Oct 10 2016 17:09
:+1:
Keenan Brock
@kbrock
Oct 10 2016 17:16
heh, but it looks like 3 of the tables that are big do not call purge. fun fun fun
Jason Frey
@Fryguy
Oct 10 2016 17:17
Yes, hence, the BZ jrafanie opened as a reminder
Keenan Brock
@kbrock
Oct 10 2016 17:17
we're not even purging event streams correctly - lol
Jason Frey
@Fryguy
Oct 10 2016 17:17
yeah, that's a big known one :(
Keenan Brock
@kbrock
Oct 10 2016 17:17
yay @jrafanie - good find
Jason Frey
@Fryguy
Oct 10 2016 17:18
he also found vim_performance_states I believe
Joe Rafaniello
@jrafanie
Oct 10 2016 17:23
thanks @Fryguy @kbrock
actually @gtanzillo found vim*states
Keenan Brock
@kbrock
Oct 10 2016 17:23
would be nice if we could clean up the scheduling code
tricky to read that code
/ignore
Joe Rafaniello
@jrafanie
Oct 10 2016 17:24
yeah, I don't disagree
it grew organically
Keenan Brock
@kbrock
Oct 10 2016 17:24
has green fuzzies?
@jrafanie safe to say, that we should be triggering these purges from job.rb (either directly or indirectly)?
Jason Frey
@Fryguy
Oct 10 2016 17:27
typically we've been exposing via schduler jobs and also from a CLI in the tools directory
in case a user needs to do it on demand for whatever reason
the CLI typically exposes more params than the scheduled job
Keenan Brock
@kbrock
Oct 10 2016 17:30
@Fryguy so all big (growing) tables need to be purgable via job.rb and cli.
Jason Frey
@Fryguy
Oct 10 2016 18:14
yeah probably