These are chat archives for ManageIQ/manageiq/performance

19th
Oct 2016
Chris Arcand
@chrisarcand
Oct 19 2016 00:18
I’m sure you guys already do this in other ways, but a neat baked in feature for AR coming… rails/rails#26815
Chris Arcand
@chrisarcand
Oct 19 2016 00:36
Might as well just use rack mini profiler though I suppose.
Keenan Brock
@kbrock
Oct 19 2016 00:56
thanks @chrisarcand - but also, maybe monkey patching "debug" may be useful if we want to get our own hooks into there as well
@NickLaMuro looks like rails has a sql stack cleaner available
Nick LaMuro
@NickLaMuro
Oct 19 2016 01:21
yeah, I had a friend that was using that at one point, it is pretty nice
Jason Frey
@Fryguy
Oct 19 2016 03:45
@chrisarcand pretty cool
Hope they accept it (unlike my instantiation-time patch ;) )
Nick LaMuro
@NickLaMuro
Oct 19 2016 03:53
This one? rails/rails#7457 (opened by JR, which is why I am not sure)
Keenan Brock
@kbrock
Oct 19 2016 03:54
yea - there is no active support notification for instantiation time. it is hard to collect that. have to add a few vendor specific monkey pathches
Jason Frey
@Fryguy
Oct 19 2016 03:54
Yup that's it
We wrote it together, and he submitted from our fork MUCH later when we started trying to get rid of the fork
Keenan Brock
@kbrock
Oct 19 2016 03:56
hmm
I remember matthew saying that there is a lot of sensitivity around notifications
this would add a lot of notifications
but there is currently NO visibility into the instantiation time, which is often more significant than the queries
Jason Frey
@Fryguy
Oct 19 2016 03:57
Yup :/ At least we have it in our app :)
Keenan Brock
@kbrock
Oct 19 2016 03:58
also of note, pluck and count hide those numbers
and some of our preload downloads thousands of ids, but it is below the radar
Jason Frey
@Fryguy
Oct 19 2016 03:58
Well, they don't instantiate, so makes sense
Keenan Brock
@kbrock
Oct 19 2016 03:58
but it is downloading thousands of rows
but yea
is it possible to get that count, and put it into the regular ar fetch counter?
sorry, couldn't resist
Keenan Brock
@kbrock
Oct 19 2016 03:59
lol
Jason Frey
@Fryguy
Oct 19 2016 03:59
Oh true, yeah, creates thousands of ints, but not ARs... Still takes time and memory
Keenan Brock
@kbrock
Oct 19 2016 03:59
so the number of events is the same. but more information is provided
Jason Frey
@Fryguy
Oct 19 2016 04:00
I actually LOLed at that image right now
Keenan Brock
@kbrock
Oct 19 2016 04:01
message_bus.instrument("instantiation.active_record", payload)
does that look like what we want?
it is in querying, and join_dependency
Jason Frey
@Fryguy
Oct 19 2016 04:02
Not sure offhand
You'd probably have to experiment
Keenan Brock
@kbrock
Oct 19 2016 04:03
yea, think that feature is in rails 5
it was glaringly missing. but I can appreciate not wanting to take the hit
@NickLaMuro ^ we need that
Nick LaMuro
@NickLaMuro
Oct 19 2016 04:04
More memes?
Keenan Brock
@kbrock
Oct 19 2016 04:04
lol
Nick LaMuro
@NickLaMuro
Oct 19 2016 04:04
doesn't take much seriously after 10pm... also just watch a lot of John Oliver
Keenan Brock
@kbrock
Oct 19 2016 04:04
ar instantiation
is it past 10pm yet?
nope
it is 0:04
@Fryguy quick q. #12042 you ok introducing has_many :through?
nick - that is not for another 22 hours yet ;)
Jason Frey
@Fryguy
Oct 19 2016 04:07
:moon: I'll check tomorrow ;)
Keenan Brock
@kbrock
Oct 19 2016 04:07
lol
Jason Frey
@Fryguy
Oct 19 2016 04:08
Also, its not tomorrow yet here in Texas
Keenan Brock
@kbrock
Oct 19 2016 04:08
ooh. so it is after 10pm for you
Jason Frey
@Fryguy
Oct 19 2016 04:08
11
Keenan Brock
@kbrock
Oct 19 2016 04:09
yea, you fall into the window
Jason Frey
@Fryguy
Oct 19 2016 04:10
Was surprised how much of Texas is only 1hr off of Eastern
Keenan Brock
@kbrock
Oct 19 2016 04:10
texas is big
Jason Frey
@Fryguy
Oct 19 2016 04:12
Exactly why I thought more would be in mountain time...:)
Turns out it's basically just this little dinky tip with el paso that's mountain time
Nick LaMuro
@NickLaMuro
Oct 19 2016 04:24
Yeah, but the EST timezone stretches to Indiana, so looking at it that way, it makes sense
Keenan Brock
@kbrock
Oct 19 2016 11:44
Hi @morrimar I do not. Think I'd like to take one of those too. The sales staff does have some presentation videos that are very informative. Not sure if there are links around
Nick LaMuro
@NickLaMuro
Oct 19 2016 14:28
@kbrock wrong room?
Keenan Brock
@kbrock
Oct 19 2016 16:58
Lol. Yup. Gitter glitches on me sometimes. Not taking credit for my mistake ;)