These are chat archives for ManageIQ/manageiq/performance

16th
Mar 2017
Keenan Brock
@kbrock
Mar 16 2017 13:06
@lpichler So ManageIQ/manageiq#13446 is failing because the code will not work with the assumed db part of "managed-field"
Is it as simple as just adding the db? (i.e.: "#{db}.managed-field")?
Do you know where we reference this field and if we can tack on the rpt.db in our code?
Libor Pichler
@lpichler
Mar 16 2017 13:24
looking - but I think that yes - just add db - because old get_col_info also rely on model
Keenan Brock
@kbrock
Mar 16 2017 13:39
@lpichler before it would just punt and say "dunno, :string maybe?"
vs now, we will return actual type
maybe we need to add a "dunno" option
but to be honest, I want to remove get_col_info completely and get the calling code to use the parse method. - so the "dunno" case is troublesome
Libor Pichler
@lpichler
Mar 16 2017 14:03
hmm I am not sure because we are using MiqExpression.gel_col_info also for the format ‘operating_system.processes.cpu_time’ and there is model the operating_system so it looks like we can't use parse_tag_or_field or set just :string as default
but for 'managed-field’ it is ok string because tag are always strings
Keenan Brock
@kbrock
Mar 16 2017 14:16
@lpichler to verify - you just said - the existing get_col_info looks very sketchy / buggy. right?
Libor Pichler
@lpichler
Mar 16 2017 14:21
I would say yes but we need to look why we need get_col_info for columns in MiqReport (not in fields in MiqExpression)
to me looks like it is called also without model like:
 MiqExpression.get_col_info('name')
{
                         :data_type => nil,
                :virtual_reflection => false,
                    :virtual_column => false,
                       :sql_support => true,
    :excluded_by_preprocess_options => false,
                               :tag => false,
                           :include => {}
}
Keenan Brock
@kbrock
Mar 16 2017 14:23
LOL
glad it is unknown and has sql support
Libor Pichler
@lpichler
Mar 16 2017 14:24
yea I am getting error with your PR for example when I want to create condition in expression report editor when I want to add tag to the condition
Keenan Brock
@kbrock
Mar 16 2017 14:24
ooh
do you have a stack trace?
my PR does not handle the case where the model is assumed. and we need to fix
Libor Pichler
@lpichler
Mar 16 2017 14:25
Error caught: [ActionView::Template::Error] undefined method `available_tags' for #<ApplicationController::Filter::Expression:0x007fb1c4d0f110>
Did you mean?  available_adv_searches
/Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/application_controller/filter/expression.rb:59:in `tags_for_display_filters'
/Users/liborpichler/manageiq/manageiq-ui-classic/app/views/layouts/exp_atom/_edit_tag.html.haml:8:in `___sers_liborpichler_manageiq_manageiq_ui_classic_app_views_layouts_exp_atom__edit_tag_html_haml__102793045239291255_70200746300000'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/template.rb:159:in `block in render'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/notifications.rb:166:in `instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/template.rb:354:in `instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/template.rb:157:in `render'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/renderer/partial_renderer.rb:343:in `render_partial'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/renderer/partial_renderer.rb:311:in `block in render'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/notifications.rb:164:in `block in instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/notifications.rb:164:in `instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/renderer/abstract_renderer.rb:41:in `instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/renderer/partial_renderer.rb:310:in `render'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/renderer/renderer.rb:47:in `render_partial'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/renderer/renderer.rb:21:in `render'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/helpers/rendering_helper.rb:32:in `render'
/Users/liborpichler/manageiq/manageiq-ui-classic/app/views/layouts/exp_atom/_editor.html.haml:68:in `___sers_liborpichler_manageiq_manageiq_ui_classic_app_views_layouts_exp_atom__editor_html_haml__373164390327734136_70200745262140'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/template.rb:159:in `block in render'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/notifications.rb:166:in `instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/template.rb:354:in `instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/template.rb:157:in `render'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/renderer/partial_renderer.rb:343:in `render_partial'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/renderer/partial_renderer.rb:311:in `block in render'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/actionview-5.0.2/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/notifications.rb:164:in `block in instrument'
/usr/local/opt/rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/activesupport-5.0.2/lib/active_support/notifica
yes but I think it can be on more places
also there is MiqReport.get_col_info - there is MiqExpression.gel_col_info called
Keenan Brock
@kbrock
Mar 16 2017 16:38
@lpichler hmm. do you think I introduced that? Did this work before my changes?