These are chat archives for ManageIQ/manageiq/performance

17th
Mar 2017
Libor Pichler
@lpichler
Mar 17 2017 10:38
I am sorry @kbrock it is not caused by your PR I am getting error also on master
Keenan Brock
@kbrock
Mar 17 2017 12:02
@lpichler phew
@lpichler sorry, my comments on ManageIQ/manageiq#13692 were not clear - think just getting the Field.parse or Tag.parse out works better than us applying regular expressions in the main method to then just apply a regular expression in the parse.
Keenan Brock
@kbrock
Mar 17 2017 13:02
Having trouble getting through https://www.speedshop.co/2017/03/09/a-guide-to-gc-stat.html /via ruby weekly
But good information about GC.stat
Jason Frey
@Fryguy
Mar 17 2017 13:56
I just read that one the other day...good article
Libor Pichler
@lpichler
Mar 17 2017 15:42
@kbrock I agree :+1:
@kbrock but maybe it will be possible to put to the code instead of calling value2tag(and delete this method) directly MiqExpression::Tag.parse(op_args["tag”]).exits_tag( op_args["value”])) for example to this place https://github.com/ManageIQ/manageiq/pull/13692/files#diff-e5855dfa8cc9aeeeb9d13acd1525499eL530
Keenan Brock
@kbrock
Mar 17 2017 15:58
so Tag defines the "value2tag" - that would probably be nicer
Libor Pichler
@lpichler
Mar 17 2017 16:03
and what about of to have generating of these <value type=#{col_type}>#{val}</value> or <count>#{count}</count>, <exist ref=#{ref}>#{val}</exist>…. in methods( of Target/or his chidren 's classes) like value_tag(), count_tag(), exist_tag()
Keenan Brock
@kbrock
Mar 17 2017 16:06
can we just delete that xml wanna be junk?
hmm
what does value2tag do?
Libor Pichler
@lpichler
Mar 17 2017 16:12
but the xml is used for evalution of miq_expression
it take field and create (I don’t know how to call it) tag_path and in addition in array
for example
value2tag("Vm.user_tag-name", "thing1”)
to ["vm", "/user/name/thing1”]
and it used to generate the xml
like<value type=#{col_type}>#{val}</value>
so there is lot of unnecesaray array conversion/spliting etc.
Keenan Brock
@kbrock
Mar 17 2017 16:26
yea, then the xml is converted back into ["vm", "/user/name/thing1"] I'm sure
and into ruby where it is eval'd
Joe Rafaniello
@jrafanie
Mar 17 2017 17:55
I can't get past thing1... What about thing2?
Keenan Brock
@kbrock
Mar 17 2017 19:14
well, there is a reason why we're hitting MiqExpression with so many PRs...