These are chat archives for ManageIQ/manageiq/performance

2nd
Oct 2017
Nick LaMuro
@NickLaMuro
Oct 02 2017 21:49

For anyone interested, I opened up a performance PR against ActiveSupport to improve their String#camelize and String#underscore implementations:

rails/rails#30782

Jason Frey
@Fryguy
Oct 02 2017 21:50
ping tenderlove on it
he loves object allocation PRs
Chris Arcand
@chrisarcand
Oct 02 2017 22:01
:clap:
Nick LaMuro
@NickLaMuro
Oct 02 2017 22:02
#waitedForOctoberToOpenThat
Chris Arcand
@chrisarcand
Oct 02 2017 22:03
...why?
Somehow i imagine you average at least 6 PRs a month to MIQ repos anyway ;)
Nick LaMuro
@NickLaMuro
Oct 02 2017 22:04
I realize that by "just doing my job", I can finish Hacktoberfest, but to me, that really doesn't fall within the spirit of why it exists
Chris Arcand
@chrisarcand
Oct 02 2017 22:05
lol you <3
Jason Frey
@Fryguy
Oct 02 2017 22:05
:angel:
Chris Arcand
@chrisarcand
Oct 02 2017 22:05
:point_up:
Nick LaMuro
@NickLaMuro
Oct 02 2017 22:05
I try to challenge myself to actually create some PRs that are outside of the scope of MIQ
though, that said, this stuff is technically helping improve some of the azure-armrest code that I have been helping with...