These are chat archives for ManageIQ/manageiq/performance

2nd
Feb 2018
Nick LaMuro
@NickLaMuro
Feb 02 2018 15:42
@kbrock use sysproctable!
(unless you aren't writing this thing in ruby...)
Keenan Brock
@kbrock
Feb 02 2018 15:42
ruby ftw
thnx
Joe Rafaniello
@jrafanie
Feb 02 2018 15:47
@kbrock yeah, we parse most of what you see in top and smem from /proc
note, cpu time is weird, it's in deciseconds I believe
Keenan Brock
@kbrock
Feb 02 2018 15:48
heh
of course it is
Joe Rafaniello
@jrafanie
Feb 02 2018 15:48
or something that's neither milliseconds or seconds
Keenan Brock
@kbrock
Feb 02 2018 15:48
well, dennis had a smattering of things he wanted
Joe Rafaniello
@jrafanie
Feb 02 2018 15:48
we get it directly from /proc and they do it in that weird unit
Keenan Brock
@kbrock
Feb 02 2018 15:48
so maybe I'll need to add some gook to sysproctable
Joe Rafaniello
@jrafanie
Feb 02 2018 15:49
It's probably good to implement some performance changes I believe you and @NickLaMuro have mentioned before if we're going to be using it more and more
cc @djberg96
Those can happen anytime but I remember one of you mentioning it was inefficient in how it read /proc but can't remember who and what the details were
Nick LaMuro
@NickLaMuro
Feb 02 2018 15:51
I can look at making some PR's for some of those today, since I will probably get frustrated with minishift work at some point and want to table flip
Joe Rafaniello
@jrafanie
Feb 02 2018 15:59
@NickLaMuro :laughing:
Keenan Brock
@kbrock
Feb 02 2018 15:59
@NickLaMuro I think frustration is a given
Joe Rafaniello
@jrafanie
Feb 02 2018 15:59
Pre-emptive table flip distractions
Keenan Brock
@kbrock
Feb 02 2018 15:59
it is neat stuff... but sometimes tricky to wrestle
hmm. no emoji for flip table
Joe Rafaniello
@jrafanie
Feb 02 2018 16:00
@NickLaMuro could be worse, we could still be tracking down a hard to find memory leak ;-)
Keenan Brock
@kbrock
Feb 02 2018 16:04
does it seem like this could be more lazy?
fetching it all in one fell swoop seems good - to detect stopped processes and all
but we also parse a lot of data that is probably not needed
Joe Rafaniello
@jrafanie
Feb 02 2018 16:09
There's only one way to tell is determine if it's really costing us time/memory
we don't really care if it's not run that often and/or the time/memory cost isn't significant
Daniel Berger
@djberg96
Feb 02 2018 16:15
sys-proctable has two ways to read
ProcTable.ps.each{ ... } and ProcTable.ps{ ... }
The first is slurpy, the second is not
But the first is faster
Joe Rafaniello
@jrafanie
Feb 02 2018 16:16
slurpy :-)
Keenan Brock
@kbrock
Feb 02 2018 16:16
heh
Daniel Berger
@djberg96
Feb 02 2018 16:16
:)
meaning, the first approach reads everything into memory, while the second approach yields one record at a time
Keenan Brock
@kbrock
Feb 02 2018 16:17
I see the benchmark in there too
@djberg96 is there a reason for no Gemfile?
are they different for different platforms?
Daniel Berger
@djberg96
Feb 02 2018 16:17
i don't have Gemfiles for most of my gems
Keenan Brock
@kbrock
Feb 02 2018 16:17
ok
a pr ok? or you gemfile adverse?
I expect to type bundle and have everything work
Daniel Berger
@djberg96
Feb 02 2018 16:18
i just don't think they're necessary for small libs
Joe Rafaniello
@jrafanie
Feb 02 2018 16:18
it might be hard too for different platforms
Keenan Brock
@kbrock
Feb 02 2018 16:18
noticed that ffi is not stated as a dependency
travis manually installs it
Daniel Berger
@djberg96
Feb 02 2018 16:18
yeah, that gem in particular is a royal pain for platform support, as @jrafanie well knows
Keenan Brock
@kbrock
Feb 02 2018 16:19
remember nokigiri being a pita too
Joe Rafaniello
@jrafanie
Feb 02 2018 16:19
:sweat_smile:
Keenan Brock
@kbrock
Feb 02 2018 16:19
similar issues
Daniel Berger
@djberg96
Feb 02 2018 16:19
@kbrock it depends on the platform as to whether FFI is required
for Linux it's not
note that sys-proctable also comes with a Sys::Top class
Nick LaMuro
@NickLaMuro
Feb 02 2018 16:27

hmm. no emoji for flip table

That is why there is ascii:

ʕノ•ᴥ•ʔノ ︵ ┻━┻

Daniel Berger
@djberg96
Feb 02 2018 16:36
Added a couple wiki pages, btw
Nick LaMuro
@NickLaMuro
Feb 02 2018 16:37
:+1: