These are chat archives for ManageIQ/manageiq/performance

14th
Mar 2018
Nick LaMuro
@NickLaMuro
Mar 14 2018 19:14
Probably spent more time watching this then I should have, but found this talk really interesting about flamegraphs.
Keenan Brock
@kbrock
Mar 14 2018 19:38
you spent a lot of time understanding why they use ubuntu?
would be cool if postgres data could be added to the flame graph - instead of "fetching data" - it would show what was happening in db
Keenan Brock
@kbrock
Mar 14 2018 19:49
aah - he did this for kernel. merged kernel traces and java together. cool stuff
Nick LaMuro
@NickLaMuro
Mar 14 2018 20:34
yeah, this is on a single system, so wouldn't work for an external DB. Would show up as IO wait though
Keenan Brock
@kbrock
Mar 14 2018 21:47
@NickLaMuro thnx for evm:server_status tests
Nick LaMuro
@NickLaMuro
Mar 14 2018 21:50
Heh, I think I was supposed to follow that change up with a refactoring to make it more testable... oops
Keenan Brock
@kbrock
Mar 14 2018 22:03
well. refactoring it and changing output now
hope you don't have a branch in progress
the server/worker status methods now return arrays (not puts)
am running into 1 issue
I have a method that will not output data if it is the same for every row. feels like a pain to test :(
Nick LaMuro
@NickLaMuro
Mar 14 2018 22:06

well. refactoring it and changing output now

That is exactly how I was thinking of approaching it, but don't have a branch in progress, so :clap:

Keenan Brock
@kbrock
Mar 14 2018 22:06
so do I make refactor
the puts tests pass
then change the puts tests to just test the arrays return correctly? (swap out the puts)
so basically, we ignore what gets printed out to the screen - just test the arrays got put together correctly (before tablelize)
Nick LaMuro
@NickLaMuro
Mar 14 2018 22:14

so do I make refactor

assuming this is a question... if you are in there doing something entirely different, and trying to cram the refactor in the for kicks, I would advise waiting on the refactor. If the refactor is a part of what you are working on and you just strengthening the tests at the same time, I think it is fine to do it.