These are chat archives for ManageIQ/manageiq/performance
Okay... can someone tell me if I am missing something here or this is wrong:
In the case that code path is hit, does that mean that
#build_table is called twice then (redundantly)??
git blameof that stuff
So... I guess this is the "Shi... stuff Nick finds in
MiqReport" day, but is this line not needed any more?
Basically, looks like when it was useful was when prior to commit
e8dcb780ecbba2d2e9ace20fe39936c5648d38ff (sorry non-cfme devs, you can't see this), before the pivot stuff was being introduced. But now, because of how Ruport's code works, basically we are just cloning the
Ruport::Data::Table object with the exact same columns we defined it with in the line above...
Somewhat in response the previous conversation from above, I spent some time today refactoring the
MiqReport::Generator#_generate_table method here:
Part of what is included is removing the extraneous