These are chat archives for ManageIQ/manageiq/performance

17th
Jan 2019
Joe Rafaniello
@jrafanie
Jan 17 15:23
@NickLaMuro @kbrock FYI, join_keys arity changed in rails 5.1. I had to rebase and make the same change to a new join_keys added over the past few weeks https://github.com/ManageIQ/manageiq/pull/18076/commits/159a8a2715b2618b9275fef7352afe846578c938
for now, I'm just making the 5.1 branch use the 5.1 arity but we could probably make this version agnostic if we wanted this commit on master...for now, it's been easier to just keep the 5.1 branch clean
Keenan Brock
@kbrock
Jan 17 15:40
can probably delete preload_and_scope (I love the method, but never took hold)