Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
Halász Dávid
@skateman
oh, they released a new version of file-selector
and it's probably not compatible with the react-dropzone
Halász Dávid
@skateman
CI is broken again, the fix is here ManageIQ/manageiq#20728
Joe Rafaniello
@jrafanie
merged, you should be able to kick your PRs now
Halász Dávid
@skateman
@jrafanie thanks
Daniel Berger
@djberg96
anyone know if we strip whitespace in text boxes for ssh keys?
Jason Frey
@Fryguy
that's a good question
Nick LaMuro
@NickLaMuro
is this somehow related to what I am talking about in https://gitter.im/ManageIQ/manageiq-providers-embedded_ansible ?
Daniel Berger
@djberg96
@NickLaMuro yeah, i saw that, and remembered that i ran into it, too, at some point
not long ago, actually, but can't remember the context now
probably when we were dealing with the openssl 1.0 vs 1.1 stuff
Martin Hradil
@himdel
we did do that in the angular code, hopefully it made it to the ddf version
Nick LaMuro
@NickLaMuro
well, then that isn't good, since OPENSSH keys require a newline at the end
Jason Frey
@Fryguy
wonder if we can just detect that when saving the key and ensure it has one at the end
Martin Hradil
@himdel
well, it's probably still better to trim + add a new line than not to trim at all
Jason Frey
@Fryguy
something like... key = key.strip << "\n"
haha yeah that
Martin Hradil
@himdel
yeah :)
Nick LaMuro
@NickLaMuro
I get squeamish when trying to edit a SSH key to "what they probably wanted"...
tina
@tinaafitz
Thanks @djberg96, we confirmed that that is the case.
An OPENSSH private key used as a machine credential in Cloudforms needs the newline.
Martin Hradil
@himdel
@NickLaMuro well, I wouldn't trim it if we're uploading a file, but if this is copypasted into a textarea, all bets (or indeed newlines) are off
Jason Frey
@Fryguy
IMO since we can't know what a user is going to type (they could put multiple newlines at the end for all we know), we should account for known issues
at least for the copy-pasted ones...I agree on uploaded files we shouldn't do anything
Daniel Berger
@djberg96
@tinaafitz I couldn't remember
tina
@tinaafitz
I don’t know what the criteria is for different types of keys, but the OPENSSH private key needs the new line. I’m going to ask @mzazrivec to check out the Ansible credential page to see when the behavior changed.
tina
@tinaafitz
We have a customer that can't run playbooks at all because of the missing newline. Please let me know if there’s anything I can do to help with this.
Milan Zázrivec
@mzazrivec
@tinaafitz is there a bz report I can look at?
Nick LaMuro
@NickLaMuro
Jason Frey
@Fryguy
As I said, easiest fix is to just ensure the newline when we save the SSH key in the model
Nick LaMuro
@NickLaMuro

and I humbly disagree, as the number of newlines at the end of the key actually does not matter

but in some cases, at least one IS required

tina
@tinaafitz
Thanks @NickLaMuro @Fryguy. @mzazrivec and I just discussed the issue. He’s going to look at in the morning.
Milan Zázrivec
@mzazrivec
:thumbsup:
Nick LaMuro
@NickLaMuro
changed my tune, since it seems like you can have any number of newlines at the end of a key in either the RSA or OPENSSH formats, so going to quickly put together a PR in the backend to ensure a newline exists
(basically tested by doing a bunch of echo "" >> ~/.ssh/id_rsa calls and trying a git clone with a test key)
Nick LaMuro
@NickLaMuro
I'm excited about this and want to merge asap
Franklin-lab
@Franklin-lab
Hello...Can anyone share the best practice deployment guide for policies?
Franklin-lab
@Franklin-lab
Can anyone tell me how many compliances like PCI, HIPAA, FISMA supported by Cloudform?
Andrey Menezes
@AndreyMenezes
Hi guys, I'm trying to customizing the UI. When I run bundle exec rake assets:precompile I get
[root@cfme1 vmdb]# rake assets:precompile --trace
** Invoke assets:precompile (first_time)
** Invoke assets:environment (first_time)
** Execute assets:environment
** Invoke environment (first_time)
** Execute environment
** Execute assets:precompile
rake aborted!
Sprockets::FileNotFound: couldn't find file '@manageiq/ui-components/dist/css/ui-components' with type 'text/css'
Checked in these paths:
  /var/www/miq/vmdb/productization/assets/images
  /var/www/miq/vmdb/productization/assets/stylesheets
Jason Frey
@Fryguy

Can anyone tell me how many compliances like PCI, HIPAA, FISMA supported by Cloudform?

Hi @Franklin-lab, we don't have many policies out of the box, but since you can write whatever policy you want and group them how you want, you can create your own PCI, HIPAA, and FISMA policy profiles

I'm not sure what you mean by "best practice deployment guide"
but a lot of people do things like put policies on their hosts, then mark those as inheritable to their VMs...so, for example, they tag a host as Production, then put some policy profile on it, then every new VM on that host will automatically inherit those policies
otherwise you can do things like write some automation on a vm creation event where it can apply a policy, then do an immediate smartstate/compliance run.
Franklin-lab
@Franklin-lab
Thanks Jason
Halász Dávid
@skateman
CI is broken ManageIQ/manageiq-ui-classic#7494 <- this is the fix
Halász Dávid
@skateman
I am rewriting the Advanced Settings form to React and need some help with testing ManageIQ/manageiq-ui-classic#7498
Nick LaMuro
@NickLaMuro

Could someone with merge rights take a look at merging this when they have a chance? ManageIQ/manageiq-ui-classic#7508

(specs only change)