Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Brett Thurber
@bthurber
@Yadnyawalkya @dmetzger57 ManageIQ/manageiq-content#417 was unbackported for 5.9.5 and the agreement was this feature would land in 5.10.
Fabien Dupont
@fdupont-redhat
@bthurber @Yadnyawalkya @dmetzger57 The right-size feature implementation relies on ManageIQ/manageiq-content#418, which has been merged but the associated BZ (1594196) is targeted for 5.10. So it was decided to align ManageIQ/manageiq-content#417 on the same target, i.e. Hammer, and so it was un-backported for consistency.
Dennis Metzger
@dmetzger57
For my clarity, is known that migrations work with the “un-merge” changes, or will we not know until 5.9.5 is built and in QE?
Brett Thurber
@bthurber
@dmetzger57 we will need to QE it
Yadnyawalkya Tale
@Yadnyawalkya
Will check this thing in next 5.9 build and let you folks know if that un-backported thing works or not
@bthurber @fdupont-redhat ack, thanks for clearing this.
Yadnyawalkya Tale
@Yadnyawalkya
Update: running migrations on 5.10.0.19 (latest 5.10.z) and migration works very well with right size changes. @fdupont-redhat +1
Fabien Dupont
@fdupont-redhat
Thanks @Yadnyawalkya
Yadnyawalkya Tale
@Yadnyawalkya
Update: running migration on 5.9.5.2 and migration works well without right size changes
that means un-backporting worked, thanks @simaishi @fdupont-redhat +1
smallamp
@smallamp
@Yadnyawalkya that’s a relief.. thanks for the update
Aparna Karve
@AparnaKarve
Screen Shot 2018-10-17 at 7.41.31 AM.png
Kedar Kulkarni
@kedark3
@AparnaKarve @michaelkro @vconzola UI Question
why was the "Infrastructure Mapping Wizard" renamed to "Create Infrastructure Mapping"
?
just curios
Aparna Karve
@AparnaKarve
@kedark3 we did that to be able to distingush if the Wizard is in Create mode or Edit mode
in the Edit mode, you should see the title as “Edit Infrastructure Mapping"
Kedar Kulkarni
@kedark3
got it
thanks
will those changes be backported to 5.9 ? any idea?
cause I need to update automation to fit that
If not backported, I need to pick correct title based on version of appliance
Aparna Karve
@AparnaKarve
they wont be because we are not going to support Edit in 5.9
Michael Ro
@michaelkro
While we have your attention, as a heads up, we just merged a PR that adds the new Infra Mappings section
Kedar Kulkarni
@kedark3
got it
which section Michael
Michael Ro
@michaelkro
we moved the Infra Mappings ListView from the Overview page to its own page. There will be a new vert nav item
Kedar Kulkarni
@kedark3
it will be in next 5.10 build right?
Michael Ro
@michaelkro
correct
Kedar Kulkarni
@kedark3
got it thanks
Michael Ro
@michaelkro
well, it's not backported yet
but it will be there soon :)
Kedar Kulkarni
@kedark3
QE is right now swamped with testing, but will try to find time to update the code ... depending on how major/minor refactoring is needed
Michael Ro
@michaelkro
yes, I can imagine you guys are busy :) I just wanted to give you a heads up that the change is incoming
Kedar Kulkarni
@kedark3
that does help
thanks :)
Brett Thurber
@bthurber
@roliveri this PR wil need review and merge before the next alpha build tomorrow. ManageIQ/manageiq-content#441 Would you mind helping to locate a reviewer?
James Wong
@jameswnl
GregM has assigned Tina/Madhu to review that @bthurber
Brett Thurber
@bthurber
^^^sounds good. Thanks!
James Wong
@jameswnl
:ok_hand:
Greg McCullough
@gmcculloug
11 Commits. 60 Files changed and +1,061 −1,745 and you need it merged for tomorrow?
Note: The wip label was only removed 2 hours ago. :sweat:
Adam Grare
@agrare
more deletions than additions? LJ would probably merge it as is :laughing:
Brett Thurber
@bthurber
@gmcculloug this was the big change in code that we were waiting on for OSP support; QE is on standby to start testing
Brett Thurber
@bthurber
from my understanding it was a large refactoring moving code from autmate to the backend
cleaning up a lot of workaround automate code for GA
Jason Frey
@Fryguy
:running: good luck @gmcculloug :four_leaf_clover:
Greg McCullough
@gmcculloug
refactoring :+1: cleaning up a lot of workaround automate code :+1: large :-1: review and merge by tomorrow :frowning:
Dennis Metzger
@dmetzger57
Can we not just take these changes for Tuesday’s Beta 1 build? One less build, more time to review / merge. I believe QE has plenty to test with this weeks build already. Rushing review on this big a change is probably risky