by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Kedar Kulkarni
@kedark3
why was the "Infrastructure Mapping Wizard" renamed to "Create Infrastructure Mapping"
?
just curios
Aparna Karve
@AparnaKarve
@kedark3 we did that to be able to distingush if the Wizard is in Create mode or Edit mode
in the Edit mode, you should see the title as “Edit Infrastructure Mapping"
Kedar Kulkarni
@kedark3
got it
thanks
will those changes be backported to 5.9 ? any idea?
cause I need to update automation to fit that
If not backported, I need to pick correct title based on version of appliance
Aparna Karve
@AparnaKarve
they wont be because we are not going to support Edit in 5.9
Michael Ro
@michaelkro
While we have your attention, as a heads up, we just merged a PR that adds the new Infra Mappings section
Kedar Kulkarni
@kedark3
got it
which section Michael
Michael Ro
@michaelkro
we moved the Infra Mappings ListView from the Overview page to its own page. There will be a new vert nav item
Kedar Kulkarni
@kedark3
it will be in next 5.10 build right?
Michael Ro
@michaelkro
correct
Kedar Kulkarni
@kedark3
got it thanks
Michael Ro
@michaelkro
well, it's not backported yet
but it will be there soon :)
Kedar Kulkarni
@kedark3
QE is right now swamped with testing, but will try to find time to update the code ... depending on how major/minor refactoring is needed
Michael Ro
@michaelkro
yes, I can imagine you guys are busy :) I just wanted to give you a heads up that the change is incoming
Kedar Kulkarni
@kedark3
that does help
thanks :)
Brett Thurber
@bthurber
@roliveri this PR wil need review and merge before the next alpha build tomorrow. ManageIQ/manageiq-content#441 Would you mind helping to locate a reviewer?
James Wong
@jameswnl
GregM has assigned Tina/Madhu to review that @bthurber
Brett Thurber
@bthurber
^^^sounds good. Thanks!
James Wong
@jameswnl
:ok_hand:
Greg McCullough
@gmcculloug
11 Commits. 60 Files changed and +1,061 −1,745 and you need it merged for tomorrow?
Note: The wip label was only removed 2 hours ago. :sweat:
Adam Grare
@agrare
more deletions than additions? LJ would probably merge it as is :laughing:
Brett Thurber
@bthurber
@gmcculloug this was the big change in code that we were waiting on for OSP support; QE is on standby to start testing
Brett Thurber
@bthurber
from my understanding it was a large refactoring moving code from autmate to the backend
cleaning up a lot of workaround automate code for GA
Jason Frey
@Fryguy
:running: good luck @gmcculloug :four_leaf_clover:
Greg McCullough
@gmcculloug
refactoring :+1: cleaning up a lot of workaround automate code :+1: large :-1: review and merge by tomorrow :frowning:
Dennis Metzger
@dmetzger57
Can we not just take these changes for Tuesday’s Beta 1 build? One less build, more time to review / merge. I believe QE has plenty to test with this weeks build already. Rushing review on this big a change is probably risky
Brett Thurber
@bthurber
@dmetzger57 per our email thread earlier this week QE wanted to get the bits as-soon-as possible. This specific question came up. @smallamp responded he would like to have them in an alpha build for tomorrow. If beta 1 makes more sense I am fine with that if QE acks.
Dennis Metzger
@dmetzger57
What wasn’t clear (at least not to me) was the scale of change, hence my hesitation now. If folks think the can thoroughly review and have any comments addressed by tomorrow I’m OK, just raising a flag.
smallamp
@smallamp
@dmetzger57 @bthurber I agree.. If we are not ready yet with changes/reviews, there is no point cutting the build.. Would rather take a beta build that has gone thru thorough reviews and tests than a rushed up alpha build..
Brett Thurber
@bthurber
@dmetzger57 +1. @gmcculloug if you feel we need a few extra days we will go with that. @smallamp :thumbsup:
Greg McCullough
@gmcculloug
I haven't not had a chance to look at the PR much more then basic stats and assigning it. I'll make sure Tina/Madhu get some time on it today, but Madhu is almost fully committed to Service Portal work and is on PTO starting next Wed so I need to get some items from him for that project. Either way, if we request changes I assume @fdupont-redhat will work on them for tomorrow and we will need to review those as well. On top of that I'm taking PTO tomorrow.
Brett Thurber
@bthurber
ack...he will be available if/when issues come up during review. Beta 1 is critical for us to hit. If we miss that we move to red and are at risk for 1.1 GA.
Kedar Kulkarni
@kedark3
@michaelkro https://10.8.196.109/migration#/ @AparnaKarve
stalled migration
Michael Ro
@michaelkro
taking a look, thanks KK :)
Kedar Kulkarni
@kedark3
its stuck in Pre-migration Status: Acquire Transformation Host
for 1 hour +
Michael Ro
@michaelkro
@kedark3, when I open the mapping wizard, it looks like the target cluster does not have a conversion host configured
Kedar Kulkarni
@kedark3
yes