by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Brett Thurber
@bthurber
@roliveri this PR wil need review and merge before the next alpha build tomorrow. ManageIQ/manageiq-content#441 Would you mind helping to locate a reviewer?
James Wong
@jameswnl
GregM has assigned Tina/Madhu to review that @bthurber
Brett Thurber
@bthurber
^^^sounds good. Thanks!
James Wong
@jameswnl
:ok_hand:
Greg McCullough
@gmcculloug
11 Commits. 60 Files changed and +1,061 −1,745 and you need it merged for tomorrow?
Note: The wip label was only removed 2 hours ago. :sweat:
Adam Grare
@agrare
more deletions than additions? LJ would probably merge it as is :laughing:
Brett Thurber
@bthurber
@gmcculloug this was the big change in code that we were waiting on for OSP support; QE is on standby to start testing
Brett Thurber
@bthurber
from my understanding it was a large refactoring moving code from autmate to the backend
cleaning up a lot of workaround automate code for GA
Jason Frey
@Fryguy
:running: good luck @gmcculloug :four_leaf_clover:
Greg McCullough
@gmcculloug
refactoring :+1: cleaning up a lot of workaround automate code :+1: large :-1: review and merge by tomorrow :frowning:
Dennis Metzger
@dmetzger57
Can we not just take these changes for Tuesday’s Beta 1 build? One less build, more time to review / merge. I believe QE has plenty to test with this weeks build already. Rushing review on this big a change is probably risky
Brett Thurber
@bthurber
@dmetzger57 per our email thread earlier this week QE wanted to get the bits as-soon-as possible. This specific question came up. @smallamp responded he would like to have them in an alpha build for tomorrow. If beta 1 makes more sense I am fine with that if QE acks.
Dennis Metzger
@dmetzger57
What wasn’t clear (at least not to me) was the scale of change, hence my hesitation now. If folks think the can thoroughly review and have any comments addressed by tomorrow I’m OK, just raising a flag.
smallamp
@smallamp
@dmetzger57 @bthurber I agree.. If we are not ready yet with changes/reviews, there is no point cutting the build.. Would rather take a beta build that has gone thru thorough reviews and tests than a rushed up alpha build..
Brett Thurber
@bthurber
@dmetzger57 +1. @gmcculloug if you feel we need a few extra days we will go with that. @smallamp :thumbsup:
Greg McCullough
@gmcculloug
I haven't not had a chance to look at the PR much more then basic stats and assigning it. I'll make sure Tina/Madhu get some time on it today, but Madhu is almost fully committed to Service Portal work and is on PTO starting next Wed so I need to get some items from him for that project. Either way, if we request changes I assume @fdupont-redhat will work on them for tomorrow and we will need to review those as well. On top of that I'm taking PTO tomorrow.
Brett Thurber
@bthurber
ack...he will be available if/when issues come up during review. Beta 1 is critical for us to hit. If we miss that we move to red and are at risk for 1.1 GA.
Kedar Kulkarni
@kedark3
@michaelkro https://10.8.196.109/migration#/ @AparnaKarve
stalled migration
Michael Ro
@michaelkro
taking a look, thanks KK :)
Kedar Kulkarni
@kedark3
its stuck in Pre-migration Status: Acquire Transformation Host
for 1 hour +
Michael Ro
@michaelkro
@kedark3, when I open the mapping wizard, it looks like the target cluster does not have a conversion host configured
Kedar Kulkarni
@kedark3
yes
so migration should ideally notice it and fail
because that is what used to happen in previous builds
Michael Ro
@michaelkro
is that possibly an automate thing? The UI changes state depending on the status of each plan request
Kedar Kulkarni
@kedark3
@michaelkro I'll file a bz
Michael Ro
@michaelkro
I'll take a look at the data and see if I see anything out of place
Kedar Kulkarni
@kedark3
yes let me know if you find anything specific
Michael Ro
@michaelkro
will do. Looking now :)
Kedar Kulkarni
@kedark3
thanks a lot :)
Michael Ro
@michaelkro
@kedark3 it looks like cancellation was requested for the plan named plan_2COTLJiUTg
was it supposed to stop migration?
Kedar Kulkarni
@kedark3
yes I requested that after first 5 mins of watching it trying to acquire the host
Michael Ro
@michaelkro
hmm, that's not good
was this the first and only time this plan has been run?
Kedar Kulkarni
@kedark3
started two more plans to see if it gets stuck same way
1 failed, 1 going on
asdetrewt
Michael Ro
@michaelkro
interestingly, there are two requests for plan_2COTLJiUTg
Aparna Karve
@AparnaKarve
both in-progress plans have 2 requests each. The most recent request (which is currently being executed) for each plan has an empty tasks array
Kedar Kulkarni
@kedark3
can you check asdetrewt ??
that is latest, just started, cancel operation is not requested unlike other two
Michael Ro
@michaelkro
that one only has one
I wonder if this is the change that is causing it to stall
message: "State5 is not finished yet [13/86400 retries]."
how long does each retry take?