Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 30 03:03
    RickStrahl commented #977
  • Sep 29 03:41
    zhouxinghong closed #979
  • Sep 29 03:41
    zhouxinghong closed #980
  • Sep 29 03:40
    zhouxinghong closed #982
  • Sep 29 00:19
    zhouxinghong opened #982
  • Sep 28 23:41
    zhouxinghong commented #980
  • Sep 28 23:33
    zhouxinghong commented #980
  • Sep 28 23:27
    zhouxinghong commented #980
  • Sep 28 23:25
    zhouxinghong commented #980
  • Sep 28 23:21
    zhouxinghong commented #979
  • Sep 28 23:06
    RickStrahl labeled #980
  • Sep 28 23:06
    RickStrahl commented #980
  • Sep 28 22:50
    zhouxinghong commented #980
  • Sep 28 21:21
    RickStrahl commented #980
  • Sep 28 21:15
    RickStrahl labeled #979
  • Sep 28 21:15
    RickStrahl commented #979
  • Sep 28 17:52
    RickStrahl commented #981
  • Sep 28 17:51
    RickStrahl closed #981
  • Sep 28 17:51
    RickStrahl commented #981
  • Sep 28 13:38
    CheetahChrome edited #981
Rick Strahl
@RickStrahl
BTW, thanks for the PRs. Nice little additions.
Alex Wiese
@alexwiese
no problem thanks for building a great markdown editor
Rick Strahl
@RickStrahl
I know you already paid for your copy, but you would have definitely qualified for a free license :-)
Not done yet :-) Lots of things still to do.
Alex Wiese
@alexwiese
Always
Rick Strahl
@RickStrahl
Anyway just want to say I appreciate the contributions. Getting those little things done helps out a lot.
And... hopefully once a few PR's are in the bag, a few others may get involved as well.
Alex Wiese
@alexwiese
yes, exactly
Rick Strahl
@RickStrahl
Gary you got a couple of minutes for questions? :-)
Gary Ewan Park
@gep13
@rickstahl sorry, went to bed not long after last comment on issue. Will be around today if you still want to chat.
Rick Strahl
@RickStrahl
Ok that'd be cool. I think I have the portable setup all figured out. Almost ready to push it up.
Gary Ewan Park
@gep13
Is the work checked into the repo already? Happy to review prior to you pushing it out if you want?
Rick Strahl
@RickStrahl
Couple of questions
verify.txt what needs to go in there?
I don't think there's anything to see. The .ps1 is empty with all the distribution files in the .\tools folder (copied by the build process)
I have this in verify.txt:
MarkdownMonster.exe
Sha256: 3A39D79914EFD3B21BCD24F6794464F4904E4F17F23F67F414283E844945CCA1
Do I even need that if I push up the files embedded in there?
blob
Gary Ewan Park
@gep13
Since you are embedding, and due to the fact that you are a known maintainer for your own packages, the verify.txt and checksums are not required.
Ideally, there would still be a license file in the chocolatey package though
Rick Strahl
@RickStrahl
Ah Ok.
adding license.txt and removing verify.txt.
Anything I need to do with the uninstall file (other than remove comments). It seems to work without any changes made.
Gary Ewan Park
@gep13
If the literally have nothing in the chocolateyinstall.ps1 file, then simply omit that, and as a result, you won't need the chocolateyuninstall.ps1 file either
Rick Strahl
@RickStrahl
Does that even need to be there? Chocolatey will just wipe out the folder right?
Yeah that's what I thought because the contents of that file wouldn't work anyway. Cool. Less is good :-)
Gary Ewan Park
@gep13
Yip, if it is an embedded package, with just contents, Chocolatey will wipe out the folder on uninstallation. It is only if you do additional steps in the install.ps1 file, that you would need to undo these in the uninstall.ps1
Rick Strahl
@RickStrahl
Can i omit the chocolateyinstall.ps1 file too then?
Gary Ewan Park
@gep13
If the literally have nothing in the chocolateyinstall.ps1 file, then simply omit that
Rick Strahl
@RickStrahl
FWIW, I haven't been able to find the docs on any of this. It may be there but I can't find the docs for an embedded install.
Gary Ewan Park
@gep13
:point_up:
@RickStrahl see my comment in the issue :-)
Rick Strahl
@RickStrahl
Not that it matters so much now :-)
Rick Strahl
@RickStrahl
So, there's nothing much left of my build script now that I don't need all these files:
# Script builds a Chocolatey Package and tests it locally
# 
#  Assumes: Uses latest release out of Pre-release folder
#           Release has been checked in to GitHub Repo
#   Builds: ChocolateyInstall.ps1 file with download URL and sha256 embedded

cd "$PSScriptRoot" 

remove-item ".\tools" -recurse -force

# $sourceFolder = "..\Distribution" 
# $file = "$sourceFolder\MarkdownMonster.exe"
# write-host $file

# $sha = get-filehash -path "$file" -Algorithm SHA256  | select -ExpandProperty "Hash"
# write-host $sha

robocopy $sourceFolder .\tools /MIR
copy ..\license.txt .\tools\license.txt

#empty install file - we just have content no code
#$filetext = ""
#out-file -filepath .\tools\chocolateyinstall.ps1 -inputobject $filetext

# uninstall script
# copy chocolateyuninstall.ps1 .\tools

#$filetext = @"
#MarkdownMonster.exe
#Sha256: $sha
#"@
# out-file -filepath .\tools\verify.txt -inputobject $filetext

del *.nupkg

# Create .nupkg from .nuspec
choco pack

choco uninstall "MarkdownMonster.Portable"

choco install "MarkdownMonster.Portable" -fdv -y  -s ".\"
Thanks for your help.
As a nice side effect I looked a lot closer at running the portable version and found a few more little things that weren't working right that got fixed (like missing icons) and a few other UI quiks.
:+1:
Gary Ewan Park
@gep13
you know, if you wanted, you could embed the exe into this package as well: https://chocolatey.org/packages/MarkdownMonster rather than first downloading it as well, that would also save the need for the checksums :-D
Rick Strahl
@RickStrahl
So I pushed it up markdownmonster.portable
It looks like it made it but choco push is totally hung.
I remember this happened with the previous version as well. Console is dead I have to shut it down.
blob
eventually returned. It says it's timed out, but the package is up on choco.
Rick Strahl
@RickStrahl
The checksums aren't a big problem since those are auto-generated as part of the build process and embedded into the choco script. Main thing I don't like is that the upload takes a while and apparently hangs a lot of the time.
Rick Strahl
@RickStrahl
Hmmm... so looks like the uninstall isn't working:
blob
Gary Ewan Park
@gep13
hmm, that looks like a question for @ferventcoder