Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Domino987
    @Domino987
    Happy new year from Germany guys;)
    Naim Bouallagui
    @naimbouallagui
    Happy new year from tunisia
    Matt Oestreich
    @oze4
    happy new year from Texas!
    Chad
    @MrWittman612
    I would like to contribute to this repo, I am self-taught and have been coding for two years now and this would be the first open-source project I would be contributing to. I am not sure how to proceed, do I clone the repo make a branch, and submit a pull request? or fork the repo and make a branch, make my changes then sent a merge request? I have already forked mbrn's repo, but do I want to fork material table core?
    Chad
    @MrWittman612
    OK so I just cloned the core repo. Does it matter if I initialize with npm or yarn? and I do have experience with storybook but
    I would like to contribute in any way that would be helpful.
    Domino987
    @Domino987
    Hi Welcome to have you on board. You should fork it, create s branch, merge your changes and open a PR from that branch to the main repo. We will review it and when it is acceptable, we will merge it.
    The core still needs npm but the next repo can be used with both.
    I think the main objectives are currently porting the next repo to typescript and to function components. Do you know ts?
    Chad
    @MrWittman612
    No but I can learn
    when I try and fork core it says that I have all ready fork the main version?
    Domino987
    @Domino987
    @MrWittman612 Thats not a problem, you will either learn it in time here or just do logic stuff e.g. So if it says that you have already forked it, you can just navigate to your fork and clone it to your machine, create a branch and make your changes. So for a start do you want convert one of the cells to function compoennts? and add them to next, after that I will merge them to ts?
    Naim Bouallagui
    @naimbouallagui
    @Domino987 i've forked the repo (material-table-core/core) and i want to contribute ! i'm already learning typescript but i know as well how to work with class and function component , how can i start? and which one should i fix?
    Domino987
    @Domino987
    @naimbouallagui Nice, welcome. Maybe port the toolbar to ts and function component?
    Naim Bouallagui
    @naimbouallagui
    @Domino987 Cool , i will check and start doing it
    Domino987
    @Domino987
    To track who is doing what, can you move the components you are working on to the appropriate columns. Maybe with name too? https://github.com/material-table-core/next/projects/1
    B.Mady
    @balanka
    Naim Bouallagui
    @naimbouallagui
    @Domino987 yes will do it, @balanka cool :)
    QP
    @theqp
    if you use intellij idea it can do it automatically if it has no state
    B.Mady
    @balanka
    @theqp really? I am using IntelliJ. Let me check that
    Naim Bouallagui
    @naimbouallagui
    sorry im using vscode :(
    B.Mady
    @balanka
    @theqp How to convert class to FC using IntelliJ I don't see any such option under refactoring in IntelliJ IDEA?
    QP
    @theqp
    @balanka alt+enter on classname
    B.Mady
    @balanka
    @theqp Great!!!! it works only for classes without state.
    Domino987
    @Domino987
    Ok i moved the cell to ts and FC, so if you are stuck you can take that as a guide too
    6 replies
    Chad
    @MrWittman612
    @Domino987 when you're available reach out to me. I have converted most of the code in src to functional components but I would like to go over the code with you. here is a link to the repo and branch I'm working on https://github.com/MrWittman612/core/tree/M-table-refactor
    B.Mady
    @balanka
    Hi all
    I ported and tested all but one (m-table-body-row.js ) components from class to FC see https://github.com/balanka/core
    I converted m-table-body-row.js also from class to FC but it is not working i am observing some errors.
    B.Mady
    @balanka
    I still have to check in m-table-body-row.js if any body want to have a look
    Naim Bouallagui
    @naimbouallagui
    @balanka do you face the error of duplication renderColumns ?
    B.Mady
    @balanka
    Here is the stacktrace
    react-beautiful-dnd.esm.js:175 Uncaught TypeError: renderColumns is not a function at render (m-table-body-row.js:310) at MTableBodyRow (m-table-body-row.js:448) at renderWithHooks (react-dom.development.js:14985) at mountIndeterminateComponent (react-dom.development.js:17811) at beginWork (react-dom.development.js:19049) at HTMLUnknownElement.callCallback (react-dom.development.js:3945) at Object.invokeGuardedCallbackDev (react-dom.development.js:3994) at invokeGuardedCallback (react-dom.development.js:4056) at beginWork$1 (react-dom.development.js:23959) at performUnitOfWork (react-dom.development.js:22774) render @ m-table-body-row.js:310 MTableBodyRow @ m-table-body-row.js:448 renderWithHooks @ react-dom.development.js:14985 mountIndeterminateComponent @ react-dom.development.js:17811 beginWork @ react-dom.development.js:19049 callCallback @ react-dom.development.js:3945 invokeGuardedCallbackDev @ react-dom.development.js:3994 invokeGuardedCallback @ react-dom.development.js:4056 beginWork$1 @ react-dom.development.js:23959 performUnitOfWork @ react-dom.development.js:22774 workLoopSync @ react-dom.development.js:22702 renderRootSync @ react-dom.development.js:22665 performSyncWorkOnRoot @ react-dom.development.js:22288 scheduleUpdateOnFiber @ react-dom.development.js:21876 updateContainer @ react-dom.development.js:25477 eval @ react-dom.development.js:26016 unbatchedUpdates @ react-dom.development.js:22426 legacyRenderSubtreeIntoContainer @ react-dom.development.js:26015 render @ react-dom.development.js:26098 eval @ demo.js:662 ./demo/demo.js @ bundle.js:2954 __webpack_require__ @ bundle.js:9038 (anonymous) @ bundle.js:10175 (anonymous) @ bundle.js:10178 material-table.js:671 Uncaught TypeError: Cannot read property 'scrollWidth' of null at MaterialTable.componentDidMount (material-table.js:671) at commitLifeCycles (react-dom.development.js:20658)
    at commitLayoutEffects (react-dom.development.js:23421)
    at HTMLUnknownElement.callCallback (react-dom.development.js:3945)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:3994)
    at invokeGuardedCallback (react-dom.development.js:4056)
    at commitRootImpl (react-dom.development.js:23146)
    at unstable_runWithPriority (scheduler.development.js:646)
    at runWithPriority$1 (react-dom.development.js:11276)
    at commitRoot (react-dom.development.js:22985)
    ```
    2 replies
    Naim Bouallagui
    @naimbouallagui
    @balanka check the call of renderColumns at the render if you still use class component
    B.Mady
    @balanka
    Just checked it in. I had checked many times.
    Naim Bouallagui
    @naimbouallagui
    @all i've converted the components to FC and this is my repo: https://github.com/naimbouallagui/core/tree/MTable-refactor
    B.Mady
    @balanka
    @naimbouallagui did you try to run the demo application using the command yarn start or equivalent ?
    Naim Bouallagui
    @naimbouallagui
    @balanka yeah and it works
    i just let the m-table-body-row as a class component
    B.Mady
    @balanka
    OK. leaving out m-table-body-row works. I thought you managed to successfully convert it to FC
    Chad
    @MrWittman612
    To whom it may concern, it seems that several of us have taken the challenge to convert the files in the src folder to functional components, and everyone seems to have some little variation of how they went about. I converted all but two, but put them all in one branch, and feel everyone of mine can be simplified further. instead of passing props I would like to destructor the props which I think will help when converting to type script I think, I don't have extensive experience with type script. I would like to break each file in src to a separate branch so I am not stepping on other peoples toes and more of use will get some credit on git for the work we've done. I would also like to have a consensus with the community about style guides as well as discuss breaking out of concerns, memorization, and wrapping a useCallback hook on some of the functions. I am on discord if any one wants to talk and share screens
    Naim Bouallagui
    @naimbouallagui
    @MrWittman612 is there a discord group of this community?
    Chad
    @MrWittman612
    no but it be good
    Naim Bouallagui
    @naimbouallagui
    yes will be good
    Chad
    @MrWittman612
    I got MTableBodyRow done the problem converting was the naming conflict with renderColumns turn into renderColumnsCopy
    5 replies
    Domino987
    @Domino987
    Hi, sorry was busy. How are we doing?
    Naim Bouallagui
    @naimbouallagui
    Hi @Domino987 i've sent a pull request of my work ( which contain a convert of components to FC) , and don't know which step after that !
    Domino987
    @Domino987
    @naimbouallagui hi ty but I do not see thee PR. Are you sure you created it to the base repo and not your own fork? Greatly appreciate 😊
    Naim Bouallagui
    @naimbouallagui
    @Domino987 i've push it into forked repo
    and create a PR to core/master
    Naim Bouallagui
    @naimbouallagui
    @Domino987 shel i open a new PR ? because conflicts are done
    Matt Oestreich
    @oze4
    I created a discord server here https://discord.gg/uMr8pKDu8n
    Naim Bouallagui
    @naimbouallagui
    Great
    Matt Oestreich
    @oze4