@moy We've always said "does not support JavaScript". But I wonder: could it support JavaScript? Almost certainly not within the scope of the tool, but I wonder how difficult it would be.
parsing for a redirect might be tricky esp. If there's two of them
Just find all the redirects and yeild them as an array of addresses?
I don't think we have anything built-in to add
<option>, but you can always do that via BeautifulSoup. Stg like https://www.crummy.com/software/BeautifulSoup/bs4/doc/#insert.
@hemberger: indeed, we should definitely make a new release, we haven't done so for a while. I'm hesitant between two scenarios: in an ideal world, we would finish MechanicalSoup/MechanicalSoup#185 (getter names) before the 1.0, so we could release a non-1.0 now. In this case, I'd make the release as-is, and merge MechanicalSoup/MechanicalSoup#290 (enctype stuff) afterwards, as it's not urgent and we can give it more testing time before including it in a release. But the getter names stuff hasn't really moved for almost 2 years, perhaps it's time to admit that we may not ever do it and release 1.0 without it, in which case I'd merge #290 before to get as much as possible in 1.0.
I'm OK with you doing the release, although I may get a bit of time to do it myself if needed.
@moy Sounds good. I've approved #185, so feel free to merge that in at any time (I'm happy with it in a 0.12 or 1.0 release). I think more discussion about how to implement the getters is warranted if we're going to add them, but to be honest I'm unlikely to proactively work on anything because I'm discouraged that we can't clean up the interface. I think there is a lot of room for improvement for the sake of all future users, but that we're hamstrung by backwards compatibility due to interface decisions that made sense in the past, but don't make sense today.
I'll let you make the decision about the release, but I'm happy to prepare it on your command! :)
I think #294 is "ready" (as in "you can review it and I hope you'll like it", not necessarily as "I don't expect any comment in review"), so we can wait for it to be merged before releasing 1.0. Perhaps this deserves a 1.0-pre1 or so before the actual 1.0 to draw a bit of attention from our users/testers before calling it 1.0, but we can also consider we're not such a huge and active and release 1.0 directly.
Like I did last year, I'll offer my students to contribute to MechanicalSoup as part of a school project, starting end of January. To help them, I need a handful of easy issues (to get started with the code, GitHub, ...), and a few medium-sized issues for the project itself.
#127 could be fun too.
I don't want to be rude towards beginners, but at this point this starts looking a lot like some kind of spam (maybe people trying to get contributions accepted to get links to their profile where they would later put links to commercial sites?)
I think it's fine if we politely close them, and maybe encourage them to contribute if they want to take a look at the "Help Wanted" tag.
this seems relevant: https://www.theregister.com/2020/10/01/digitalocean_hacktoberfest_pull_request_spam/
I've added a spam tag to the PRs.
hi.
I have a link that I want to follow:
I tried
do i have to resort to something as ugly as
I have a link that I want to follow:
<a href="foo"><span>SomeText</span></a>I tried
browser.follow_link(text=re.compile("SomeText")) but that doesn't find the link, presumably because the text is nested.do i have to resort to something as ugly as
browser.follow_link(browser.get_current_page().find(lambda el: el.name == "a" and "SomeText" in el.text)) or is there any decent alternative?
1 reply
also so strange, i'm using MechanicalSoup 0.12.0 but getting
AttributeError: 'StatefulBrowser' object has no attribute 'page' even though https://github.com/MechanicalSoup/MechanicalSoup/pull/294/files
oh i see MechanicalSoup/MechanicalSoup@a2c0c3c
so it's not released after all
so it's not released after all
this part could've been useful
https://github.com/MechanicalSoup/MechanicalSoup/blob/9c2a5b7e9/mechanicalsoup/stateful_browser.py#L277
but unfortunately I can't predict what whitespace there will be around the link's text
https://github.com/MechanicalSoup/MechanicalSoup/blob/9c2a5b7e9/mechanicalsoup/stateful_browser.py#L277
but unfortunately I can't predict what whitespace there will be around the link's text