The
MessagePackWriter should be a readonly struct
We can accept Spans in the method I think, but they can't be stack-allocated, by the description in the issue.
@Alxandr would you like to file an issue to track what you'd like to do and your suggestion that we make it a readonly struct? It looks like from a quick view of the type that it's not out of the question.
Cause I have to make sure to free them
Using statements is so much cleaner
These are all just general suggestions ... your suggestion to make the MessagePackWriter readonly is still a possibility.
I might do that
Ok, maybe I will post some issues.
@guitarrapc Thanks for the added permissions on the Azure Pipelines account. But I need one more thing: I need administrator permission on the Default agent pool in order to add an agent to it. https://dev.azure.com/ils0086/MessagePack-CSharp/_settings/agentqueues?queueId=1&view=security
never mind. I had permission to create a new pool so I did that.
Woot! It's working. We have Unity builds as part of CI/PR builds on Azure Pipelines. Yay.
https://dev.azure.com/ils0086/MessagePack-CSharp/_build/results?buildId=141
https://dev.azure.com/ils0086/MessagePack-CSharp/_build/results?buildId=141
But GitHub still only shows one status instead of two (1 for Windows and 1 for Unity). So both are building, but if either fails, the user will only see the one status failure instead of 1 pass and one fail. We can improve this by installing the Azure Pipelines GitHub App to the ils0086 account. @guitarrapc or @neuecc can either of you arrange that?
By the way, Could you revert this PR?
neuecc/MessagePack-CSharp#491
Page's first-view should show all the information.
Because users who does not know this lib(first visited users) see readme and does not click next pages.
We have to tell them the value of this library, forcefully.
Separated to many files are clean, but it is wothless.
Microsoft official library no need to think because microsoft-fans uses it without thinking.
But user created OSS is not.
Although this library is a latecomer and not to fluent in English, it is used by many people.
This is one of the reasons why I have successfully made OSS (I have 6 repositories of over 1000 stars).
Thanks for your reply, @neuecc. Yes, I'll merge docs back into the README. I tried to keep the sales pitch at the top of the README in anticipation of your concern that we "sell" the library on the first page, but I guess I didn't keep (nearly) enough.
Rather than revert the PR, I'll re-merge the docs, since amidst the PR I made a lot of small edits to update.
Question though: can you see room to leave (or in the future, create) any docs outside the README itself? The reason is I find it very hard to navigate the README with it so large. I find an index into documentation that is short and to the topic to read about much easier to parse.
Rather than revert the PR, I'll re-merge the docs, since amidst the PR I made a lot of small edits to update.
Question though: can you see room to leave (or in the future, create) any docs outside the README itself? The reason is I find it very hard to navigate the README with it so large. I find an index into documentation that is short and to the topic to read about much easier to parse.
I'll back day after tomorrow.
@neuecc did you have time to look at neuecc/MessagePack-CSharp#530 It would be a (minor) breaking change, so getting it before 2.0 would be really nice.
@neuecc Since it looks like we may not have an agreed upon stable API by the end of this week, but I think there's hope we can reconcile our goals, so I bought some more time. I also see a hard problem in my use case that can only be solved by truly supporting streaming deserialization (neuecc/MessagePack-CSharp#437). I may actually try to work that into v2 instead of postponing to some future v3 in order to avoid two sets of massively API breaking changes.
only Visual Studio, shows some error(but in Unity Editor works).
@hiradyazdan Utf8Json and MessagePack adopts similar architecture. When MessagePack architecture will stable, I'll back.
@neuecc you mean i can serialize json string to object and vice versa (not binaries/byte arrays) with messagepack too? i didn’t realize that! can you please point me to where and how i can do that? because wherever i looked there was nothing i could find in that regard. Or perhaps you mean the core is similar?