These are chat archives for Microsoft/CodeContracts

2nd
Jul 2015
Sam Harwell
@sharwell
Jul 02 2015 02:11
I understand. It's a minor issue and I'm quite sure it won't prevent these two contributors from returning. :smile:
Sergey Teplyakov
@SergeyTeplyakov
Jul 02 2015 02:16
I hope so:) We all learning.
Sam Harwell
@sharwell
Jul 02 2015 02:18
Learning and making progress. The best combination. The flight risk IMO would be @tom-englert, but I plan to personally make sure all his changes get merged after we get the community distribution figured out. Also his changes will be a good example for community people who want to work on additional contracts.
Sergey Teplyakov
@SergeyTeplyakov
Jul 02 2015 02:19
Sure! I'm glad that we're on the same page! I've push yet another change recently for #47. Working on unit test for that feature
hope that pretty soon every change or fix would have additional unit test for it
Sam Harwell
@sharwell
Jul 02 2015 02:20
agreed
for stylecopanalyzers I sometimes allow a change without a test (some people won't know how to make the test, or don't have time), but in those cases I ask that they file an issue to add the test. in general if the tests are easy to add then people tend to add them though :+1:
Sergey Teplyakov
@SergeyTeplyakov
Jul 02 2015 02:28
yep, agree. The same true for this project right now. I'm ok to accept the PR, but I need to test case that covers the fix.