These are chat archives for Microsoft/CodeContracts

13th
Jul 2015
Sam Harwell
@sharwell
Jul 13 2015 02:34
@jbcutting Are you referring to the behavior of custom analyzers?
If so, you must use the same version of Roslyn to build your analyzer as the build of Visual Studio you are using.
Sam Harwell
@sharwell
Jul 13 2015 02:47
@jbcutting I'm terrible sorry, for some reason I thought your comment was in the dotnet/roslyn Gitter room. I haven't noticed the behavior you describe with code contracts, but I also haven't spent as much time with it in Visual Studio 2015 as I feel like I need to.
jbcutting
@jbcutting
Jul 13 2015 03:46
Nope, definitely referring to Code Contracts. Messages and warnings still show up in the errors list window for me in VS2013, but not in VS2015. I see the expected results in the Output window, but they don't make it to the errors list.
Sergey Teplyakov
@SergeyTeplyakov
Jul 13 2015 04:31

@sharwell
@SergeyTeplyakov we need to review the formatting PRs before they are merged.
It helps to use better diff software, such as Beyond Compare for it

I'm in parental leave right now :) but hope to review those changes:)

Nope, definitely referring to Code Contracts. Messages and warnings still show up in the errors list window for me in VS2013, but not in VS2015. I see the expected results in the Output window, but they don't make it to the errors list.

I'm not using VS2015 right now as well. Lets double check and just open the issue.

@sharwell I hope to create a release with #134. Also I'll review and apply all formatting PRs.
If you would be able to fix some fixes for Editor Extension then we would be able to release them as well.
jbcutting
@jbcutting
Jul 13 2015 05:13
The only reason I haven't been using VS2015 up 'til now is the code contracts issues. :-) Unfortunately, I don't have another machine I can test this on, so I didn't want to submit an issue unless someone else can confirm it. If anyone else can confirm it, I'll submit it.
I've also seen the editor extension crash VS2015, but it's not consistent and I don't have repro steps yet.
jbcutting
@jbcutting
Jul 13 2015 05:20
Actually... one time, I saw the extension itself crash, VS2015 stayed up. However, VS2015 crashes consistently for me if I hover over a few method calls to get IntelliSense. The first one or two work, then it crashes. Every time. If I disable the Code Contracts Editor Extension, this does not occur. It works okay for me in VS2013.
Sam Harwell
@sharwell
Jul 13 2015 05:23
@jbcutting The crash that brings down VS2015 is almost certainly #116. Also, feel free to submit an issue that you aren't 100% sure of. Describe it as best you can and if we have problems reproducing it we'll let you know. As long as you take the time to separate your expected results from your actual results we can typically find a way to resolve it to your satisfaction. :smile:
jbcutting
@jbcutting
Jul 13 2015 05:26
I don't think the ones I hovered over were generic types or generic methods, but I can verify. It does seem likely that's the issue, though - there's a delay where the IDE seems to hang before the crash occurs, which could very well be a stack overflow.
tom-englert
@tom-englert
Jul 13 2015 15:12
@SergeyTeplyakov did you run the regression tests on the build machine? Do they succeed?
Sergey Teplyakov
@SergeyTeplyakov
Jul 13 2015 22:46
@tom-englert What buld machine and what tests? And what case?
I've lost the context, I guess...
Sam Harwell
@sharwell
Jul 13 2015 22:47
@SergeyTeplyakov since you are here, can you give an update on the status of the three editor extensions PRs I sent?
#116 is severe; you can't keep the extension installed or VS will frequently crash (not just a message box - actually terminates the process).