Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    jbcutting
    @jbcutting
    I've also seen the editor extension crash VS2015, but it's not consistent and I don't have repro steps yet.
    jbcutting
    @jbcutting
    Actually... one time, I saw the extension itself crash, VS2015 stayed up. However, VS2015 crashes consistently for me if I hover over a few method calls to get IntelliSense. The first one or two work, then it crashes. Every time. If I disable the Code Contracts Editor Extension, this does not occur. It works okay for me in VS2013.
    Sam Harwell
    @sharwell
    @jbcutting The crash that brings down VS2015 is almost certainly #116. Also, feel free to submit an issue that you aren't 100% sure of. Describe it as best you can and if we have problems reproducing it we'll let you know. As long as you take the time to separate your expected results from your actual results we can typically find a way to resolve it to your satisfaction. :smile:
    jbcutting
    @jbcutting
    I don't think the ones I hovered over were generic types or generic methods, but I can verify. It does seem likely that's the issue, though - there's a delay where the IDE seems to hang before the crash occurs, which could very well be a stack overflow.
    tom-englert
    @tom-englert
    @SergeyTeplyakov did you run the regression tests on the build machine? Do they succeed?
    Sergey Teplyakov
    @SergeyTeplyakov
    @tom-englert What buld machine and what tests? And what case?
    I've lost the context, I guess...
    Sam Harwell
    @sharwell
    @SergeyTeplyakov since you are here, can you give an update on the status of the three editor extensions PRs I sent?
    #116 is severe; you can't keep the extension installed or VS will frequently crash (not just a message box - actually terminates the process).
    Sergey Teplyakov
    @SergeyTeplyakov
    @sharwell Sorry. I've looked at it but didn't merge.
    done
    Sam Harwell
    @sharwell
    @SergeyTeplyakov Yay :clap:
    Sergey Teplyakov
    @SergeyTeplyakov
    I talked with Mike Barnett last week. He is out today, but would be available tomorrow. I can push new release on github and Mike can sign it and and publish officially
    Sam Harwell
    @sharwell
    You should also review and decide on #120 and #121 for the next release
    Sergey Teplyakov
    @SergeyTeplyakov
    I'll review and merge them today
    Done.
    tom-englert
    @tom-englert
    @SergeyTeplyakov I assumed there is a build machine - but maybe we don't have one.
    @SergeyTeplyakov When I open the solution, there are many tests shown in the test explorer. When I run the tests, may of them fail.
    Did someone else try to run those tests?
    Sergey Teplyakov
    @SergeyTeplyakov
    There is some tricks for running tests
    all Foxtrot tests are passing (and those are the tests for the area where I've made my changes)
    to run UnitTests (project name UnitTests) you have to select FoxtrotTestRun test settings first
    Unfortunately I was unable to fix them properly
    All clousot tests are never worked for me
    But all changes are for rewriter...
    Sam Harwell
    @sharwell
    @SergeyTeplyakov I changed my mind on the comment in #144. I didn't realize it would be so long until I typed it out.
    However, I do prefer "requires/ensures" to "pres/posts"
    Sam Harwell
    @sharwell
    @SergeyTeplyakov I'm working on an AppVeyor configuration -- the build is already working but now I'm working on the tests.
    I even got it to handle our versioning scheme.
    Sergey Teplyakov
    @SergeyTeplyakov
    @sharwell Merged AppVeyor configuration
    Sam Harwell
    @sharwell
    Saw that :)
    Sam Harwell
    @sharwell
    @SergeyTeplyakov @tom-englert I'm re-running the formatter with /rule-:FieldNames, which prevents it from renaming private static and instance fields.
    It makes the review easier, which means we can merge it faster
    then we can deal with field names afterwards
    I closed the existing reformat PRs. As I update them I will reopen them
    Sergey Teplyakov
    @SergeyTeplyakov
    @sharwell Ok. Sounds good. I'll review and merge them as soon as they would be available.
    Sam Harwell
    @sharwell
    @SergeyTeplyakov I looked at #151 to see which files Tom needed reformatted first. Those files are formatted in #152, #153, and #154.
    After you merge those last 3, we can rebase #151 and it will be much easier to review it (since it will no longer contain 7000+ lines of formatting changes).
    Off to lunch now ttyl
    Sam Harwell
    @sharwell
    @SergeyTeplyakov I was hoping to open the conversation re: moving to .NET foundation
    Sergey Teplyakov
    @SergeyTeplyakov
    As I mentioned in the comment. I'l find out how to do this.
    Sergey Teplyakov
    @SergeyTeplyakov
    @sharwell Could you please do not reformat rewriter?
    I'm working on some stuff in that area...
    foxtrot project with Rewriter.cs
    Sam Harwell
    @sharwell
    @SergeyTeplyakov I'm reformatting one project at a time. If there are conflicts, I will redo it. It is not a problem.
    Sergey Teplyakov
    @SergeyTeplyakov
    ok, thanks a lot!
    Sam Harwell
    @sharwell
    @SergeyTeplyakov @tom-englert I'd like your feedback regarding #158. Do we want to go down that path or not?
    It automatically breaks up the 19 current "macro tests" into 3325 "micro tests" that can be run individually (or in whatever grouping you want)
    Sergey Teplyakov
    @SergeyTeplyakov
    I'm a big fan of proper parametrized unit tests. So :clap: from me! That would be awesome to have this stuff!
    Micah Zoltu
    @MicahZoltu
    @sharwell I have used xunit v2 parallelization, it is definitely handy for getting long test runtimes down (not sure if this is a problem for you). We had some integration tests that would take ~35 minutes to run because each test would take 30-120 seconds to run but most of the time was spent waiting for external resources. We converted them to xUnit v2 and got runtime down to ~3.5 minutes with the CPU pegged the whole time.