Your feedback is welcome !
I am publishing the changes needed to support tslint 3.x and typescript 1.7
sadly it is not backwards compatible so we need to bump to version 2.0
people using tslint 2.x will need to use 1.x of our package
people using tslint 3.x will need to use 2.x of our package
hey all, I'm trying to use the tslint:recommended extension but it does not seem to be working.
I am using webpack and my eslint config looks like this:
tslint: {
configuration: {
"extends": "tslint:recommended"
}
},Here is some code that should cause ts-lint warnings but does not:
function hello(foo: string) {
const str : string = 'bar' + foo;
if (str)
console.log('blah')
console.log(str);
}since tslint:recommended includes curly: true, an error should be raised
when I add
rules: {curly: true}to my config I do see errors
Any ideas why this is not working?
Is there a better way than copy pasting the recommended ruleset? Can I use extends like we do with tslint:recommended
Also copy pasting the rules gives off the following erros for me
/usr/local/lib/node_modules/tslint/lib/ruleLoader.js:29
throw new Error(ERROR_MESSAGE);
^
Error:
Could not find implementations for the following rules specified in the configuration:
no-for-in-array
no-unsafe-finally
restrict-plus-operands
arrow-parens
max-file-line-count
no-suspicious-comment
react-a11y-lang
react-a11y-meta
react-a11y-titles
object-literal-key-quotes
Try upgrading TSLint and/or ensuring that you have all necessary custom rules installed.
If TSLint was recently upgraded, you may have old rules configured which need to be cleaned up.
at Object.loadRules (/usr/local/lib/node_modules/tslint/lib/ruleLoader.js:29:15)
at Linter.lint (/usr/local/lib/node_modules/tslint/lib/tslint.js:25:44)
at processFile (/usr/local/lib/node_modules/tslint/lib/tslint-cli.js:131:29)
at Array.forEach (native)
at Object.<anonymous> (/usr/local/lib/node_modules/tslint/lib/tslint-cli.js:141:41)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:458:32)
at tryModuleLoad (module.js:417:12)
at Function.Module._load (module.js:409:3)
@bezreyhan I am sorry, I did not see your message earlier. I think you should ask that question in the tslint channel at #palentir/tslint
Also why do I get an exception about missing implementations when I DO decide to copy over the rules from tslint.json? Is the recommended ruleset out of date?
@foklepoint You are probably copying the tslint.json rules from the master branch, which is for the next release, but then getting the tslint-microsoft-contrib package from npm, which is for the current release. If you look inside the npm package you will see tslint,json, and that is the full ruleset for your release
@foklepoint so you should maybe configure your grunt task like this: rules: './node_modules/tslint-microsoft-contrib/tslint.json'
@foklepoint how does ["tslint:latest"] work? Is that a javascript thing or something that the tslint project wrote themselves?
@HamletDRC Check this out https://palantir.github.io/tslint/2016/03/31/sharable-configurations-rules.html
Seems a lot easier than doing the steps you mentioned above and the configuration will auto-update if you want to stick with the recommended ruleset
@foklepoint ^^
does that not work?
there should be no issues unless you are on really old versions of typescript or tslint
my ts lint is rejecting constructs like
const y = ( x: number ) => x + 2;
it wants me to
const y = ( x: number ) => { return x+2; };
please help
i like the 1st format better
HEEEELP
I think this might be a tslint rule and not a tslint-microsoft-contrib rule that is doing this to you.
I think I might have asked this question in the wrong channel, what is the "microsoft-contrib" part?
So the main product is "TSLint" - they provide the linter and a set of rules.
"tslint-microsoft-contrib" is a set of valuable rules maintained by Microsoft and the community. I think we have 80 or so rules now and we get 50,000 downloads a month... so we are quite popular.
But the base product is tslint. We are an add-on.
"tslint-microsoft-contrib" is a set of valuable rules maintained by Microsoft and the community. I think we have 80 or so rules now and we get 50,000 downloads a month... so we are quite popular.
But the base product is tslint. We are an add-on.
I see the 5.0.1 release was made 2 days ago, but it's still not available on NPM - https://www.npmjs.com/package/tslint-microsoft-contrib
NPM is still on version 5.0.0
i have a React component that renders a simple HTML checkbox
<input type=checkbox …>
the aria-roles rule is telling me i have to provide a valid aria-checked value
this isn’t a controlled checkbox, as in i believe the default behavior of the browser in this case should work fine with screen readers
is this rule supposed to be that stringent about filling in aria attributes? it seems silly that i would have to provide the checked value if it’s literally just behaving as a normal checkbox without any javascript control or anything.
