Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 07 2016 01:23

    MiguelCastillo on v1.2.3

    (compare)

  • Feb 07 2016 01:22

    MiguelCastillo on master

    Release v1.2.3 (compare)

  • Feb 07 2016 01:19

    MiguelCastillo on master

    Update README.md (compare)

  • Feb 07 2016 01:15
    MiguelCastillo closed #28
  • Feb 07 2016 01:14

    MiguelCastillo on fix-28

    (compare)

  • Feb 07 2016 01:14

    MiguelCastillo on master

    Update packages.son and test se… Fixed issue with URL not being … Fixed dangling coma in gulpfile… and 1 more (compare)

  • Feb 07 2016 01:14
    MiguelCastillo closed #29
  • Feb 07 2016 01:11

    MiguelCastillo on fix-28

    Fixed dangling coma in gulpfile… (compare)

  • Feb 07 2016 01:11
    MiguelCastillo synchronize #29
  • Feb 07 2016 01:07
    MiguelCastillo opened #29
  • Feb 07 2016 01:07

    MiguelCastillo on fix-28

    Update packages.son and test se… Fixed issue with URL not being … (compare)

  • Feb 07 2016 01:05
    MiguelCastillo opened #28
  • Jul 08 2015 02:46

    MiguelCastillo on master

    Release v1.2.2 (compare)

  • Jul 08 2015 02:46

    MiguelCastillo on v1.2.2

    Release v1.2.2 (compare)

  • Jul 08 2015 02:43

    MiguelCastillo on description

    (compare)

  • Jul 08 2015 02:43

    MiguelCastillo on master

    updated package.json and readme… Merge pull request #27 from Mig… (compare)

  • Jul 08 2015 02:43
    MiguelCastillo closed #27
  • Jul 08 2015 02:41
    MiguelCastillo opened #27
  • Jul 08 2015 02:41

    MiguelCastillo on description

    updated package.json and readme… (compare)

  • Jul 06 2015 14:14

    MiguelCastillo on package-description

    (compare)

Mark Simulacrum
@Mark-Simulacrum
It has a slightly annoying tendency to bring up the GUI, but it works fine overall.
Really useful due to the ability to put selected text as part of snippet using special snippet marks: https://github.com/zaggino/brackets-snippets#snippet-marks
Mark Simulacrum
@Mark-Simulacrum
for this test, do you want to mention the fact that the base has a space in it?
it("with a dotted path with more base", function() {
  var path = File.mergePaths("../path", "/container/of my/child");
  expect(path).to.equal("/container/of my/path");
});
Miguel Castillo
@MiguelCastillo
sure
Mark Simulacrum
@Mark-Simulacrum
"with a dotted path and a complex base containing spaces" sound good?
Miguel Castillo
@MiguelCastillo
yup perfect
Mark Simulacrum
@Mark-Simulacrum
Do you know if Brackets supports Finding string in selection > multiple cursors? Because that would be really cool.
Miguel Castillo
@MiguelCastillo
string search with multi cursor selections?
not sure
let me test
i dont see how it would support it
Mark Simulacrum
@Mark-Simulacrum
Hmm, perhaps Replace in selection would be more accurate
Miguel Castillo
@MiguelCastillo
no, unfortunately no
Mark Simulacrum
@Mark-Simulacrum
Might look for an issue for that later. Eating for now, be back later.
Miguel Castillo
@MiguelCastillo
ok cool :)
Miguel Castillo
@MiguelCastillo
Hey @Mark-Simulacrum ping me if you are around
please :)
Miguel Castillo
@MiguelCastillo
hey @Mark-Simulacrum I added grunt back in for running our tests in travis
gulp-mocha-phantomjs just does not work with XHR requests...
i tried getting it to work, but the gulp plugins are a rats nest with dependencies that I just couldn't track down where the issue is happening
so for now I am just going to do grunt for running our tests. gulp is still used for script minification and what not
Mark Simulacrum
@Mark-Simulacrum
@MiguelCastillo pinging as requested.
In all the projects where I saw tests, you use SpecRunner.html as the "loader" for tests instead of using Mocha's ability to run node files.
I do see good things about it - in browser live testing - but I also don't think that is worth it considering the fact that it is much easier to use Node to load the file in dist/, at least in my opinion.
Miguel Castillo
@MiguelCastillo
good point
are you specifically talking why we are even running these tests in a browser?
Mark Simulacrum
@Mark-Simulacrum
Yes
Miguel Castillo
@MiguelCastillo
i am ok moving all these tests to run directly on node... But I still would like to run tests against a browser because that's the intended target platform.
Mark Simulacrum
@Mark-Simulacrum
I understand the reason why running them in-browser is good... I'm trying to figure out why Mocha works with grunt's phantomjs and not Gulp's. I think that would be the better solution; as then the tests will at least run in PhantomJS (if not Chrome/Firefox/etc)
I also found the line(s) in PhantomJS's source code that appear to set the status code of the XMLHttpRequest: https://github.com/ariya/phantomjs/blob/master/src/qt/qtwebkit/Source/WebCore/xml/XMLHttpRequest.cpp#L1073-L1085
Miguel Castillo
@MiguelCastillo
i spent a bunch of hours yesterday debugging this issue yesterday and gave up... definitely not a priority given that it is an issue that isn't in our code and there is viable work around for now. Fixing the issue in phantomjs would have put me way behind with me plans with bitimports
which by the way, it is going freaking awesome
you finding the line in phantomjs is really AWESOME~
we can probably see if this is a regression and what not...
i got working within one hr
which is really cool...
Mark Simulacrum
@Mark-Simulacrum
I'm happy that it only took one hour :)
Miguel Castillo
@MiguelCastillo
oh yeah man, i am really happy with how this is turning out...
the workflow is to browserify 6to5, then write this little wrapper https://github.com/MiguelCastillo/bit-transforms-sandbox/blob/master/transforms/6to5.js
put it in your config for transforms and bitimports does its thing
Mark Simulacrum
@Mark-Simulacrum
Looks really nice. I've always wanted to use ES6 more; but never had the time to set up a transform. Now that bitimports can do it this easily, might want to do that :)
Miguel Castillo
@MiguelCastillo
yeah dude :)
my friend Brian runs this http://learnharmony.org/
I am thinking about integrating bitimports to see how it works
Mark Simulacrum
@Mark-Simulacrum
Integrating 6to5 into bitimports?
Miguel Castillo
@MiguelCastillo
no, integrating bitimports into his site to showcase ES6 features
currently he uses traceur
Mark Simulacrum
@Mark-Simulacrum
16% difference in supported features according to http://kangax.github.io/compat-table/es6/; I would say it is worth it - and would also show how easy/hard it is to do
Miguel Castillo
@MiguelCastillo
yeah exactly :)