These are chat archives for MiguelCastillo/bit-loader

2nd
Jan 2015
Miguel Castillo
@MiguelCastillo
Jan 02 2015 16:33
Hey @Mark-Simulacrum this is the module loading pipeline I created
this it the core for dependency loading and management
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 16:33
Okay
Miguel Castillo
@MiguelCastillo
Jan 02 2015 16:34
this is the AMD implementation on top of it https://github.com/MiguelCastillo/amd-loader
i need add a few things to the AMD implementation... But the basics are working
I need to wire up the middleware pipeline in bit-loader
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 16:42
I'll clone bit loader down now :)
Miguel Castillo
@MiguelCastillo
Jan 02 2015 16:42
cool!
i am really happy with how it turned out actually
I can walk you through the architecture a bit later
I gotta write it up in the readmee :)
the connecting point between bit-loader and amd-loader is the Fetch contract
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 16:49
Do you want me to put up a pr renaming MLoader to BitLoader in bit-loader.js?
Miguel Castillo
@MiguelCastillo
Jan 02 2015 16:50
yeah if there are any left for sure!
oh yeah, I missed a few spots in the rebranding there
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 16:52
Why do you have mloader-release in the dist dir? Should I remove it? The tests link to it...
Also, should I run the prepublish task to compile bit-loader into the dist dir before submitting my PR?
Miguel Castillo
@MiguelCastillo
Jan 02 2015 16:58
i have mloader-release there as a reference for now... We can remove it since it is already in https://github.com/MiguelCastillo/bit-loader-goundzero
remove it in your PR
you dont run prepublish... That's automatically executed when you run npm install
so all you need to do is npm install to get dependencies and build
then npm test to make sure tests pass :)
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 16:59
Right, so I should do that, and submit the changes to dist/bit-loader.js in my PR?
Miguel Castillo
@MiguelCastillo
Jan 02 2015 16:59
yup
i would like to automate the build with travis soon and have travis check in bit-loader.js for us when the build passes
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:01
Makes sense. I might see what I can do about that if you want
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:01
sure!
i already have a workflow for that... I can get it started and we can go from there
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:03
#2 is open with the rename changes. All tests pass.
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:04
yup, saw it
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:19
Should I change spromise to also do this instead of depending on grunt-cli in package.json? (MiguelCastillo/bit-loader@bba8c80)
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:20
Sure
i cant remember what happened when I tried to do it before
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:22
I'll try it - if it doesn't work, no accepting the PR :)
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:22
:) sounds good
i think you need to merge master into your pr
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:25
Okay, it looks like travis is not happy with it :)
#2 seems to be good with Travis after the merge.
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:27
cool
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:35
It seems that travis can run commands after the build succeeds, but I'm not sure how to get Travis to commit the code and push it into the project. Travis can create a release, but that isn't quite what we want.
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:37
yeah so you need to basically write some scritping to do that
let me look up a link
scroll to the bottom
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:39
I see it. Will set something up for Travis then :)
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:39
cool
I havent done it myself... but it is possible
i will setup hooks to github release the way I have in spromise https://github.com/MiguelCastillo/spromise/releases
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:47
amd-loader and bit-loader have travis integration
I gotta run a few errands but I will be back later to finish up some work on AMD
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:47
I don't think that what the link you posted suggests is secure, as it will expose the token publicly, allowing (anyone?) to commit to bit-loader. The way they would do this is by submitting a pull request with a change to travis ci, adding something like the following to the .travis.yml file, outputting the "secret" token.
before_script:
   - echo $GH_TOKEN
I'll look into how to do it more, though. See you later!
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:48
right so what you do is encrypt the key with travis tools
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:49
It would be encrypted, but since Travis would decrypt the key at the start of the test, anyone could access it as I showed.. right?
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:50
no. the decryption step isn't visible
take a quick peek at how emberjs does it for example https://github.com/emberjs/ember.js/blob/master/.travis.yml
dont let this particular thing hold you back from getting into the code though... particularly amd-loader
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:52
Ah, I see now. Okay. I'll start looking into amd-loader now; might return to auto deploying the builds later.
Miguel Castillo
@MiguelCastillo
Jan 02 2015 17:52
I need to migrate the tests that are commented out here https://github.com/MiguelCastillo/bit-loader/blob/master/tests/specs/bit-loader.js
i gotta migrate them to amd-loader
it will get you some good insight :)
catch you later man
Mark Simulacrum
@Mark-Simulacrum
Jan 02 2015 17:53
:wave:
See you